From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEA93CA0ED3 for ; Wed, 4 Sep 2024 07:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F6fZBwT54UOaKg1hvIcWbyldUDjZ9UiSYDHCWdXEe7s=; b=mNnSD0pRwLfqZPviTdvcESbp2m 0g+5+lfRVAuJmrB45Zf7E5oTdDGzdU98snAIgzhlS2MhKzeIQw06WB7Zg/+tOYs0teT6DckOkGpLb mgqD6pZ3RwZZUX+4dEC811MfT1NsMUAsYGuILpL9iwhXhyhrzpcEb00ZttB4vTD4NyDgtDHduuhpv KNGUc3Fuec9dWkv7417Dkbd69ijuFskNlv26+C4nZ//WEl554nFq5E/nEe3KZrqKkFCSLBS4a38cb FTBuDO83obX8wHbixJGJaWU1U+12iAaGHTyWbof4Hn/6KXj/JmVemHp3LxkMc1nJqmL55lvSs98G8 PCaDa9CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slkMz-00000003AvY-2wWD; Wed, 04 Sep 2024 07:24:01 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slkJt-00000003AM6-1rB9 for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 07:20:50 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 362F15C5597; Wed, 4 Sep 2024 07:20:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54B1CC4CEC2; Wed, 4 Sep 2024 07:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725434448; bh=7LNfFiXbjo7lumWI/Ys4K1KVKj5QLLQTvPgzMihTVLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LTd51cB0yGAuYjeno1J2UWEv7/7gArrZ7IBToGz6QzZsNCKj+QbqAYJdMQ3/dyYRN YL/dwbAjpfUvR9VPsAYy0vHyZ4XPALgWbspaasFM9940SSFqaCf8eEF5Ho57E9YDG7 gChUFcggE6rh25N63HE2IdPyeGTpwVkUtpS0TT36XIAFq947IT9352ZZtVP54I3KZS nejZ8FR6lRoDstltzzwnH148Yw110UOD4lmeLpUoZ9VQ5WAGfCw1yobjBobAnEwNj1 BuXJoEzc+JKJbJvnUshTIrS3pIT6jXZBSWFRnHirTm092x0bsZdLTaAYhl6ZCHiTzC fyA6VviQS4dfw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1slkK8-000000001SQ-1Ggi; Wed, 04 Sep 2024 09:21:05 +0200 Date: Wed, 4 Sep 2024 09:21:04 +0200 From: Johan Hovold To: Sibi Sankar Cc: ulf.hansson@linaro.org, sudeep.holla@arm.com, cristian.marussi@arm.com, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, quic_rgottimu@quicinc.com, quic_kshivnan@quicinc.com Subject: Re: [PATCH] pmdomain: arm: Fix debugfs node creation failure Message-ID: References: <20240703110741.2668800-1-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240703110741.2668800-1-quic_sibis@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_002049_555469_CDE050AB X-CRM114-Status: GOOD ( 13.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 03, 2024 at 04:37:41PM +0530, Sibi Sankar wrote: > The domain attributes returned by the perf protocol can end up > reporting identical names across domains, resulting in debugfs > node creation failure. Fix this duplication by appending the > domain-id to the domain name. > > Logs: > debugfs: Directory 'NCC' with parent 'pm_genpd' already present! > debugfs: Directory 'NCC' with parent 'pm_genpd' already present! > > Fixes: 2af23ceb8624 ("pmdomain: arm: Add the SCMI performance domain") Please include: Reported-by: Johan Hovold Link: https://lore.kernel.org/lkml/ZoQjAWse2YxwyRJv@hovoldconsulting.com/ > Signed-off-by: Sibi Sankar I now that this patch is being reworked, but please note that the following warnings that I reported are seen also with this patch: [ 9.119117] arm-scmi firmware:scmi: Failed to add opps_by_lvl at 3417600 for NCC - ret:-16 [ 9.129146] arm-scmi firmware:scmi: Failed to add opps_by_lvl at 3417600 for NCC - ret:-16 [ 9.160328] arm-scmi firmware:scmi: Failed to add opps_by_lvl at 3417600 for NCC - ret:-16 [ 9.175229] arm-scmi firmware:scmi: Failed to add opps_by_lvl at 3417600 for NCC - ret:-16 which seems to suggest that the approach taken by this patch is not necessarily the right one. Can you please also comment on why this is an issue on x1e80100 in the commit message? Johan