[PATCH 00/11] Add support for RaspberryPi RP1 PCI device using a DT overlay

Andrea della Porta
2024-08-20T14:37:27Z

RP1 is an MFD chipset that acts as a south-bridge PCIe endpoint sporting
a pletora of subdevices (i.e. Ethernet, USB host controller, I2C, PWM,
etc.) whose registers are all reachable starting from an offset from the
BAR address. The main point here is that while the RP1 as an endpoint
itself is discoverable via usual PCI enumeraiton, the devices it contains
are not discoverable and must be declared e.g. via the devicetree.

This patchset is an attempt to provide a minimum infrastructure to allow
the RP1 chipset to be discovered and perpherals it contains to be added
from a devictree overlay loaded during RP1 PCI endpoint enumeration.
Followup patches should add support for the several peripherals contained
in RP1.

This work is based upon dowstream drivers code and the proposal from RH
et al. (see [1] and [2]). A similar approach is also pursued in [3].

The patches are ordered as follows:

-PATCHES 1 and 2: add binding schemas for clock and gpio peripherals
found in RP1. They are needed to support the other peripherals, e.g.
the ethernet mac depends on a clock generated by RP1 and the phy is
reset though the on-board gpio controller.

-PATCHES 3, 4 and 5: preparatory patches that fix the address mapping
translation (especially wrt dma-ranges) and permit to place the dtbo
binary blob to be put in non transient section.

-PATCH 6 and 7: add clock and gpio device drivers.

-PATCH 8: this is the main patch to support RP1 chipset and peripherals
enabling through dtb overlay. It contains the dtso since its intimately
coupled with the driver and will be linked in as binary blob in the driver
obj, but of course it can be easily split in a separate patch if the
maintainer feels it so. The real dtso is in devicetree folder while
the dtso in driver folder is just a placeholder to include the real dtso.
In this way it is possible to check the dtso against dt-bindings.

-PATCH 9: add the relevant kernel CONFIG_ options to defconfig.

-PATCHES 10 and 11: these (still unpolished) patches are not intended to
be upstreamed (yet), they serve just as a test reference to be able to
use the ethernet MAC contained in RP1.

This patchset is also a first attempt to be more agnostic wrt hardware
description standards such as OF devicetree and ACPI, where 'agnostic'
means "using DT in coexistence with ACPI", as been alredy promoted
by e.g. AL (see [4]). Although there's currently no evidence it will also
run out of the box on purely ACPI system, it is a first step towards
that direction.

Please note that albeit this patchset has no prerequisites in order to
be applied cleanly, it still depends on Stanimir's WIP patchset for BCM2712
PCIe controller (see [5]) in order to work at runtime.

Many thanks,
Andrea della Porta

Link:
- [1]: https://lpc.events/event/17/contributions/1421/attachments/1337/2680/LPC2023%20Non-discoverable%20devices%20in%20PCI.pdf
- [2]: https://lore.kernel.org/lkml/20230419231155.GA899497-robh@kernel.org/t/
- [3]: https://lore.kernel.org/all/20240808154658.247873-1-herve.codina@bootlin.com/#t
- [4]: https://lore.kernel.org/all/73e05c77-6d53-4aae-95ac-415456ff0ae4@lunn.ch/
- [5]: https://lore.kernel.org/all/20240626104544.14233-1-svarbanov@suse.de/

Andrea della Porta (11):
dt-bindings: clock: Add RaspberryPi RP1 clock bindings
dt-bindings: pinctrl: Add RaspberryPi RP1 gpio/pinctrl/pinmux bindings
PCI: of_property: Sanitize 32 bit PCI address parsed from DT
of: address: Preserve the flags portion on 1:1 dma-ranges mapping
vmlinux.lds.h: Preserve DTB sections from being discarded after init
clk: rp1: Add support for clocks provided by RP1
pinctrl: rp1: Implement RaspberryPi RP1 gpio support
misc: rp1: RaspberryPi RP1 misc driver
arm64: defconfig: Enable RP1 misc/clock/gpio drivers as built-in
net: macb: Add support for RP1's MACB variant
arm64: dts: rp1: Add support for MACB contained in RP1

.../clock/raspberrypi,rp1-clocks.yaml | 87 +
.../pinctrl/raspberrypi,rp1-gpio.yaml | 177 ++
MAINTAINERS | 12 +
arch/arm64/boot/dts/broadcom/rp1.dtso | 175 ++
arch/arm64/configs/defconfig | 3 +
drivers/clk/Kconfig | 9 +
drivers/clk/Makefile | 1 +
drivers/clk/clk-rp1.c | 1655 +++++++++++++++++
drivers/misc/Kconfig | 1 +
drivers/misc/Makefile | 1 +
drivers/misc/rp1/Kconfig | 20 +
drivers/misc/rp1/Makefile | 3 +
drivers/misc/rp1/rp1-pci.c | 333 ++++
drivers/misc/rp1/rp1-pci.dtso | 8 +
drivers/net/ethernet/cadence/macb.h | 25 +
drivers/net/ethernet/cadence/macb_main.c | 152 +-
drivers/of/address.c | 3 +-
drivers/pci/of_property.c | 5 +-
drivers/pci/quirks.c | 1 +
drivers/pinctrl/Kconfig | 10 +
drivers/pinctrl/Makefile | 1 +
drivers/pinctrl/pinctrl-rp1.c | 719 +++++++
include/asm-generic/vmlinux.lds.h | 2 +-
include/dt-bindings/clock/rp1.h | 56 +
include/dt-bindings/misc/rp1.h | 235 +++
include/linux/pci_ids.h | 3 +
26 files changed, 3692 insertions(+), 5 deletions(-)
create mode 100644 Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml
create mode 100644 Documentation/devicetree/bindings/pinctrl/raspberrypi,rp1-gpio.yaml
create mode 100644 arch/arm64/boot/dts/broadcom/rp1.dtso
create mode 100644 drivers/clk/clk-rp1.c
create mode 100644 drivers/misc/rp1/Kconfig
create mode 100644 drivers/misc/rp1/Makefile
create mode 100644 drivers/misc/rp1/rp1-pci.c
create mode 100644 drivers/misc/rp1/rp1-pci.dtso
create mode 100644 drivers/pinctrl/pinctrl-rp1.c
create mode 100644 include/dt-bindings/clock/rp1.h
create mode 100644 include/dt-bindings/misc/rp1.h

--
2.35.3