Re: [PATCH 02/11] dt-bindings: pinctrl: Add RaspberryPi RP1 gpio/pinctrl/pinmux bindings

Krzysztof Kozlowski
2024-08-30T11:47:52Z

On 30/08/2024 12:22, Andrea della Porta wrote:
> Hi Krzysztof,
>

...

>>> +#define RP1_USBHOST0_AXIS_BASE 0x200000
>>> +#define RP1_USBHOST1_AXIS_BASE 0x300000
>>> +#define RP1_EXAC_BASE 0x400000
>>> +
>>> +/* Interrupts */
>>> +
>>> +#define RP1_INT_IO_BANK0 0
>>> +#define RP1_INT_IO_BANK1 1
>>
>> Also no, interrupt numbers are not considered bindings. That's too much
>> churn. Otherwise, please point me to driver code using the define
>> (directly! that's the requirement).
>
> As mentioned above, RP1_INT_END is used in rp1-pci.c. To get rid of all those

Number of interrupts is not a binding, either. Does not appear in the DTS.

> macroes from dt-binding would mean to hardcode the interrupt number in both
> the binding example and in dtso, from this:
>
> interrupts = <RP1_INT_IO_BANK0 IRQ_TYPE_LEVEL_HIGH>,
> <RP1_INT_IO_BANK1 IRQ_TYPE_LEVEL_HIGH>,
> <RP1_INT_IO_BANK2 IRQ_TYPE_LEVEL_HIGH>;
>
> to this:
>
> interrupts = <0 IRQ_TYPE_LEVEL_HIGH>,
> <1 IRQ_TYPE_LEVEL_HIGH>,
> <2 IRQ_TYPE_LEVEL_HIGH>;
>
> is this what you are proposing?

Yes, just like every DTS does. I think the hard-coding of numbers is not
a problem.

Best regards,
Krzysztof