Re: [PATCH 11/11] arm64: dts: rp1: Add support for MACB contained in RP1

Andrea della Porta
2024-08-30T22:40:18Z

Hi Krzysztof,

On 10:43 Wed 21 Aug , Krzysztof Kozlowski wrote:
> On Tue, Aug 20, 2024 at 04:36:13PM +0200, Andrea della Porta wrote:
> > RaspberryPi RP1 is multi function PCI endpoint device that
> > exposes several subperipherals via PCI BAR.
> > Add an ethernet node for Cadence MACB to the RP1 dtso
> >
> > Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> > ---
> > arch/arm64/boot/dts/broadcom/rp1.dtso | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/broadcom/rp1.dtso b/arch/arm64/boot/dts/broadcom/rp1.dtso
> > index d80178a278ee..b40e203c28d5 100644
> > --- a/arch/arm64/boot/dts/broadcom/rp1.dtso
> > +++ b/arch/arm64/boot/dts/broadcom/rp1.dtso
> > @@ -78,6 +78,29 @@ rp1_clocks: clocks@c040018000 {
> > <50000000>; // RP1_CLK_ETH_TSU
> > };
> >
> > + rp1_eth: ethernet@c040100000 {
> > + reg = <0xc0 0x40100000 0x0 0x4000>;
> > + compatible = "cdns,macb";
>
> Please start using DTS coding style...

Ack.

Regards,
Andrea

>
> Best regards,
> Krzysztof
>