Re: [PATCH 00/11] Add support for RaspberryPi RP1 PCI device using a DT overlay

Andrea della Porta
2024-08-29T12:03:13Z

Hi Andrew,

On 15:04 Thu 22 Aug , Andrew Lunn wrote:
> > WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
> > #673: FILE: drivers/pinctrl/pinctrl-rp1.c:600:
> > + return -ENOTSUPP;
> >
> > This I must investigate: I've already tried to fix it before sending the patchset
> > but for some reason it wouldn't work, so I planned to fix it in the upcoming
> > releases.
>
> ENOTSUPP is an NFS error. It should not be used outside for NFS. You
> want EOPNOTSUPP.

Ack.

>
>
> > WARNING: externs should be avoided in .c files
> > #331: FILE: drivers/misc/rp1/rp1-pci.c:58:
> > +extern char __dtbo_rp1_pci_begin[];
> >
> > True, but in this case we don't have a symbol that should be exported to other
> > translation units, it just needs to be referenced inside the driver and
> > consumed locally. Hence it would be better to place the extern in .c file.
>
> Did you try making it static.

The dtso is compiled into an obj and linked with the driver which is in
a different transaltion unit. I'm not aware on other ways to include that
symbol without declaring it extern (the exception being some hackery
trick that compile the dtso into a .c file to be included into the driver
main source file).
Or probably I'm not seeing what you are proposing, could you please elaborate
on that?

Many thanks,
Andrea

>
> Andrew