From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A733CD3431 for ; Wed, 4 Sep 2024 09:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ALxu45xu13GhaDzSJpduPtJv/caKy8w0oIUIS4mfKn0=; b=2XWZoYCz36I5nymss19zhBXDtJ kH5D/kvJSoKsu4vEpEPfnIHsUM2vKaLrhYTHWe2VGai66HL4X0rnOyaukBzkjSSFzt2dw99PILTZG hhVHGyO8kA9rY0cbt4s9ckzOkYCvBK0DYsPWKm9YjgugTya9R7V2S+t2IOPKtulU4aO59HnM7Rlsi Etzi4gZZtC9PQQUmint14wzkofto6za2WYTGQ/VUa7taorb7NVNUKzELFIJTg0siE/Vo/FKoZOD2k 0g8i9KXnMu4aYscNX6RcWHhHdOlEYsBD4+QqBBHta2VLpk1U36ns8r7mfrx308Y7vRDUW4SuK8RAS RWbAVffw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slmbz-00000003l8G-1w6A; Wed, 04 Sep 2024 09:47:39 +0000 Received: from pidgin.makrotopia.org ([2a07:2ec0:3002::65]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sllxH-00000003aJP-3BPR; Wed, 04 Sep 2024 09:05:37 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98) (envelope-from ) id 1sllx9-000000004Br-3pNB; Wed, 04 Sep 2024 09:05:28 +0000 Date: Wed, 4 Sep 2024 11:02:11 +0200 From: Daniel Golle To: SkyLake Huang =?utf-8?B?KOm7g+WVn+a+pCk=?= Cc: "andrew@lunn.ch" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux@armlinux.org.uk" , "kuba@kernel.org" , "pabeni@redhat.com" , "edumazet@google.com" , "netdev@vger.kernel.org" , "dqfext@gmail.com" , Steven Liu =?utf-8?B?KOWKieS6uuixqik=?= , "matthias.bgg@gmail.com" , "davem@davemloft.net" , "hkallweit1@gmail.com" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH net-next v10 11/13] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988 Message-ID: References: <20240701105417.19941-1-SkyLake.Huang@mediatek.com> <20240701105417.19941-12-SkyLake.Huang@mediatek.com> <38189661f30032715783e8860318fe9e50258e47.camel@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <38189661f30032715783e8860318fe9e50258e47.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_020535_816471_B5037685 X-CRM114-Status: UNSURE ( 7.34 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi SkyLake, On Wed, Sep 04, 2024 at 08:49:50AM +0000, SkyLake Huang (黃啟澤) wrote: > > Gentle ping. > Please see issue reported related to your patch "net: phy: mediatek: Extend 1G TX/RX link pulse time" https://github.com/openwrt/openwrt/issues/16281 Using the newly introduced .read_status function apparently breaks things. Maybe we can apply the rest of this series first and then discuss the problematic patch (which may need fixing) after that.