From: Cristian Marussi <cristian.marussi@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Johan Hovold <johan@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
cristian.marussi@arm.com, linux-kernel@vger.kernel.org,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V2 1/2] firmware: arm_scmi: Ensure that the message-id supports fastchannel
Date: Wed, 4 Sep 2024 15:20:03 +0100 [thread overview]
Message-ID: <ZthrRHmV8xTsPbZ8@pluto> (raw)
In-Reply-To: <ZthU36Qkzwa5Ilrb@bogus>
On Wed, Sep 04, 2024 at 01:38:55PM +0100, Sudeep Holla wrote:
> On Wed, Sep 04, 2024 at 01:29:29PM +0200, Konrad Dybcio wrote:
> > On 4.09.2024 9:00 AM, Johan Hovold wrote:
>
> [...]
>
> > >
> > > Unfortunately, this patch breaks resume from suspend on the x1e80100 crd:
> > >
> > > [ 26.919676] CPU4: Booted secondary processor 0x0000010000 [0x511f0011]
> > > [ 26.960607] arm-scmi firmware:scmi: timed out in resp(caller: do_xfer+0x164/0x568)
> > > [ 26.987142] cpufreq: cpufreq_online: ->get() failed
> > >
> > > and then the machine hangs (mostly, I saw an nvme timeout message after a
> > > while).
> > >
> > > Make sure you test suspend as well as some of the warnings I reported
> > > only show up during suspend.
> >
> > Eh it looks like PERF_LEVEL_GET (msgid 8) requires the use of FC, but
> > the firmware fails to inform us about it through BIT(0) in attrs..
> >
>
> Just trying to understand things better here. So the firmware expects OSPM
> to just use FC only for PERF_LEVEL_GET and hence doesn't implement the
> default/normal channel for PERF_LEVEL_GET(I assume it returns error ?)
> but fails to set the attribute indicating FC is available for the domain.
>
Is not that FCs are optional BUT PERF_LEVEL_GET standard messages is
support is mandatory by the spec anyway ?
Thanks,
Cristian
next prev parent reply other threads:[~2024-09-04 14:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 3:13 [PATCH V2 0/2] firmware: arm_scmi: Misc Fixes Sibi Sankar
2024-09-04 3:13 ` [PATCH V2 1/2] firmware: arm_scmi: Ensure that the message-id supports fastchannel Sibi Sankar
2024-09-04 7:00 ` Johan Hovold
2024-09-04 11:29 ` Konrad Dybcio
2024-09-04 12:38 ` Sudeep Holla
2024-09-04 14:20 ` Cristian Marussi [this message]
2024-09-05 12:54 ` Konrad Dybcio
2024-10-07 6:46 ` Sibi Sankar
2024-09-04 3:13 ` [PATCH V2 2/2] firmware: arm_scmi: Skip adding bad duplicates Sibi Sankar
2024-09-04 7:09 ` Johan Hovold
2024-09-04 8:05 ` Johan Hovold
2024-09-04 13:56 ` Konrad Dybcio
2024-09-04 14:00 ` Konrad Dybcio
2024-09-04 15:21 ` Cristian Marussi
2024-09-04 15:30 ` Cristian Marussi
2024-09-04 15:46 ` Cristian Marussi
2024-09-05 12:43 ` Cristian Marussi
2024-10-07 7:00 ` Sibi Sankar
2024-10-09 14:20 ` Cristian Marussi
2024-09-04 16:12 ` Sudeep Holla
2024-09-04 16:20 ` Cristian Marussi
2024-10-07 6:51 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZthrRHmV8xTsPbZ8@pluto \
--to=cristian.marussi@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=johan@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_sibis@quicinc.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).