From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A618CD37B4 for ; Wed, 4 Sep 2024 14:23:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L3YTYacdqNLHavTxhqsr9cfzBa6MC7dyFhUySRnpz9A=; b=v+6/32QustWC6YyUnDVFEOddaK 3MkDhfrIY64Gs31vw70ucQfCK2cRGQ2VO7q7g0Xo+MErD6FSl5w5H8JjF/TdwSrfYKjTHbEVfeZ/q xkUVAqWAt8eOezBbsd4OLmFOyzQyP10SpdyKU+vkHdjWbc28zokg/qYpRmlDOE+pSVKujOyGIjIAs NMHwas3IodCsDPwC3Brh7L9iPyhIG/EEDdhaXWxsOOBbaICJXMtHkxtz4HdQa+3K7TFk3pRXgs7zL KdfoJsILS7dI4oIPhjJOjiXRJPZzueL2fs/xMNvoc3bfydwbDzqAT6f7IyER6lMeQSEgtTbzVPzfC pNjVlr+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slqvC-00000004loR-1Fo3; Wed, 04 Sep 2024 14:23:46 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slqsk-00000004lFy-0Nsn for linux-arm-kernel@bombadil.infradead.org; Wed, 04 Sep 2024 14:21:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=L3YTYacdqNLHavTxhqsr9cfzBa6MC7dyFhUySRnpz9A=; b=QFZH+Uicr/yjvLo8dWtcJ5kPrs vIJNluICvIWFJCJmgNkjowySB5pueeuxKiR8VpQv0jTXdu/AUrAMxNKvfgoUznzTa7F6igwzwJnnp MjExPOpkHxhPibt64sKzhDCPd/rfx4m6JYudyn7+S/LCXEZU4mx2DAbgflHxHXWgfyLlIDnHJ0aIG Gz8+HAewqn/NfpqpjfcGlGbq391DYRUPOSeTjyFlLh5cpIlfN9Bb4sGT9NxxfKeiX1xI8Y5xa8HOM NNaZqJpoHqP/hyJeoJzejcoahoEm9U9UxwpW2NtLu1bD1XCzM5Oh2Y1H1QNPL7Gyf6FEWy6xPZFWD fOxeNWhQ==; Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1slqsA-00000000F09-38aN for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 14:20:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A47711063; Wed, 4 Sep 2024 07:20:38 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 181E63F73F; Wed, 4 Sep 2024 07:20:10 -0700 (PDT) Date: Wed, 4 Sep 2024 15:20:03 +0100 From: Cristian Marussi To: Sudeep Holla Cc: Konrad Dybcio , Johan Hovold , Sibi Sankar , cristian.marussi@arm.com, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH V2 1/2] firmware: arm_scmi: Ensure that the message-id supports fastchannel Message-ID: References: <20240904031324.2901114-1-quic_sibis@quicinc.com> <20240904031324.2901114-2-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_152057_426103_58EF7A40 X-CRM114-Status: GOOD ( 18.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 04, 2024 at 01:38:55PM +0100, Sudeep Holla wrote: > On Wed, Sep 04, 2024 at 01:29:29PM +0200, Konrad Dybcio wrote: > > On 4.09.2024 9:00 AM, Johan Hovold wrote: > > [...] > > > > > > > Unfortunately, this patch breaks resume from suspend on the x1e80100 crd: > > > > > > [ 26.919676] CPU4: Booted secondary processor 0x0000010000 [0x511f0011] > > > [ 26.960607] arm-scmi firmware:scmi: timed out in resp(caller: do_xfer+0x164/0x568) > > > [ 26.987142] cpufreq: cpufreq_online: ->get() failed > > > > > > and then the machine hangs (mostly, I saw an nvme timeout message after a > > > while). > > > > > > Make sure you test suspend as well as some of the warnings I reported > > > only show up during suspend. > > > > Eh it looks like PERF_LEVEL_GET (msgid 8) requires the use of FC, but > > the firmware fails to inform us about it through BIT(0) in attrs.. > > > > Just trying to understand things better here. So the firmware expects OSPM > to just use FC only for PERF_LEVEL_GET and hence doesn't implement the > default/normal channel for PERF_LEVEL_GET(I assume it returns error ?) > but fails to set the attribute indicating FC is available for the domain. > Is not that FCs are optional BUT PERF_LEVEL_GET standard messages is support is mandatory by the spec anyway ? Thanks, Cristian