From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Liu Jing <liujing@cmss.chinamobile.com>
Cc: patrice.chotard@foss.st.com, andersson@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remoteproc:remove redundant dev_err message
Date: Wed, 4 Sep 2024 09:44:07 -0600 [thread overview]
Message-ID: <ZtiAR7Tp2jVOWb2g@p14s> (raw)
In-Reply-To: <20240904020949.11193-1-liujing@cmss.chinamobile.com>
Hi,
There are several other instances such as these in the remoteproc subsystem.
Please send another revision that is addressing them all.
Thanks,
Mathieu
On Wed, Sep 04, 2024 at 10:09:49AM +0800, Liu Jing wrote:
> devm_ioremap_resource already contains error message, so remove
> the redundant dev_err message
>
> Signed-off-by: Liu Jing <liujing@cmss.chinamobile.com>
> diff --git a/drivers/remoteproc/st_slim_rproc.c b/drivers/remoteproc/st_slim_rproc.c
> index d17719384c16..a6e50f51c794 100644
> --- a/drivers/remoteproc/st_slim_rproc.c
> +++ b/drivers/remoteproc/st_slim_rproc.c
> @@ -251,7 +251,6 @@ struct st_slim_rproc *st_slim_rproc_alloc(struct platform_device *pdev,
>
> slim_rproc->mem[i].cpu_addr = devm_ioremap_resource(dev, res);
> if (IS_ERR(slim_rproc->mem[i].cpu_addr)) {
> - dev_err(&pdev->dev, "devm_ioremap_resource failed\n");
> err = PTR_ERR(slim_rproc->mem[i].cpu_addr);
> goto err;
> }
> @@ -262,7 +261,6 @@ struct st_slim_rproc *st_slim_rproc_alloc(struct platform_device *pdev,
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "slimcore");
> slim_rproc->slimcore = devm_ioremap_resource(dev, res);
> if (IS_ERR(slim_rproc->slimcore)) {
> - dev_err(&pdev->dev, "failed to ioremap slimcore IO\n");
> err = PTR_ERR(slim_rproc->slimcore);
> goto err;
> }
> @@ -270,7 +268,6 @@ struct st_slim_rproc *st_slim_rproc_alloc(struct platform_device *pdev,
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "peripherals");
> slim_rproc->peri = devm_ioremap_resource(dev, res);
> if (IS_ERR(slim_rproc->peri)) {
> - dev_err(&pdev->dev, "failed to ioremap peripherals IO\n");
> err = PTR_ERR(slim_rproc->peri);
> goto err;
> }
> --
> 2.33.0
>
>
>
next prev parent reply other threads:[~2024-09-04 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 2:09 [PATCH] remoteproc:remove redundant dev_err message Liu Jing
2024-09-04 15:44 ` Mathieu Poirier [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-09-04 18:54 Liu Jing
2024-09-05 16:22 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtiAR7Tp2jVOWb2g@p14s \
--to=mathieu.poirier@linaro.org \
--cc=andersson@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=liujing@cmss.chinamobile.com \
--cc=patrice.chotard@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).