From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BA71CD4857 for ; Wed, 4 Sep 2024 15:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Lvq181bt53++X2ipAJuBWwtoz5tjcNktNxin7O2M81s=; b=YQWRlR4qfpJXlgXsEV8+H0dKAY dZg/qVj7sVGCyXgDkxWkWrP2T9uv0NKJvaE/ewgGy+0ljLhGE+X55Gnzf7/qI6SDQthJdxMOy/TO8 NbEfkjNkgG30+/hrUyYU1Qp0WYWWy8lBmzbki1H4GLcW3Ed+0gZBCDoKRUgT98RV76fVcbNbv7vuB zbEqRd3vC1Fvpnn9PUdDww7lCpIPQ+5OZW9+XwgUniQAEsgWmqSrY0ECR2VccuOueDfz1/SgzVyEr bt6B/15+6S4Vgw4vhi5NVFuyKlG4kJ6Bg/OsHbncgOZ326lkcdSEo329fwlfoJ531i+Q7k4NAZc+L vloWZCWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slsD5-000000054wl-2jKG; Wed, 04 Sep 2024 15:46:19 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slsB2-000000054MB-31EL for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 15:44:14 +0000 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-7c3d8f260easo3800755a12.1 for ; Wed, 04 Sep 2024 08:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725464651; x=1726069451; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Lvq181bt53++X2ipAJuBWwtoz5tjcNktNxin7O2M81s=; b=Pej374rJBlb37tXaHzXPurpuXG0d5qIqRtH/52NHmfa4cqBrhL6pXFzDoMGy2qzVww j7g6W10NGFDU7H3RbuTXuG/WJYsp8ZI06ZBKI+PKNI2G+UaEEoivbhITSe+pW5/552wX TY07dFxh3JGjk9qhv9pliYWXLJrwPJh7UcEjHJhTwDeS8cskCgF/R5yPKRP4+/oU/bkv FXAqpYg5/gB2n6116m2Q24a8vPbhnue8gPmb7a4efMDFFYBMsVbeApICTVwwL65iyxw1 oENzYaH2DpxZKpsD6MOPaqDJKAkUP0FCosGMQxYpv4t8ciKlX+CfUqGOkQMTiJFEAwCJ 300A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725464651; x=1726069451; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Lvq181bt53++X2ipAJuBWwtoz5tjcNktNxin7O2M81s=; b=QmiazK50X3UvkxjLbmwdH1ppMgZMMjglPPzVkdCN+IUeQnYi/CvwwZYaPIE4a2sX7Y bdNNCky1Ee6Mo5hVsPRP+Hc7tYXV+IV3kbJLn0qEiNx+bDg7ZCrQkGF3Aq48Sn43d1uT lHOciqAvchyw1AwIrPP60BrLOnFUCEWBbmhpBWgQ3L4qgv/d8a0U9HZkLssnzFPaCz52 JB17dQO+/Kapln4ZN5dKxugbQMIMhroLdELqvZLhOq7TcEurM/9+FiVy9tFu4XQ0F5Ko aMf5Ct6wsLn2Vbub43hQoR55BHzGwGlZ3wDsQFbQ3G8M0M2TNkvWeTpJmzOQxCS4w0Mm KPiQ== X-Forwarded-Encrypted: i=1; AJvYcCWt54RVnVaqgWc03iQChBZ+Gg4FJXx6pwLeRtrrxNWk4dDU+CXBU7Laq/itKCLG4adTnDsgBjPzsrdUK1p8tmOn@lists.infradead.org X-Gm-Message-State: AOJu0YymUPeT0ivI2WEPv91axYIKoqjFj70Px7ukFUVXmA6GcuCuNgc4 ljQZMZiq/QE39//0SXBpoASUUZjld4E5s3jcBzBIhOEF8H3nuD9SPOuOA9z9dJl1Mi9yxyWNOtm m X-Google-Smtp-Source: AGHT+IEzkhU1NY+b/rFo3CUIWLkNeW1QOlR8kkj/gEDVFHDtok9gvgAxeDuYVkH4KCg7NBQoom+p7w== X-Received: by 2002:a05:6a20:9f89:b0:1c6:fb2a:4696 with SMTP id adf61e73a8af0-1cce100b917mr22074760637.19.1725464650872; Wed, 04 Sep 2024 08:44:10 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:8490:5dd6:5f49:1365]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71778530830sm1761671b3a.49.2024.09.04.08.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 08:44:10 -0700 (PDT) Date: Wed, 4 Sep 2024 09:44:07 -0600 From: Mathieu Poirier To: Liu Jing Cc: patrice.chotard@foss.st.com, andersson@kernel.org, linux-arm-kernel@lists.infradead.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc:remove redundant dev_err message Message-ID: References: <20240904020949.11193-1-liujing@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240904020949.11193-1-liujing@cmss.chinamobile.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_084412_787567_BA1756D9 X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, There are several other instances such as these in the remoteproc subsystem. Please send another revision that is addressing them all. Thanks, Mathieu On Wed, Sep 04, 2024 at 10:09:49AM +0800, Liu Jing wrote: > devm_ioremap_resource already contains error message, so remove > the redundant dev_err message > > Signed-off-by: Liu Jing > diff --git a/drivers/remoteproc/st_slim_rproc.c b/drivers/remoteproc/st_slim_rproc.c > index d17719384c16..a6e50f51c794 100644 > --- a/drivers/remoteproc/st_slim_rproc.c > +++ b/drivers/remoteproc/st_slim_rproc.c > @@ -251,7 +251,6 @@ struct st_slim_rproc *st_slim_rproc_alloc(struct platform_device *pdev, > > slim_rproc->mem[i].cpu_addr = devm_ioremap_resource(dev, res); > if (IS_ERR(slim_rproc->mem[i].cpu_addr)) { > - dev_err(&pdev->dev, "devm_ioremap_resource failed\n"); > err = PTR_ERR(slim_rproc->mem[i].cpu_addr); > goto err; > } > @@ -262,7 +261,6 @@ struct st_slim_rproc *st_slim_rproc_alloc(struct platform_device *pdev, > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "slimcore"); > slim_rproc->slimcore = devm_ioremap_resource(dev, res); > if (IS_ERR(slim_rproc->slimcore)) { > - dev_err(&pdev->dev, "failed to ioremap slimcore IO\n"); > err = PTR_ERR(slim_rproc->slimcore); > goto err; > } > @@ -270,7 +268,6 @@ struct st_slim_rproc *st_slim_rproc_alloc(struct platform_device *pdev, > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "peripherals"); > slim_rproc->peri = devm_ioremap_resource(dev, res); > if (IS_ERR(slim_rproc->peri)) { > - dev_err(&pdev->dev, "failed to ioremap peripherals IO\n"); > err = PTR_ERR(slim_rproc->peri); > goto err; > } > -- > 2.33.0 > > >