From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF044CD4F21 for ; Wed, 4 Sep 2024 16:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JRqFlvsXoDSeUGvtaHySLF1yn1PJFEHElx3wx2tv56k=; b=16HCtme3gUAgArlKKTHBmrXf/Q 71qzRTnsQmBkiHTCh7efnkwhxlZqVFJ6il9kifyS3nke/tI5hRIxaYSqvzZ7l2DkLEwoCG6Pqt94C 3oasi3M1Z3so1rhvQHV3p18d+bS/GDrc7BbVCU8UEu+BQgOC7T1IJZQgEfhuQ+rnEzgTJXqec7gh0 o6LsvbQh4Ckl/wQUoseIJ9HlEGJxWPs1VYFEjXPUUrlkLuKx7AeUtYRx1RKgTP+aVKWz3shyH3K64 stqsgcR/FoxGZliu+G1EDEVn3YWpbjfiUsY8nTxFU9AhOYr9V0f3hGLfsKnOUIK1HTPdc0tWBF5P3 VBaYYizQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slsu4-00000005GD3-1Rme; Wed, 04 Sep 2024 16:30:44 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slskM-00000005EFs-39Q2 for linux-arm-kernel@bombadil.infradead.org; Wed, 04 Sep 2024 16:20:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JRqFlvsXoDSeUGvtaHySLF1yn1PJFEHElx3wx2tv56k=; b=SU9hT4/0OGDUFx8I1DsMFcZkRv fZir512uDm78Rutr9Yxl7OaKnCq8sepdrg6kom17R3TPxw/GrgqyRt+RhpeNRxN8N6GPsP8VGykCj vr1n5oudeJqiWKMAXI36kX9gjnKNKGYTmCTOQ7cTg/30ZMZDGUQfFVIVWWFCTQAioxbf65hHMhwrU bj6BSZ63aKXuGCHsyZaMfXsVELK1IZswj1Wp1qKb+fp1IKahIdlrxYsZm/0leVJzE5AWMyim/Plqc cG/I8J3vgpg91uHzIoHWXIlpMXfBfpVfZE8MgELHiyv2i0ibV7xIFLVHnnRjM5/ndisS4ygB1aZJ6 nAbb5dlQ==; Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1slskJ-00000000JQe-1ctX for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 16:20:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57C64FEC; Wed, 4 Sep 2024 09:21:04 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BF8DF3F73B; Wed, 4 Sep 2024 09:20:36 -0700 (PDT) Date: Wed, 4 Sep 2024 17:20:34 +0100 From: Cristian Marussi To: Sudeep Holla Cc: Sibi Sankar , cristian.marussi@arm.com, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, johan@kernel.org, konradybcio@kernel.org Subject: Re: [PATCH V2 2/2] firmware: arm_scmi: Skip adding bad duplicates Message-ID: References: <20240904031324.2901114-1-quic_sibis@quicinc.com> <20240904031324.2901114-3-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_172039_609947_2B06C770 X-CRM114-Status: GOOD ( 20.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 04, 2024 at 05:12:29PM +0100, Sudeep Holla wrote: > On Wed, Sep 04, 2024 at 08:43:24AM +0530, Sibi Sankar wrote: > > Ensure that the bad duplicates reported by the platform firmware doesn't > > get added to the opp-tables. > > > > I am really interested to know if the platform firmware is presenting > duplicates intentionally for some unknown reasons and we are just speculating > it to be broken firmware or is it really broken firmware. > > For me, it is very hard to digest something like OPP tables which is there > for a very long time now is not very well understood by firmware authors. > How many duplicates are we seeing on this platform really ? If it is > just one I can understand. More than one is hard to miss from the OPP > tables in the firmware. > > While I am not opposing to make the driver handle these duplicates, > I am just worried if they are put there intentionally for reasons we > don't understand yet or not published. > The number of duplicates reported in logs makes me suspect the same...seems like intentional/by_design .... but at first I stick to the general issue of handling bad fw replies and how to survive kernel side at first...but I indeed share your same concerns... Thanks, Cristian