From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF7E5CD4F20 for ; Thu, 5 Sep 2024 04:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IWRfdlbvaSInRNPfFV16+XU3syzcdJAEwhWZHXGOOlQ=; b=UMmeJtyGy1ESNgHjVcm0ChNQ/v Whs/7z69gmJ99EW85E0FA8fFf9Y4wQkgbtZdMVNI6PM4dH1sEzdEkCsVgH4lVVKDkMkANC+HkoARa vdAno9epTtb8mqMefDXkDbKbT5iTjmtUrU4Aeu5Yn6E5r2BPFS6aAelmZvXsJC7wDSkMycvEUJdnf ECusIm+TuBteAS5zN3Sda7w0qaQZQdSyEa6y/9yTppF/FtowjMqzNKdjzFHo8a4SnczqsnZOcrMpN +Y+mPXUC2p52D/B9uyrVv+lU1lKX2YueIpoOwGw7RiapVbnoqcIw+2HIA31Q5zzz9q1sy26Wicqwr TQgiECNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sm3pR-00000006siC-2d67; Thu, 05 Sep 2024 04:10:41 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sm3oU-00000006sZ4-0EkI for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 04:09:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id ACA48A43FE9; Thu, 5 Sep 2024 04:09:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99605C4CEC4; Thu, 5 Sep 2024 04:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725509380; bh=CgFAoE0nEzqrslNgPcZtYsFOVnY2AUEo7ZAOGjHf8dk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i07Az2WpYl8ZXEjoDLtqgJJH0QeQXjEUmKM3RNMfNxYlwNPZRC9Gcgp3TRHUih53c yyKwBlXwblAYolGW0LB+FQsxw8/W+XgCdqMXTXOvcUyarK0WFdjucdVJ80KmXbJc1C R5thTg4RHm0ngmkTo35GC07zVgv3HkV6kOU3F08yxmMqaJJi+7RfnlSc2sBFOBN41t AlhB0gQlwdwnmDJiDTFSp1Z+craXkvc5fKuxfGUNmVvhfqx138SmVBG4pOVnLvsBCh 3IQqmAuWazlqS70Lsr2Xorzvc9M1uFLyPA2sJkm2pcusVj4Ab5xms3uVeOYdvxSZ1f iUZqhy2RAG7kw== Date: Wed, 4 Sep 2024 21:09:38 -0700 From: Namhyung Kim To: James Clark Cc: irogers@google.com, linux-perf-users@vger.kernel.org, kan.liang@linux.intel.com, ak@linux.intel.com, John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Weilin Wang , Athira Rajeev , Dominique Martinet , Yang Jihong , Colin Ian King , Howard Chu , Ze Gao , Jing Zhang , Sun Haiyong , Yicong Yang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 0/7] Event parsing fixes Message-ID: References: <20240903102005.78049-1-james.clark@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240903102005.78049-1-james.clark@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_210942_250540_EE4BC93D X-CRM114-Status: GOOD ( 25.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 03, 2024 at 11:19:44AM +0100, James Clark wrote: > I rebased this one and made some other fixes so that I could test it, > so I thought I'd repost it here in case it's helpful. I also added a > new test. > > But for the testing it all looks ok. > > There is one small difference where it now hides _all_ default > events, when previously it would only hide some > selected subset of events like "stalled-cycles-frontend". I think > this is now more consistent across platforms because, for example, > Apple M only has cycles and instructions, and the rest of the > default events would always show as there. > > Tested on Raptor Lake, Kaby Lake, Juno, N1, Ampere (with the DSU > cycles PMU) and I also faked an Apple M on Juno. > > Changes since v5: > * Test on x86 non hybrid > * Assume 1 PMU in the test when no PMUs expose /cpus file > > Changes since v4: > > * Hide all default events when not verbose > * Remove previous note about behavior from the cover > letter and replace it with a new note about the new behavior > > Changes since v3: > > * Rebase onto perf-tools-next 6236ebe07 > * Fix Intel TPEBS counting mode test > * Fix arm-spe build > * Add support for DT devices in stat test > * Add a new test for hybrid perf stat default arguments > > Ian Rogers (5): > perf evsel: Add alternate_hw_config and use in evsel__match > perf stat: Uniquify event name improvements > perf stat: Remove evlist__add_default_attrs use strings > perf evsel x86: Make evsel__has_perf_metrics work for legacy events > perf evsel: Remove pmu_name > > James Clark (2): > perf test: Make stat test work on DT devices > perf test: Add a test for default perf stat command Acked-by: Namhyung Kim Thanks, Namhyung > > tools/perf/arch/arm64/util/arm-spe.c | 4 +- > tools/perf/arch/x86/util/evlist.c | 74 +---- > tools/perf/arch/x86/util/evsel.c | 35 ++- > tools/perf/builtin-diff.c | 6 +- > tools/perf/builtin-stat.c | 291 +++++++----------- > tools/perf/tests/parse-events.c | 2 +- > tools/perf/tests/shell/stat.sh | 37 ++- > .../perf/tests/shell/test_stat_intel_tpebs.sh | 11 +- > tools/perf/util/evlist.c | 46 +-- > tools/perf/util/evlist.h | 12 - > tools/perf/util/evsel.c | 28 +- > tools/perf/util/evsel.h | 22 +- > tools/perf/util/metricgroup.c | 4 +- > tools/perf/util/parse-events.c | 58 ++-- > tools/perf/util/parse-events.h | 8 +- > tools/perf/util/parse-events.y | 2 +- > tools/perf/util/pmu.c | 6 +- > tools/perf/util/pmu.h | 2 +- > tools/perf/util/stat-display.c | 109 +++++-- > tools/perf/util/stat-shadow.c | 14 +- > tools/perf/util/stat.c | 2 +- > 21 files changed, 360 insertions(+), 413 deletions(-) > > -- > 2.34.1 >