From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B69CCD5BA0 for ; Thu, 5 Sep 2024 09:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8LgmwilwZTv00oKOBkFrZ/42OcenxN7DIQ4qoy+ip1I=; b=epVkplNk89kPYgLS3z0UrHpKxU 1Ia+5K92By+ETV/6E8lq6eiXvsptT2Dyenk0LVDeQt27N9kcGRv4qK2yVaZzU5YgMxKvOxnqFaNu1 M09akhbfLNW+87tjMEypEoJodauKaYmK4QFU2xXyV0mN1h50fKpT/bSZhHf7h8k4mAtZcf7U5nf0F sgOKNzT0qYEhZyfihgSAofRq05JDjBgo89q/NHIgofIo0amxQX0gbyAkDCG+r1N2SZKL/EiyORTo6 jYdnZwPn5IorxAWnjnmOrrJranrt2ojYsyBKTH6aVW2VjgGHvHJ8QgOgSG0dMCfx3F941HcBKJoco i+/AfHqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sm8i7-00000007kWF-0tpv; Thu, 05 Sep 2024 09:23:27 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sm8h9-00000007kKh-0cFj for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 09:22:28 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4280ca0791bso3898365e9.1 for ; Thu, 05 Sep 2024 02:22:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725528145; x=1726132945; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=8LgmwilwZTv00oKOBkFrZ/42OcenxN7DIQ4qoy+ip1I=; b=MFkX3Z2vxxumRHYYXSibeLvjS3iNUWipfo6KMb68KlOsA9CpKpl1/qe0mqDToAzh/n ZAklcj4MIkR1/cecL+iYANQI2ficG/G3hXZn+RSD6Wq8TyiP83g/9WJWXNqUDYzQSyxt dSmdvkqcw/e9SyuPK5OZsQ02Ta1s4VGMxiDZ4N7UPXJbS1dv2n7SDrxFOtH6pOXsI/Tl NhzW6pF/wtIqRIBAFIFpOkW2xyWocNCM5ZmhnlniTFdWUxIigliCj18JGlfH3APXMFQM wubjcVtq5OT3BqS34ef2LIpHxDqD84Q8aG1qUPRTbIod5WTi8yidvyTYdHCHglbYi8+8 Ps8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725528145; x=1726132945; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8LgmwilwZTv00oKOBkFrZ/42OcenxN7DIQ4qoy+ip1I=; b=DolABPtDYY2AAt1AE4zcb4XULMsBGb6IA/bZkrX5CX44Be+BubDl1DD94EucWYtDta DsS2RT97gpXs9CWKVXyMCFyasD301dzGWVI3m0pQ67M163zkz73cflytzeH9T3Qti4pZ f6JRx9JrbN8+SrNNaLxSdmOFVXkaasnlzvdd+WnE2pr5mTTr5HH0CFSgNigLFDOCIij8 xZ1tnQHlU5Dy40crHweG7ZTl4nmYDNB896Y1H4Vzq4uil/yCO4HuZUuYUaYCBk4ToTo2 PK6um9O2IwaEQYLo4r4SeqT2xOY7jiPg7GopP5/HVWAxjQdGDgfBsousdwv+SdNYy91S Lgzw== X-Forwarded-Encrypted: i=1; AJvYcCWEkoZTiu6M7rD8r+iAX4LrsMiCwxPE/v49ZNZuvs5jZqh5pspFI4GkFshsgG+G3ku9pRxgNu2PclkLJHlXAarc@lists.infradead.org X-Gm-Message-State: AOJu0YwrFxT81mYerbf4D4agqBW5uyAEZSvOsNxdOrnXneOe1yxrXBDJ 8+we44b0zCecVgNFoLc0jUXnJryQu2O6YcXscNL74HtswNq1rxf9 X-Google-Smtp-Source: AGHT+IFUdfGNW49G4+DfGHtef+3iH+rTqtv4vp7wb8eaC9NCVgAim+dCJf5aeZgCMrKkgfBOdEZuqg== X-Received: by 2002:a05:600c:19d2:b0:427:fa39:b0db with SMTP id 5b1f17b1804b1-42c8de9ddb6mr49602095e9.27.1725528144107; Thu, 05 Sep 2024 02:22:24 -0700 (PDT) Received: from gmail.com (1F2EF525.unconfigured.pool.telekom.hu. [31.46.245.37]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ba6425a77sm266553755e9.45.2024.09.05.02.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 02:22:23 -0700 (PDT) Date: Thu, 5 Sep 2024 11:22:20 +0200 From: Ingo Molnar To: Colton Lewis Cc: kvm@vger.kernel.org, Oliver Upton , Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Will Deacon , Russell King , Catalin Marinas , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 4/5] x86: perf: Refactor misc flag assignments Message-ID: References: <20240904204133.1442132-1-coltonlewis@google.com> <20240904204133.1442132-5-coltonlewis@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240904204133.1442132-5-coltonlewis@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_022227_396170_4BFBEE69 X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Colton Lewis wrote: > Break the assignment logic for misc flags into their own respective > functions to reduce the complexity of the nested logic. > > Signed-off-by: Colton Lewis > --- > arch/x86/events/core.c | 31 +++++++++++++++++++++++-------- > arch/x86/include/asm/perf_event.h | 2 ++ > 2 files changed, 25 insertions(+), 8 deletions(-) > > diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c > index 760ad067527c..87457e5d7f65 100644 > --- a/arch/x86/events/core.c > +++ b/arch/x86/events/core.c > @@ -2948,16 +2948,34 @@ unsigned long perf_arch_instruction_pointer(struct pt_regs *regs) > return regs->ip + code_segment_base(regs); > } > > +static unsigned long common_misc_flags(struct pt_regs *regs) > +{ > + if (regs->flags & PERF_EFLAGS_EXACT) > + return PERF_RECORD_MISC_EXACT_IP; > + > + return 0; > +} > + > +unsigned long perf_arch_guest_misc_flags(struct pt_regs *regs) > +{ > + unsigned long guest_state = perf_guest_state(); > + unsigned long flags = common_misc_flags(); > + > + if (guest_state & PERF_GUEST_USER) > + flags |= PERF_RECORD_MISC_GUEST_USER; > + else if (guest_state & PERF_GUEST_ACTIVE) > + flags |= PERF_RECORD_MISC_GUEST_KERNEL; > + > + return flags; > +} > + > unsigned long perf_arch_misc_flags(struct pt_regs *regs) > { > unsigned int guest_state = perf_guest_state(); > - int misc = 0; > + unsigned long misc = common_misc_flags(); So I'm quite sure this won't even build at this point ... Thanks, Ingo