From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FF92CD5BA1 for ; Thu, 5 Sep 2024 09:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dYxgkAANBViVPNy8ClXjafqQATE1JazRDJbttnPzMRI=; b=zg27kCgk1HnhoG4fga7hZiPUQI wVVLves1ALdbhxTh6ym9XoZderIL6afWwKhrA7L55HYhhN9u8zQasQnRvBpyKZs0VvQSQ/eAkMErW lHjZ75wQVfd7SHQSBII9s/6tUF8hWiH6RkV36RELpXwV8VRTB6af73UkMjlqoSvDlnnCQoS1M0PBb ZMeYF/8ZOdFwe+wlRQfG3h8pSB8Pmm33KI1K2d0zuunY11pIWeE5vhDffAI3hPEJtIpMxFW0OpA17 oX+QGNQGxX3iCAaDbaCpJ/CLtkjXK5/2VAT+VGNXub0Ww7xulZt1CMgYjgYu/3pNnmj7K0B7LLyjg Y8N2NwZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sm91F-00000007oj7-0nA1; Thu, 05 Sep 2024 09:43:13 +0000 Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sm8zZ-00000007oLm-0nnd; Thu, 05 Sep 2024 09:41:29 +0000 Date: Thu, 5 Sep 2024 02:41:29 -0700 From: Luis Chamberlain To: Chunhui Li Cc: Matthias Brugger , AngeloGioacchino Del Regno , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com, kernel test robot , Xion Wang Subject: Re: [PATCH v2] module: abort module loading when sysfs setup suffer errors Message-ID: References: <20240904124108.20444-1-chunhui.li@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240904124108.20444-1-chunhui.li@mediatek.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 04, 2024 at 08:41:07PM +0800, Chunhui Li wrote: > When insmod a kernel module, if fails in add_notes_attrs or > add_sysfs_attrs such as memory allocation fail, mod_sysfs_setup > will still return success, but we can't access user interface > on android device. > > Patch for make mod_sysfs_setup can check the error of > add_notes_attrs and add_sysfs_attrs. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202409010016.3XIFSmRA-lkp@intel.com/ > Signed-off-by: Xion Wang > Signed-off-by: Chunhui Li Please use Fixes tag and resend. Luis