From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AD39CD5BD6 for ; Thu, 5 Sep 2024 16:25:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WGwxBe/iaaoqwox8h/HS48crgUAbtB3Lz0hvS0382cQ=; b=j9pG37kFLfSYFRnk64DraRiPKa TlmqmZGSnFksBTkZlnXq2Or9SrYOLo+tTgrDm2z0TdoXLWU7YIxdfUmZne7MhY8f+TScx8V0u6f26 REkeI7OeCUCWzdtmqW0h9nI9neXmi29DGgm3+5ZRl8Ycz6TiPyED0jfvg8CTqqnSSKu3+SjV2/zcu r2lp1kXoBDf4xNMcFtTjLuVO2lsL+uj8xveLnFOv7HoDrRxVOXMm/jGYdILmrMfkCN+bPCVkXCKns twoDPYZT/fJDWMANKH4VtcFLpMeqqTC6RZ0mSwQNZbqlERFH7YCa1CC8PezIxCEZdCelrcYkTFQbM DuvTBIfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smFI2-000000096PP-0WdR; Thu, 05 Sep 2024 16:24:58 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smFGD-000000095xj-1kb7 for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 16:23:06 +0000 Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-7c3d8f260easo625174a12.1 for ; Thu, 05 Sep 2024 09:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725553383; x=1726158183; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WGwxBe/iaaoqwox8h/HS48crgUAbtB3Lz0hvS0382cQ=; b=w/geTesEO0C/jZQT3nIIiIWvlgXnUm2lPSW3rXHxyiTjxpEpT+V0SINuAxmvcizK7R FdGgNBYjKnxrFR1Fuz2xBuKlm3tW7m36LYvcCQ7KiWSvnNxI1LE33gv4qYd++e/UKMge 0hYJIsc1U/l7ILDraCYFdFk+Rh6lVoSYDFQIIhkAUv0fg3TVQqIRYfBt4BfHa2X78DL6 H22M6QarzVNVcYuSpgF+GoR3CBObdQW1rH8UfkuGhCLBogYeKWSuenBQHIP/QXQUrkHc hnCg0TtUnLZUwkmJVomC7+WgW9qtYItEnanaZnWbtInNvVWKscEUqtTzzPvfa+jPVOgF s8zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725553383; x=1726158183; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WGwxBe/iaaoqwox8h/HS48crgUAbtB3Lz0hvS0382cQ=; b=GkYzHkQofjzFIJYxMjiaqlz12x5FrE8k1ViGmMcBWXcG8m8SU85pyHv7tUs3hC5sIM vUJTpJxmiBgn066pZD9Cwmz6ibzUxXa62PfncKAgxXrk8o7etTocOi6DObiBA34JkHHQ 9kx4CGuFpT5JLrO6Ga76bWoU3hobDEJIylBys4yd5UpNmUalKY4HT2uuOmFilfvnWplz +Cev+6LaHt9qVE/SFS5ygFwNXhFoHKba8Ij2x5ftnO+QBPrAOXZ6M474q797Efh3sD4s lI8RQRkgjVgXX3OQLekAmPId7c/6Ti3eXZ45hAn8zim4I8cDeO1O0GwgYc6MyF0LEqIu Z43A== X-Forwarded-Encrypted: i=1; AJvYcCUip2kO6sPn1YPGN5f9JTjWPCUxh0YRzEcPtFb6/BX7BgRFOvOm3frmibdtL1MegVMSoGyCXTGbHd8jqxKou4/5@lists.infradead.org X-Gm-Message-State: AOJu0YxHdQTFs57WRsPTTbf00hBadhiSAvv5yYiifW7DSOK/uY7eBgOF JjbO/Or/oKDmDI9bmhlXVMTACvnLlu8Vyld3B3E4aMjlvblzLSQV8HVJKvSSnfY= X-Google-Smtp-Source: AGHT+IEstKk+LEI8X3OaN9fTZu6CZPPKQppwGBYLvxBQ/FfkUBW23FDlSvzIk3BvLCy/OE4uzgavvQ== X-Received: by 2002:a05:6a20:e196:b0:1cc:dfd1:2453 with SMTP id adf61e73a8af0-1cce1016eebmr24968329637.30.1725553383443; Thu, 05 Sep 2024 09:23:03 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:3b5d:f081:c58f:f7e2]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7177859a369sm3510923b3a.148.2024.09.05.09.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 09:23:02 -0700 (PDT) Date: Thu, 5 Sep 2024 10:22:59 -0600 From: Mathieu Poirier To: Liu Jing Cc: andersson@kernel.org, paul@crapouillou.net, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, patrice.chotard@foss.st.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] remoteproc:remove redundant dev_err message Message-ID: References: <20240904185417.14357-1-liujing@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240904185417.14357-1-liujing@cmss.chinamobile.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_092305_472128_703504EA X-CRM114-Status: GOOD ( 17.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 05, 2024 at 02:54:17AM +0800, Liu Jing wrote: > devm_ioremap_resource already contains error message, so remove > the redundant dev_err message > > Signed-off-by: Liu Jing > > diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c > index 9041a0e07fb2..289d5ce9f7af 100644 > --- a/drivers/remoteproc/da8xx_remoteproc.c > +++ b/drivers/remoteproc/da8xx_remoteproc.c > @@ -214,8 +214,6 @@ static int da8xx_rproc_get_internal_memories(struct platform_device *pdev, > mem_names[i]); > drproc->mem[i].cpu_addr = devm_ioremap_resource(dev, res); > if (IS_ERR(drproc->mem[i].cpu_addr)) { > - dev_err(dev, "failed to parse and map %s memory\n", > - mem_names[i]); > return PTR_ERR(drproc->mem[i].cpu_addr); > } > drproc->mem[i].bus_addr = res->start; > diff --git a/drivers/remoteproc/ingenic_rproc.c b/drivers/remoteproc/ingenic_rproc.c > index 9902cce28692..b3ee5c47001d 100644 > --- a/drivers/remoteproc/ingenic_rproc.c > +++ b/drivers/remoteproc/ingenic_rproc.c > @@ -186,7 +186,6 @@ static int ingenic_rproc_probe(struct platform_device *pdev) > mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "aux"); > vpu->aux_base = devm_ioremap_resource(dev, mem); > if (IS_ERR(vpu->aux_base)) { > - dev_err(dev, "Failed to ioremap\n"); > return PTR_ERR(vpu->aux_base); > } > > @@ -197,7 +196,6 @@ static int ingenic_rproc_probe(struct platform_device *pdev) > vpu->mem_info[i].base = devm_ioremap_resource(dev, mem); > if (IS_ERR(vpu->mem_info[i].base)) { > ret = PTR_ERR(vpu->mem_info[i].base); > - dev_err(dev, "Failed to ioremap\n"); > return ret; > } > > diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c > index 7e57b90bcaf8..a31f94a290c9 100644 > --- a/drivers/remoteproc/keystone_remoteproc.c > +++ b/drivers/remoteproc/keystone_remoteproc.c > @@ -312,8 +312,6 @@ static int keystone_rproc_of_get_memories(struct platform_device *pdev, > mem_names[i]); > ksproc->mem[i].cpu_addr = devm_ioremap_resource(dev, res); > if (IS_ERR(ksproc->mem[i].cpu_addr)) { > - dev_err(dev, "failed to parse and map %s memory\n", > - mem_names[i]); > return PTR_ERR(ksproc->mem[i].cpu_addr); > } > ksproc->mem[i].bus_addr = res->start; > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index e744c07507ee..cb8ad16583c7 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -1126,7 +1126,6 @@ static struct mtk_scp *scp_rproc_init(struct platform_device *pdev, > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sram"); > scp->sram_base = devm_ioremap_resource(dev, res); > if (IS_ERR(scp->sram_base)) { > - dev_err(dev, "Failed to parse and map sram memory\n"); > return ERR_CAST(scp->sram_base); > } There is another instance in the Mediatek driver - please address. Thanks, Mathieu > > diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c > index 9ae2e831456d..07e707776cf9 100644 > --- a/drivers/remoteproc/omap_remoteproc.c > +++ b/drivers/remoteproc/omap_remoteproc.c > @@ -1201,8 +1201,6 @@ static int omap_rproc_of_get_internal_memories(struct platform_device *pdev, > } > oproc->mem[i].cpu_addr = devm_ioremap_resource(dev, res); > if (IS_ERR(oproc->mem[i].cpu_addr)) { > - dev_err(dev, "failed to parse and map %s memory\n", > - data->mems[i].name); > return PTR_ERR(oproc->mem[i].cpu_addr); > } > oproc->mem[i].bus_addr = res->start; > diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c > index 327f0c7ee3d6..85b95e025c17 100644 > --- a/drivers/remoteproc/pru_rproc.c > +++ b/drivers/remoteproc/pru_rproc.c > @@ -1047,8 +1047,6 @@ static int pru_rproc_probe(struct platform_device *pdev) > mem_names[i]); > pru->mem_regions[i].va = devm_ioremap_resource(dev, res); > if (IS_ERR(pru->mem_regions[i].va)) { > - dev_err(dev, "failed to parse and map memory resource %d %s\n", > - i, mem_names[i]); > ret = PTR_ERR(pru->mem_regions[i].va); > return ret; > } > diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c > index 572dcb0f055b..fe65ffa9a93f 100644 > --- a/drivers/remoteproc/qcom_q6v5_adsp.c > +++ b/drivers/remoteproc/qcom_q6v5_adsp.c > @@ -602,7 +602,6 @@ static int adsp_init_mmio(struct qcom_adsp *adsp, > } else { > adsp->lpass_efuse = devm_ioremap_resource(&pdev->dev, efuse_region); > if (IS_ERR(adsp->lpass_efuse)) { > - dev_err(adsp->dev, "failed to map efuse registers\n"); > return PTR_ERR(adsp->lpass_efuse); > } > } > diff --git a/drivers/remoteproc/st_slim_rproc.c b/drivers/remoteproc/st_slim_rproc.c > index d17719384c16..a6e50f51c794 100644 > --- a/drivers/remoteproc/st_slim_rproc.c > +++ b/drivers/remoteproc/st_slim_rproc.c > @@ -251,7 +251,6 @@ struct st_slim_rproc *st_slim_rproc_alloc(struct platform_device *pdev, > > slim_rproc->mem[i].cpu_addr = devm_ioremap_resource(dev, res); > if (IS_ERR(slim_rproc->mem[i].cpu_addr)) { > - dev_err(&pdev->dev, "devm_ioremap_resource failed\n"); > err = PTR_ERR(slim_rproc->mem[i].cpu_addr); > goto err; > } > @@ -262,7 +261,6 @@ struct st_slim_rproc *st_slim_rproc_alloc(struct platform_device *pdev, > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "slimcore"); > slim_rproc->slimcore = devm_ioremap_resource(dev, res); > if (IS_ERR(slim_rproc->slimcore)) { > - dev_err(&pdev->dev, "failed to ioremap slimcore IO\n"); > err = PTR_ERR(slim_rproc->slimcore); > goto err; > } > @@ -270,7 +268,6 @@ struct st_slim_rproc *st_slim_rproc_alloc(struct platform_device *pdev, > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "peripherals"); > slim_rproc->peri = devm_ioremap_resource(dev, res); > if (IS_ERR(slim_rproc->peri)) { > - dev_err(&pdev->dev, "failed to ioremap peripherals IO\n"); > err = PTR_ERR(slim_rproc->peri); > goto err; > } > diff --git a/drivers/remoteproc/wkup_m3_rproc.c b/drivers/remoteproc/wkup_m3_rproc.c > index 36a55f7ffa64..5648f450c018 100644 > --- a/drivers/remoteproc/wkup_m3_rproc.c > +++ b/drivers/remoteproc/wkup_m3_rproc.c > @@ -186,8 +186,6 @@ static int wkup_m3_rproc_probe(struct platform_device *pdev) > mem_names[i]); > wkupm3->mem[i].cpu_addr = devm_ioremap_resource(dev, res); > if (IS_ERR(wkupm3->mem[i].cpu_addr)) { > - dev_err(&pdev->dev, "devm_ioremap_resource failed for resource %d\n", > - i); > ret = PTR_ERR(wkupm3->mem[i].cpu_addr); > goto err_put_rproc; > } > -- > 2.33.0 > > >