From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BA93CD5BD7 for ; Thu, 5 Sep 2024 16:29:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CcsiftpokDsXgFOtzvtt4kZrZoB7ijoCX7mQyp3V3Eg=; b=qln4C2ZBs2TstDM3we9FJFWA9b efnI3ynjI+WiXReQT+MwXBmQL3WkIs8XsBuu1KWwJAFuhdcwj5Nx9jPSIx30qrmRhuX5JwVUeGhTZ jKmnXcOxq3LWbkQ+S+ZpElw8R90hXfULaJHXg7QIgZmmAYpcFPd4aQG4jaOlcpRJE5utPOOzSeuaN 8wQAU6yQu1UHvkl/x+tspIajVEbIJTJra6w9y9DZDPD5pP8YH7xlNx66Z17MPF1OLMjuOPBfeLrfr 92yIUkSGry8JuZzIzfHiwgIveCEztgvZ3YkkDAkM+A6PHAvidHho6Jsa1A3rxDA7SfKREzlsAXc0q 6+IAJjfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smFMi-000000097gI-3jST; Thu, 05 Sep 2024 16:29:48 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smFKK-000000096ur-1uGa for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 16:27:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1EFEC5C5542; Thu, 5 Sep 2024 16:27:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A050C4CEC3; Thu, 5 Sep 2024 16:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725553639; bh=deLukwfDk5TXdfNYzDpqI2Ea9Akv/6QBWcJKsEUcqbs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L1QvJ8nx/Tf5NJHNuRa9X6OyfxMtpvc0DCoebrrYQWZRIrk+ACkBOzB0BmCE9weAo sp1HXD+v4yHNM5hPTjx8LnlbseC8LaCAmRQ8860tF6jtKVd5AZEWcSOGYfW4l8MVEP TR07dTnlEBmoUvQF56aEEgI9HFLfAKpvxSs0EdjlJtZCOPAEM371s1LqbZosLM0Yue gzbEdr6ELyKLr11VyBNHbHvd9H4xiWCSpry1jZORRkv+LH0X0CZBAVLRusGmr3XNGt NiEkqVBDLPvxlp2fVufUqBj3bA7GU9vCcahXG22ij7+4huYwAXXc/J7AurdMZnzTKc cdo1IocbMiXEQ== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1smFKa-000000005KC-44Ar; Thu, 05 Sep 2024 18:27:37 +0200 Date: Thu, 5 Sep 2024 18:27:36 +0200 From: Johan Hovold To: Manivannan Sadhasivam Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jingoo Han , Chuanhua Lei , Marek Vasut , Yoshihiro Shimoda , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, abel.vesa@linaro.org, johan+linaro@kernel.org, Shashank Babu Chinta Venkata Subject: Re: [PATCH v6 3/4] PCI: qcom: Add equalization settings for 16.0 GT/s Message-ID: References: <20240904-pci-qcom-gen4-stability-v6-0-ec39f7ae3f62@linaro.org> <20240904-pci-qcom-gen4-stability-v6-3-ec39f7ae3f62@linaro.org> <20240905152742.4llkcjvvu3klmo6j@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240905152742.4llkcjvvu3klmo6j@thinkpad> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_092720_585875_604407C5 X-CRM114-Status: GOOD ( 19.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 05, 2024 at 08:57:42PM +0530, Manivannan Sadhasivam wrote: > On Wed, Sep 04, 2024 at 11:39:09AM +0200, Johan Hovold wrote: > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-common.h b/drivers/pci/controller/dwc/pcie-qcom-common.h > > > new file mode 100644 > > > index 000000000000..259e04b7bdf9 > > > --- /dev/null > > > +++ b/drivers/pci/controller/dwc/pcie-qcom-common.h > > > @@ -0,0 +1,8 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > +/* > > > + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved. > > > + */ > > > + > > > +#include "pcie-designware.h" > > > > You only need a forward declaration: > > > > struct dw_pcie; > > > > > + > > > +void qcom_pcie_common_set_16gt_eq_settings(struct dw_pcie *pci); > > > > Compile guard still missing. Sorry, I meant to say *include* guard here. > Perhaps we can just get rid of the Kconfig entry and build it by default for > both RC and EP drivers? I don't see a value in building it as a separate module. > And we may also move more common code in the future. It is already built by default for both drivers. I'm not sure what you're suggesting here. Johan