Re: [PATCH v4 2/3] usb: dwc3: imx8mp: add 2 software managed quirk properties for host mode

[Frank Li <Frank.li@nxp.com>]

On Thu, Sep 05, 2024 at 08:58:55PM +0000, Thinh Nguyen wrote:
> On Thu, Sep 05, 2024, Frank Li wrote:
> > Add 2 software manage quirk properties (xhci-missing-cas-quirk and
> > xhci-skip-phy-init-quirk) for xhci host.
> >
> > dwc3 driver have PHY management to cover both device and host mode, so add
> > xhci-skip-phy-init-quirk to skip PHY management from HCD core.
> >
> > Cold Attach Status (CAS) bit can't be set at i.MX8MP after resume from
> > suspend state. So set xhci-missing-cas-quirk.
> >
> > Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
>
> You're missing changes from v3 to v4
>
> > Change from v2 to v3
> > - rework commit message to descript why need set quirk.
> >
> > Change from v1 to v2
> > - use {0}
> > ---
> >  drivers/usb/dwc3/dwc3-imx8mp.c | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
> > index 8b88649b569fe..f62f6f960e501 100644
> > --- a/drivers/usb/dwc3/dwc3-imx8mp.c
> > +++ b/drivers/usb/dwc3/dwc3-imx8mp.c
> > @@ -145,6 +145,17 @@ static irqreturn_t dwc3_imx8mp_interrupt(int irq, void *_dwc3_imx)
> >  	return IRQ_HANDLED;
> >  }
> >
> > +static int dwc3_imx8mp_set_software_node(struct device *dev)
> > +{
> > +	struct property_entry props[3] = { 0 };
> > +	int prop_idx = 0;
> > +
> > +	props[prop_idx++] = PROPERTY_ENTRY_BOOL("xhci-missing-cas-quirk");
> > +	props[prop_idx++] = PROPERTY_ENTRY_BOOL("xhci-skip-phy-init-quirk");
> > +
> > +	return device_create_managed_software_node(dev, props, NULL);
> > +}
> > +
> >  static int dwc3_imx8mp_probe(struct platform_device *pdev)
> >  {
> >  	struct device		*dev = &pdev->dev;
> > @@ -207,6 +218,20 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
> >  	if (err < 0)
> >  		goto disable_rpm;
> >
> > +	dwc3_np = of_get_compatible_child(node, "snps,dwc3");
> > +	if (!dwc3_np) {
> > +		err = -ENODEV;
> > +		dev_err(dev, "failed to find dwc3 core child\n");
> > +		goto disable_rpm;
> > +	}
>
> This looks very different than the previous version. Did you review the
> change before rebase? We should already do of_get_compatible_child() a
> few lines above.

Sorry, mass up at rebase

Frank

>
> > +
> > +	err = dwc3_imx8mp_set_software_node(dev);
> > +	if (err) {
> > +		err = -ENODEV;
> > +		dev_err(dev, "failed to create software node\n");
> > +		goto disable_rpm;
> > +	}
> > +
> >  	err = of_platform_populate(node, NULL, NULL, dev);
> >  	if (err) {
> >  		dev_err(&pdev->dev, "failed to create dwc3 core\n");
> >
> > --
> > 2.34.1
> >
>
> Please remove the Acked-by for now.
>
> Thanks,
> Thinh