From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 664B1CE7AB9 for ; Fri, 6 Sep 2024 07:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F5NTZJdO9yPZYfPjsY4/0kurFyjigpK5f+8tAwuuEcw=; b=Ouyh5M/PgJir138IIo3xdwB0HI Y1l5x79S/Z9oSaE968nFStyAJ/BEd9G8y/jqneHVhlC1JyudP7qnQoLryFa5JQbvFTrqiureJhrQA GZ1cxF2cHjBeToh+Eb4hWwU5nCw4TaOTJ8ZYGk8iD4ka7Epm+BzcEYlkBWJ+Ap6pI3fNkIViEs3G/ 2ddvIyNdqY68tVCW8MEt2jH7gUMx+b4o9zWsyfjT9OfUBEjPaPF7UegSAJlWc4c2dP4xbaM2V/4PF S0wsV374CYK7AUl9Xr0uZ40qXqjnETzWYp12SQfjsk5ZN3BstVVDovwx6UEDflpiD2IwtFJM/zn0e vcsz05Fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smT1R-0000000B0RM-0gyY; Fri, 06 Sep 2024 07:04:45 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smSly-0000000AwOA-2ZgL for linux-arm-kernel@lists.infradead.org; Fri, 06 Sep 2024 06:48:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 1590FA405B8; Fri, 6 Sep 2024 06:48:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05D76C4CEC4; Fri, 6 Sep 2024 06:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725605325; bh=nGb8XxbR7FTLc/dIcFXasGyv/0FcYxflx3mwiODWW0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AOIczusQjztFmfGBOGL8PH/zIGGSMEuyk0eGnLJwDxbhKs3NtjKDUtyi7s9Dbw+GI Mb5BTIF50Nu8L7y6Lfzsd1RoqTP5zG5jS6J1I3Q/zyXZ3SrIIOsFt+HbBhvYFyARVB u518shT9HZk1jzZq0270PBjkrb2jnN/rikfE3sQEyf2l0girKC1NnyZN47AZauzdzG IRo2YzVITl1tCYYwMnOYPnepCcBo3sia1aVd6u4vwF24Ipcnus5ZR69FL6zBOSUDjg G0Pcv2+6Swf32EIlEldguVu3F5gtO2VrPfrs/rRZRn4giUfIA2IyY4Yc+p+4VB0gQk vHpQC9Tysfhow== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1smSmF-000000004Ee-3z23; Fri, 06 Sep 2024 08:49:04 +0200 Date: Fri, 6 Sep 2024 08:49:03 +0200 From: Johan Hovold To: Manivannan Sadhasivam Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jingoo Han , Chuanhua Lei , Marek Vasut , Yoshihiro Shimoda , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, abel.vesa@linaro.org, johan+linaro@kernel.org, Shashank Babu Chinta Venkata Subject: Re: [PATCH v6 3/4] PCI: qcom: Add equalization settings for 16.0 GT/s Message-ID: References: <20240904-pci-qcom-gen4-stability-v6-0-ec39f7ae3f62@linaro.org> <20240904-pci-qcom-gen4-stability-v6-3-ec39f7ae3f62@linaro.org> <20240905152742.4llkcjvvu3klmo6j@thinkpad> <20240905173437.hm3hegv5zolaj7gj@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240905173437.hm3hegv5zolaj7gj@thinkpad> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_234846_736697_420097F6 X-CRM114-Status: GOOD ( 18.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 05, 2024 at 11:04:37PM +0530, Manivannan Sadhasivam wrote: > On Thu, Sep 05, 2024 at 06:27:36PM +0200, Johan Hovold wrote: > > On Thu, Sep 05, 2024 at 08:57:42PM +0530, Manivannan Sadhasivam wrote: > > > Perhaps we can just get rid of the Kconfig entry and build it by default for > > > both RC and EP drivers? I don't see a value in building it as a separate module. > > > And we may also move more common code in the future. > > > > It is already built by default for both drivers. I'm not sure what > > you're suggesting here. > > Right now it is selected by both drivers using a Kconfig symbol. But I'm > thinking of building it by default as below: > > -obj-$(CONFIG_PCIE_QCOM) += pcie-qcom.o > -obj-$(CONFIG_PCIE_QCOM_EP) += pcie-qcom-ep.o > +obj-$(CONFIG_PCIE_QCOM) += pcie-qcom.o pcie-qcom-common.o > +obj-$(CONFIG_PCIE_QCOM_EP) += pcie-qcom-ep.o pcie-qcom-common.o > > A separate Kconfig symbol is not really needed here as this file contains common > code required by both the drivers. But the separate Kconfig symbol will only be enabled via either PCI driver's option (e.g. can't be enabled on its own). I'm also not sure if the above works if you build one driver as a module and the other into the kernel (yes, I still intend to resubmit my patch for making the rc driver modular). Johan