From: Jason Gunthorpe <jgg@ziepe.ca>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Chen Ni <nichen@iscas.ac.cn>,
will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
nicolinc@nvidia.com, mshavit@google.com, smostafa@google.com,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/arm-smmu-v3: Convert comma to semicolon
Date: Fri, 20 Sep 2024 09:50:05 -0300 [thread overview]
Message-ID: <Zu1vfRGrBTfEAivT@ziepe.ca> (raw)
In-Reply-To: <7a532573-9e59-41c6-bf57-f50cad502e57@linux.intel.com>
On Thu, Sep 19, 2024 at 12:45:18PM +0800, Baolu Lu wrote:
> On 9/19/24 11:53 AM, Chen Ni wrote:
> > Replace comma between expressions with semicolons.
> >
> > Using a ',' in place of a ';' can have unintended side effects.
> > Although that is not the case here, it is seems best to use ';'
> > unless ',' is intended.
> >
> > Found by inspection.
> > No functional change intended.
> > Compile tested only.
> >
> > Signed-off-by: Chen Ni<nichen@iscas.ac.cn>
> > ---
> > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> A typo in commit e3b1be2e73dbe ("iommu/arm-smmu-v3: Reorganize struct
> arm_smmu_ctx_desc_cfg").
>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Yes should have a fixes line, plese include and resend it..
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
prev parent reply other threads:[~2024-09-20 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 3:53 [PATCH] iommu/arm-smmu-v3: Convert comma to semicolon Chen Ni
2024-09-19 4:45 ` Baolu Lu
2024-09-20 12:50 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zu1vfRGrBTfEAivT@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mshavit@google.com \
--cc=nichen@iscas.ac.cn \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).