From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BA02EDE998 for ; Wed, 11 Sep 2024 07:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0XfX+ALkwi1VtU8FSEb/C/LAnUiNAcHpBzmPvvEwCQU=; b=qEBJcxtoM60JVgjRzsSBXH6+ch ftjwG/1eX2PpVE9RVJPhSAwwPM0M8+lQXIyx4WejG2OBHMfzqLArsg9+GI/0q5J0ECUHnbPe0rkP5 PH0lv8nDd9uL8JgT7s/wFdXINrr99sZhV9+VObXJawgQC0Q6tsiVV//z0ydXGhmSjO29aX1avX94p gq7M0G2eWtynMr9d/XqsZ7mB7hoAdX2/71zzqqNzvww2uDy4TFDc4wFjztzROVzLGdmk2ljul/TKs SGV8Ut75KitED6lPg+kD7IzyaJ4+qW08FvCUiWNt1rP4DWdPiuF052WO0c67Hd9mb7+WDFRC7z3rK XnJ2QkSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soHXS-00000008OCt-2SjH; Wed, 11 Sep 2024 07:13:18 +0000 Received: from mail-mw2nam04on20602.outbound.protection.outlook.com ([2a01:111:f403:240a::602] helo=NAM04-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soHWQ-00000008O3t-27Dt for linux-arm-kernel@lists.infradead.org; Wed, 11 Sep 2024 07:12:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I54JTIPqUbSSqa+EgkO5W+wnA43xCw+0EMeOVe41I8IaN/iesXIeuYgVRXpH6Ic9UTnSq62ejX1pRzihF0JUSREfUrMJE8te0tS5Ai224nEgSBdkJannWtD4xoi02TkSmpJwjcnNlJqNGQ1y8atRbNye99BCUhRCPHtQmul1U3SE/NFgMwdLQKbPGA8WkqyXqXzbv92V/GWNFJzn1W/pqnOHYttgyUb4Gvjjbq8ukS8YNAiZsDMllFIiFUcpG5/y/ibaj+LQSXhlaQXS9YP5K/2LUdoNeVrQR3TFNTNCtFnLlV/X4uQ1IvJ2lhqjZp/Tv17JKT6fCo/VGw+VfhWmzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0XfX+ALkwi1VtU8FSEb/C/LAnUiNAcHpBzmPvvEwCQU=; b=kSdPoVZSbjbwKAdEVhk93WZg/AhYzva6gDmJadDSXfXXSds5ZoLHvGjOJGcWAVa8ZnwDcnhUPcd3XYnfBCQ0Ey+llWQcldoG4J8YZKAFr7aclv67UTBMnXUEnkGxvtVt7xUAeBBYDVYNCsr/9iJOtbOseMuscTXm0U5r6usHMsldQkjx0qSiK0ttNUnbIxWOL73MBcA+AOOUie6YAniE4nwIzDmKRh/J9sZbTrFuRjgf0yHbXQCwUGmhR7zH6D7w8WrFB6U5FxvSo/c232ULHtLd8eharO/HFpyWeDYOYX+AaEPLwoYCHb+NVXi6V5G9TgfD0Rrvqqj6qfnw7h13Aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0XfX+ALkwi1VtU8FSEb/C/LAnUiNAcHpBzmPvvEwCQU=; b=fUTapzZChGhamDAGk2hiR2ByE3jxvd7Wej0ZQ5JnPq5DZOgvX13f9cICIml9oMqddgrgzjEW9uW9oADOkwxBkKPkgAokzlCFuZbvJJk7fXf0Mh6pCHtiP3bqnCY9cQRfWdALbNhmTM69h5h5tr1aPk6TFzP5XBlj3Pr48rNqKKMCbWkjUD+3hNR9FJmA/PxebU7X0YWcNBUGm4ClF4TO/aCGJ/l97rb4O2+3Rwt7A2AvijS8EF4m71bpCxngURAivgyfD+Py6bP8qpsd9U/WoNhMeWqevX05hhnjtoJa5Be77To1wVO5DpAMtBmkZWmRIz60iRl9kblGjD0E6dkQfA== Received: from BN0PR04CA0034.namprd04.prod.outlook.com (2603:10b6:408:e8::9) by MW3PR12MB4346.namprd12.prod.outlook.com (2603:10b6:303:58::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.24; Wed, 11 Sep 2024 07:12:09 +0000 Received: from BL6PEPF00020E5F.namprd04.prod.outlook.com (2603:10b6:408:e8:cafe::33) by BN0PR04CA0034.outlook.office365.com (2603:10b6:408:e8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.24 via Frontend Transport; Wed, 11 Sep 2024 07:12:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BL6PEPF00020E5F.mail.protection.outlook.com (10.167.249.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Wed, 11 Sep 2024 07:12:08 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 11 Sep 2024 00:11:56 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 11 Sep 2024 00:11:55 -0700 Received: from nvidia.com (10.127.8.9) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Wed, 11 Sep 2024 00:11:51 -0700 Date: Wed, 11 Sep 2024 00:11:48 -0700 From: Nicolin Chen To: "Tian, Kevin" CC: Jason Gunthorpe , "Williams, Dan J" , "will@kernel.org" , "joro@8bytes.org" , "suravee.suthikulpanit@amd.com" , "robin.murphy@arm.com" , "dwmw2@infradead.org" , "baolu.lu@linux.intel.com" , "shuah@kernel.org" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kselftest@vger.kernel.org" , "eric.auger@redhat.com" , "jean-philippe@linaro.org" , "mdf@kernel.org" , "mshavit@google.com" , "shameerali.kolothum.thodi@huawei.com" , "smostafa@google.com" , "Liu, Yi L" Subject: Re: [PATCH v2 06/19] iommufd/viommu: Add IOMMU_VIOMMU_SET/UNSET_VDEV_ID ioctl Message-ID: References: <6348cc7a72ce9f2ac0e9caf9737e70177a01eb74.1724776335.git.nicolinc@nvidia.com> <20240905160353.GP1358970@nvidia.com> <20240905174326.GW1358970@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E5F:EE_|MW3PR12MB4346:EE_ X-MS-Office365-Filtering-Correlation-Id: 0af46047-346e-4a2b-5452-08dcd2310c88 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?U/AHW5O4UhLe+yTFLwt9PdhLCd5M1PWz8HvRXvW/tpt8AuAg7AwkbgdZoeTM?= =?us-ascii?Q?VuniMithCGfxX8NVELzUsMYNA+f7SO7T15LGdC4XUQ8DIWRv6qS+ofBgVKBc?= =?us-ascii?Q?ds/0zV4ISEJZ4FTRulo+znB5gXfbhHk3dvxyWTOi9sIP1rtKExrVtaV6kzq2?= =?us-ascii?Q?yCjV1X/0AhLr1k0AGPzHF4USTxLBvXnwgQLbarAfm/ORXfryxZOufrsU/n9R?= =?us-ascii?Q?MmIn2gUtAB62lZXpNpAvSQYBk6/lCTrsQcMs1Nb4BZ/IUKlHJ7F14q9ZsZFH?= =?us-ascii?Q?qSZsen4nOfyuCxzpGZml/nKVXTSl6APDsnFn8RUWitAM7XCYcygQu5of/6Zs?= =?us-ascii?Q?M74AQUpCe9IvMYHe9nxtyHZYejgzJcb6d0xIGQ1iXxurB/jNGR2gWaelaMUN?= =?us-ascii?Q?WdPfNiw4kO/7YsDxk3r5KJUEaFQ5CtdqqCuoR01nu6FnQNzuPwyKT+V9GVfP?= =?us-ascii?Q?k7yf4Z2sC6kZfhBz5w6yeEXDxhRGCh6G0JXUw34AnrlOSY/zGSl+jM/9jhSa?= =?us-ascii?Q?p2aMOsJyOHDQ5D2vs8Ih7XgetrEcO/oDdSKoqUNBUYkyI7110ccR0qVe7Vj1?= =?us-ascii?Q?KmBTQ2EDlkn6WvCP18zCJouE1NiYw5nNcftmrUx6ewtYSXOU2i4e+sM3IewB?= =?us-ascii?Q?Qfbxi/ReimfmI4/3jKQDYBdX43x1N0khm0J9foHD+v9PMUaXLdD8Sa10JH3h?= =?us-ascii?Q?3vXFNnTKhfWOBgAQxl2AEvmEZhRn5zSzG2cYv+AkRCNvXy+Oe+tdiAbrhLVb?= =?us-ascii?Q?SrU/O4Tw993+jTiZCtZ/Mf97T+npTJeP6HI6aIqDB1qO9GXUztTMp2Pm8Ltx?= =?us-ascii?Q?p5Tj/IJSsZWitkHmwWyewSJdqu+uCO8WXYfmnPtzAAUIgD8uCuk8JfcBUayX?= =?us-ascii?Q?gbMcqedGgzZwJd98agaIM4B+i1b9b77MM0uac8ak61hcvovXlHRXo1SRyfDb?= =?us-ascii?Q?4DYW9eYvWuXmzYmxG+M+muEBId4sUkNW7RUMeNSrLwS3DZZIYLln6zVJDlTG?= =?us-ascii?Q?rQWAlzMvuCg+b/JP4jrS5NNV415edhJns6d7bUyjD8OJl6FZPjeUKAXbBSEu?= =?us-ascii?Q?eBgTkmD9ilKeB9oHSa4VKZ2JfjmuCbG5eh6zuMiKws5lL7ZgGKy3nPII0jRq?= =?us-ascii?Q?WPYutwxPtuCaSSIbYMyzV9DIYyDr+9uvPvG+q+tzIsaPHqvl3ZC3J5MDhuDo?= =?us-ascii?Q?7LWP+GSijhFBthwPryEuPX08h6TGGQgwqzYHW5jizM2l1WqKNGQJDmNxe3yh?= =?us-ascii?Q?lKmvLHVRuzIARUEoeMR5ED/UoIpbt+cZF24NjC1jnKqS9V2kDEteuB2PpyEM?= =?us-ascii?Q?ZEutrYEgdJwQiKcpf4Y7+edxY/hYB9A6By+sEWX39BRoxXHc45hznHvses1R?= =?us-ascii?Q?EDtwHwutDvGMCrBTO/HWVEiwh6o8/kMXt5q6cCI9FnzjIPN0UtP4BTbaADts?= =?us-ascii?Q?kFOSXsuUjkir5mkq5Tdd/n2SIQk58nKr?= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(7416014)(82310400026)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2024 07:12:08.3540 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0af46047-346e-4a2b-5452-08dcd2310c88 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E5F.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4346 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240911_001214_556984_54D9E81C X-CRM114-Status: GOOD ( 18.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 11, 2024 at 06:19:10AM +0000, Tian, Kevin wrote: > > From: Nicolin Chen > > Sent: Friday, September 6, 2024 4:15 AM > > > > On Thu, Sep 05, 2024 at 02:43:26PM -0300, Jason Gunthorpe wrote: > > > On Thu, Sep 05, 2024 at 10:37:45AM -0700, Nicolin Chen wrote: > > > > That being said, if we have a clear picture that in the long term > > > > we would extend it to hold more information, I think it could be > > > > a smart move. > > > > > > > > Perhaps virtual device can have its own "attach" to vIOMMU? Or > > > > would you still prefer attaching via proxy hwpt_nested? > > > > > > I was thinking just creating it against a vIOMMU is an effective > > > "attach" and the virtual device is permanently tied to the vIOMMU at > > > creation time. > > > > Ah, right! The create is per-viommu, so it's being attached. > > > > presumably we also need check compatibility between the idev > which the virtual device is created against and the stage-2 pgtable, > as a normal attach required? If that's required, it can be a part of "create virtual device", where idev and viommu (holding s2 hwpt) would be all available? Thanks Nicolin