From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25E38EE49BD for ; Wed, 11 Sep 2024 14:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wwdD5o3wuy2EghvZNGjYxJDC8Ui3uRnb8RRNEdrtkO0=; b=MncFWOwqdI5Xl2FJSZNhKjkOYk W49G7KUPU+w6NTj6EnyI7L2MNnerKJlbF7O352sRghtLGnAcNxBKItrP9E8xxWZHz/OqRGS/3GWs1 f5DH/Ig08anzoDAEXFfA2bo4APHjTA5Dl5fbb6pMjD4MhgnqKa5EhOluMt57HIa8DpRXrFszaqNht NHS9HQfEi/IGM//hzy9kinsibdIoc70l44/KbRu85GrY6DaUQmbuy/+25m9fvR5ICAn9BtcKN0kTU OwXLQzjy1tz/IZqEAgErT46DHlL9UGXK7rewspQNN+9ePzXgs5WlpFfrGQBAQF70ljZ6pT7GlVOkB g2TP2/Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soOa5-00000009zHj-26nf; Wed, 11 Sep 2024 14:44:29 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soONw-00000009v6P-2HEA for linux-arm-kernel@lists.infradead.org; Wed, 11 Sep 2024 14:31:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 456D25C034B; Wed, 11 Sep 2024 14:31:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFF7CC4CEC0; Wed, 11 Sep 2024 14:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726065115; bh=Mw1y4wLHHfBdKNO78tJQNdKZ1uzYVbptjk/O8odXsyg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O9x08tqxuk8uGTAQMURWwqXD937SsnBMX8ktRkA1fROJWNZL/r7jhq/v9RT9rRlsq Pn/6SfPE1RjkGJz1JHDY0fblpuqlN43baJmsZdoOqVsUtP4w2s6vhl3C/Y2Qxxbebd zWdBdykojgl7F4E1TjFtecuDOCyOwhfx5N61PsYvRARfG3Mu96Qub/iOG9LNAqEMBG mBIdg3TO4mZ3Qx15aR32q888vlDdJzsY9+fCB7bJTwHao0rHsmYl9ufuW5gAnTz/4O tH9A4Afrnc9PFFFtyNHKSMWyEypvwjbdV2Zp4W7M+IoVbgVhwsBuFLctmb3oCTDT1z +0EOsSWg7EUAg== Date: Wed, 11 Sep 2024 11:31:52 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Ravi Bangoria , Weilin Wang , Jing Zhang , Xu Yang , Sandipan Das , Benjamin Gray , Athira Jajeev , Howard Chu , Dominique Martinet , Yang Jihong , Colin Ian King , Veronika Molnarova , "Dr. David Alan Gilbert" , Oliver Upton , Changbin Du , Ze Gao , Andi Kleen , =?iso-8859-1?Q?Cl=E9ment?= Le Goffic , Sun Haiyong , Junhao He , Tiezhu Yang , Yicong Yang , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 05/15] perf pmu: Allow hardcoded terms to be applied to attributes Message-ID: References: <20240907050830.6752-1-irogers@google.com> <20240907050830.6752-6-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240907050830.6752-6-irogers@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240911_073156_678133_03596827 X-CRM114-Status: GOOD ( 11.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 06, 2024 at 10:08:20PM -0700, Ian Rogers wrote: > Hard coded terms like "config=10" are skipped by perf_pmu__config > assuming they were already applied to a perf_event_attr by parse > event's config_attr function. When doing a reverse number to name > lookup in perf_pmu__name_from_config, as the hardcoded terms aren't > applied the config value is incorrect leading to misses or false > matches. Fix this by adding a parameter to have perf_pmu__config apply > hardcoded terms too (not just in parse event's config_term_common). Stopped here: CC /tmp/build/perf-tools-next/util/stat.o util/pmu.c: In function ‘pmu_config_term’: util/pmu.c:1397:17: error: switch missing default case [-Werror=switch-default] 1397 | switch (term->type_term) { | ^~~~~~ CC /tmp/build/perf-tools-next/util/stat-shadow.o