From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A52DEE644D for ; Thu, 12 Sep 2024 06:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xZq+K8Kt7zRj4xdKHAsOyQvoufMDRQRe5GRtemEH+VA=; b=nZkCjRIS8CwXTC71KUi1FMFipq JnYQrXStP2FW12nXXpyikcm2D+03ZXEWLDq+BWNTJE+IvSvq8SFAyQ6HhRtZIfmxDumOeVrNy5nu3 99xJ/75jcNQlEhZP4snKKHxPkJ1Txgc+xqHo0nkn3+59L2NC6iui1GV7QCeIWAUpjAbBYBn5W+Khg HYaDwZ9gniQl6clPEEz5Iufmms2HzaX7OUVSyJAsEgYqIPyVRAQH9FzoiJQRHv0AqI/BLpGFtIKs0 d3kvzlxrLuQdevwodaMWymwFXkf1/NvM6G8cTnhmmI5lnFrxd7c+UFnTi4IIBIn239n1rNtrYzHrt WXpVgv6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sodHd-0000000C0y8-3l0e; Thu, 12 Sep 2024 06:26:26 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sodGa-0000000C0sa-02nb for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2024 06:25:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 54E495C57E2; Thu, 12 Sep 2024 06:25:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84C52C4CEC3; Thu, 12 Sep 2024 06:25:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726122318; bh=ziEohxVPR+6bo8E2GFrPEF7zYu5BBVJvQxhslGXTv9U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uUTly5UIMz6Dw0IHDbiFScj9NujeUIwbml9jqt1KLsHAG68Ugb4gWH4JXwIOV5nMF awiXUIbHHi4jprEHHd6HVDIVi5gVmLNyO5qoCysHtElQkA8H/Kti/kOG/RVm1aV9jL QZjwQ5DboOgbAEoKuAnBI6jwtYxJegrCTfVWxdDw3qW7QKwZKMK8N/JATey95rnP86 FitucbCq56b58b3TGFNcXbSYnSzYT2XhruiSgGSfZk4nOgLs5Ickg8IFkvYEarKKks 5Kkw0WmFMY5h8voaTpgSyIe3Dxlv1teEhSTX0f1DIszmtOmudjlk4rQuvPi+eAgmmG 6vWl/02ItogQA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1sodGq-0000000050K-42TT; Thu, 12 Sep 2024 08:25:37 +0200 Date: Thu, 12 Sep 2024 08:25:36 +0200 From: Johan Hovold To: manivannan.sadhasivam@linaro.org, Bjorn Helgaas Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jingoo Han , Chuanhua Lei , Marek Vasut , Yoshihiro Shimoda , Pratyush Anand , Thierry Reding , Jonathan Hunter , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, abel.vesa@linaro.org, johan+linaro@kernel.org, Shashank Babu Chinta Venkata , linux-tegra@vger.kernel.org, Frank Li Subject: Re: [PATCH v7 0/4] PCI: qcom: Add 16.0 GT/s equalization and margining settings Message-ID: References: <20240911-pci-qcom-gen4-stability-v7-0-743f5c1fd027@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240911-pci-qcom-gen4-stability-v7-0-743f5c1fd027@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240911_232520_210204_257C77A9 X-CRM114-Status: GOOD ( 12.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 11, 2024 at 08:56:25PM +0530, Manivannan Sadhasivam via B4 Relay wrote: > This series adds 16.0 GT/s specific equalization and RX lane margining settings > to the Qcom RC and EP drivers. This series is mandatory for the stable operation > of the PCIe link at 16.0 GT/s on the Qcom platforms. > Manivannan Sadhasivam (2): > PCI: dwc: Rename 'dw_pcie::link_gen' to 'dw_pcie::max_link_speed' > PCI: dwc: Always cache the maximum link speed value in dw_pcie::max_link_speed > > Shashank Babu Chinta Venkata (2): > PCI: qcom: Add equalization settings for 16.0 GT/s > PCI: qcom: Add RX lane margining settings for 16.0 GT/s Thanks for respinning, Mani. Bjorn, it would be great to have these in 6.12 since we're currently seeing lots of NVMe link errors on x1e80100 platforms (e.g. the Lenovo ThinkPad T14s) without them. These errors are also blocking the enabling of using the GIC ITS for interrupts since that will cause all these AER reports to spam the logs. So if you pick this one up, please consider also picking up: https://lore.kernel.org/lkml/20240711090250.20827-1-johan+linaro@kernel.org/ [ Note that the later added PCIe5 RC does not currently support ITS. ] Also note that users of these machines have been running with ITS support enabled for months now when using my x1e80100 wip branches, such as: https://github.com/jhovold/linux/tree/wip/x1e80100-6.11-rc7 So this is all quite well-tested by now. Johan