From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DF17EED609 for ; Thu, 12 Sep 2024 13:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XqdrXm4ZcBhMxArHEVqbh0H8bhyUvIJvDn8m8Oi5KOY=; b=FVkJGSZntoOHGBIE+Wwd6UQQxS XRnYnC7mV9Rnst64XAUjlhZlaA02aKgvZaet6NPA/YTXQ+F/BpJyNJCqObfAigPDBGjXRbVSaJOvi aULI215p6OZTqsPrwT9Xr61nSfbiFzRXN26U1CIXoVF7MuPYc8mLVAJSb1fZ7vMImDV9Hj1hbDSlu jsmB8SA61HSiveElU5Z1U1G33h4F7oD9fRuojBBSzNKCYL0q7WcpvikMCd74WzIFoTa72j+gDzSaA LpW0h04z7XPHzpAN4rpJjT1OsE4fAHhXBnGGmX2Ckk3YkefrpXC0chZ2gpAXoVsDDvBs+mRnUNVSc uKWF4cMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sokDl-0000000DGCk-0W8E; Thu, 12 Sep 2024 13:50:53 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sokCe-0000000DFvi-3Zln for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2024 13:49:46 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-6d4426ad833so24826817b3.2 for ; Thu, 12 Sep 2024 06:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1726148982; x=1726753782; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=XqdrXm4ZcBhMxArHEVqbh0H8bhyUvIJvDn8m8Oi5KOY=; b=in/y3j60C8V6vYhGbe68wT1jl28Yk238sPDcC5L6Ml6Mn+wg3OhXdxy9x6WxP8dg+K Tuv2sdAxndtEoEKdDEdkmq8evvhFyTgSD7ekHgJ/webWEk52zidSbdixBG7t1OYT+/OQ B4pa/hz0opTRZl0VxLtlddfl+iXp0fegyD5afmtXra9/3CZPkAcDP9vJSFkxDw7dVEYE BkD4kS6SbBcjonhwIEmZzZXAZu8ihfcYBFE31yf/RykJqhtVsEHPsSvZNCbHG7Imj6LX UX+Cxk7IFZFE9ht0pzKxtQmEsBcCx/Jja08Pdqh+cJ03XoNeyeJROChrCXK+rsGniOqH OkGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726148982; x=1726753782; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XqdrXm4ZcBhMxArHEVqbh0H8bhyUvIJvDn8m8Oi5KOY=; b=mwPHp/i2YGZSFMnlWvlB40MUReI0LPALpR2ixdJaj3+F6U99mGiDWZDeLDtfp0hLo7 /ECa7rkN2RMjMSzvbDVKQvxuapevoFTg4GJ5RDMFdKq8PygDq8hhLVe7ExcjMq0lHh4I C7Y6m8PbocJBDhzmsRVNnIm4FVSn9o9o421LZUuFXM1/uP8kO+OsP0a5Dn3I4t/X80PT 8hhHfbqSp3v8U1khm5fo1gkesrGt76C+2fIs14qbAeb/MwWJobW7aA37XEToApfTLWq1 grmhuDSr+3u8E9RWXRyt0RFzyduqw3eIW9Cc1sLZm2ijc9ujKsLbKPW3EZMsuXin5jxN MZCw== X-Forwarded-Encrypted: i=1; AJvYcCXfIjJNqorhXSos72zsJJhfUaEb2TZbJqoW9Xzg9uIRVzWpczMK7NLU6xsFl2EeE28GH1Ct6YlLJTLVA5Rlm/sl@lists.infradead.org X-Gm-Message-State: AOJu0Yyp/q2VFWhyUdnNvTHuGVUlD/7rn9fqAU9mY53BVpSzM5MoEJbK eZD0QQEIts+3IXZS9Lw96Tno4KTWb6/smn3D4ciO2rQlN8Ml0nsIhTEv9aTjH6kVPQHsHJoIEce TzQ== X-Google-Smtp-Source: AGHT+IERWDyZH0lw1THIMdF1ZNEMNfNEpIHjvdgU0tin44x4h90whZRVuXvE3+8fuo4JVbUfWmxTfJ+4tEs= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:50c:b0:e1d:a616:602 with SMTP id 3f1490d57ef6-e1da6160834mr2247276.7.1726148982380; Thu, 12 Sep 2024 06:49:42 -0700 (PDT) Date: Thu, 12 Sep 2024 06:49:40 -0700 In-Reply-To: <20240912-a3894135370bf3fe551ed018@orel> Mime-Version: 1.0 References: <20240911204158.2034295-1-seanjc@google.com> <20240911204158.2034295-3-seanjc@google.com> <20240912-a3894135370bf3fe551ed018@orel> Message-ID: Subject: Re: [PATCH v2 02/13] KVM: selftests: Return a value from vcpu_get_reg() instead of using an out-param From: Sean Christopherson To: Andrew Jones Cc: Marc Zyngier , Oliver Upton , Anup Patel , Paolo Bonzini , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, James Houghton Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240912_064944_897240_D3C5DBD2 X-CRM114-Status: GOOD ( 11.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 12, 2024, Andrew Jones wrote: > On Wed, Sep 11, 2024 at 01:41:47PM GMT, Sean Christopherson wrote: > > Return a uint64_t from vcpu_get_reg() instead of having the caller provide > > a pointer to storage, as none of the KVM_GET_ONE_REG usage in KVM selftests > > "none of the vcpu_get_reg() usage" > > (There is KVM_GET_ONE_REG usage accessing larger registers, but those are > done through __vcpu_get_reg(). See get-reg-list.c) Doh, right, which was also part of my reasoning for making the conversion (tests can use __vcpu_get_reg() if they need to get a larger register).