From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65907FA375E for ; Fri, 13 Sep 2024 16:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M4rJxA46YKftOjieYVN+HBOxnPrXbeWw//Bs8OxUrsg=; b=R3yCD+ej3NSLi0J045RTOJk2Ok auE8VOOM1ZBEdGtRGtF7Wysw0fWW3x3+0n9p46arlB3M80yBJ8uHE3RfFOiOdWwLik/lrs5d1/5Sm ZOvOTOIbDBwObuZCVW2oSIOyczIs6fKExQhEhn2DJoj6CR8row6hXtoQvzDcWK2Cqt797BFGgaTgH WdiePlbUiIi26dxejrC9icnS2RJYewIC2XK6jZv1VFTejgzF3+X65mVaWjn3xvK+36sYdSOJH4+LC tnwkHKBovizZQm2k9HoKEl7wz/sE28l3o9n/wlA6v4SaHY8rpaevuLHtKHcYWPf3FzCSR3RxxEsEU FrhaHoNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sp8mm-0000000GViP-1Ghx; Fri, 13 Sep 2024 16:04:40 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sp8lg-0000000GVZA-2iwn for linux-arm-kernel@lists.infradead.org; Fri, 13 Sep 2024 16:03:34 +0000 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-2057c6c57b5so14119635ad.1 for ; Fri, 13 Sep 2024 09:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726243412; x=1726848212; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=M4rJxA46YKftOjieYVN+HBOxnPrXbeWw//Bs8OxUrsg=; b=rvwXSJbHyggfthMuGDO5ztiw4QhsWsrXpY0fTtPi7dq5h5YoQu+iEIYMg6JtW+Qpfv c+xVIGpMyPSmvvTWNc0esXxL7USB6Ba5/flpBV7t8hdBNPGP8qrCNDf+ZAEuHXUhg/Jw VJal+vhO79uoHRIN6TvmiKmBEyVaopd2ocdtVNDxApiXA4JFBpllqc+t3Up/ufno5JQu 8Y434O+0JxOChj+54jFVwSZqkiQewZNhLusYSWCerujp1QvSoPtikBqd3FweRzwzUVzf Z9fLE1BIqREZ/hn+AY2G/69PjlB3TsR0xy5Keq/Omg/0QXK7uVrdOkfW5J3b4sARKRZ9 Cl8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726243412; x=1726848212; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M4rJxA46YKftOjieYVN+HBOxnPrXbeWw//Bs8OxUrsg=; b=bU0jo/CH0H9m5tWsIxF2SANYvcbWD13stCKN7jeWYfZjiQnsJdMZH7QBvTZhzCqzQ7 MTgscyy5SEZdhAS2f3qKZRRSqxIJPg97Uk4gQCci6D7dslwg4pvV65mp7F36Wre/sfbW jxDZ7gHAzB+qNuf/Zo5dc3At9IBnGz6avL8zZQV1xMBPZJyYtGMYlnri196NG1cEvYX4 EJFU0WRyAVCOoeK+z/aEl3cfJLcAK7OJ5/I+mZsZNUelNDf5eJjW2J7Ty1qtzdfQFkp5 yU96G3PHOqAHTVCC7oraRUjr7yQA2QgIf7/k/ej5p9uLyvoCGen/4SzpiG3HYUyDuY9S 8Q5Q== X-Forwarded-Encrypted: i=1; AJvYcCXbKluNmYsr/U5gLD9ApaHnbnpZb02xSHaqL7BV0EeX7F1qZmu7pVv/9a4ydDGIZFpTJlzHug7RB/7JUaet7lFb@lists.infradead.org X-Gm-Message-State: AOJu0YwoaVqVz14aXb3WFtiIUnA2Mibus8niGnYkXx7tSItPVVs8dr5h 7RTxzq0lvJC+cNrpjMMrdHwc/ulnf38caEgbWV3jZ2D26nUx/2eERuxP4t9BFe5Duof/pMoYJAe I X-Google-Smtp-Source: AGHT+IHHG7/l+/CqolXps5oc2mC7BwomTqGBul0o12SUT9T68nYYTvdvziy3yYLjWM7QytKM7qWGwA== X-Received: by 2002:a17:902:ecc4:b0:207:2093:99bc with SMTP id d9443c01a7336-2076e591765mr96910475ad.14.1726243411549; Fri, 13 Sep 2024 09:03:31 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:a6cd:be2b:8e1e:719e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2076af49293sm29809225ad.96.2024.09.13.09.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2024 09:03:31 -0700 (PDT) Date: Fri, 13 Sep 2024 10:03:27 -0600 From: Mathieu Poirier To: Arnaud Pouliquen Cc: Bjorn Andersson , Jens Wiklander , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org, devicetree@vger.kernel.org Subject: Re: [PATCH v9 7/7] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware Message-ID: References: <20240830095147.3538047-1-arnaud.pouliquen@foss.st.com> <20240830095147.3538047-8-arnaud.pouliquen@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240830095147.3538047-8-arnaud.pouliquen@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240913_090332_717473_FDE85828 X-CRM114-Status: GOOD ( 28.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2024 at 11:51:47AM +0200, Arnaud Pouliquen wrote: > The new TEE remoteproc driver is used to manage remote firmware in a > secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is > introduced to delegate the loading of the firmware to the trusted > execution context. In such cases, the firmware should be signed and > adhere to the image format defined by the TEE. > > Signed-off-by: Arnaud Pouliquen > --- > drivers/remoteproc/stm32_rproc.c | 63 ++++++++++++++++++++++++++++++-- > 1 file changed, 60 insertions(+), 3 deletions(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index 79c638936163..400a7a93b1c9 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -257,6 +258,19 @@ static int stm32_rproc_release(struct rproc *rproc) > return 0; > } > > +static int stm32_rproc_tee_stop(struct rproc *rproc) > +{ > + int err; > + > + stm32_rproc_request_shutdown(rproc); > + > + err = tee_rproc_stop(rproc); > + if (err) > + return err; > + > + return stm32_rproc_release(rproc); > +} > + > static int stm32_rproc_prepare(struct rproc *rproc) > { > struct device *dev = rproc->dev.parent; > @@ -693,8 +707,20 @@ static const struct rproc_ops st_rproc_ops = { > .get_boot_addr = rproc_elf_get_boot_addr, > }; > > +static const struct rproc_ops st_rproc_tee_ops = { > + .prepare = stm32_rproc_prepare, > + .start = tee_rproc_start, > + .stop = stm32_rproc_tee_stop, > + .kick = stm32_rproc_kick, > + .load = tee_rproc_load_fw, > + .parse_fw = tee_rproc_parse_fw, > + .find_loaded_rsc_table = tee_rproc_find_loaded_rsc_table, > + > +}; > + > static const struct of_device_id stm32_rproc_match[] = { > { .compatible = "st,stm32mp1-m4" }, > + { .compatible = "st,stm32mp1-m4-tee" }, > {}, > }; > MODULE_DEVICE_TABLE(of, stm32_rproc_match); > @@ -853,17 +879,42 @@ static int stm32_rproc_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct stm32_rproc *ddata; > struct device_node *np = dev->of_node; > + struct tee_rproc *trproc = NULL; > struct rproc *rproc; > unsigned int state; > + u32 proc_id; > int ret; > > ret = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(32)); > if (ret) > return ret; > > - rproc = devm_rproc_alloc(dev, np->name, &st_rproc_ops, NULL, sizeof(*ddata)); > - if (!rproc) > - return -ENOMEM; > + if (of_device_is_compatible(np, "st,stm32mp1-m4-tee")) { > + /* > + * Delegate the firmware management to the secure context. > + * The firmware loaded has to be signed. > + */ > + ret = of_property_read_u32(np, "st,proc-id", &proc_id); > + if (ret) { > + dev_err(dev, "failed to read st,rproc-id property\n"); > + return ret; > + } > + > + rproc = devm_rproc_alloc(dev, np->name, &st_rproc_tee_ops, NULL, sizeof(*ddata)); > + if (!rproc) > + return -ENOMEM; > + > + trproc = tee_rproc_register(dev, rproc, proc_id); > + if (IS_ERR(trproc)) { > + dev_err_probe(dev, PTR_ERR(trproc), > + "signed firmware not supported by TEE\n"); > + return PTR_ERR(trproc); > + } > + } else { > + rproc = devm_rproc_alloc(dev, np->name, &st_rproc_ops, NULL, sizeof(*ddata)); > + if (!rproc) > + return -ENOMEM; > + } > > ddata = rproc->priv; > > @@ -915,6 +966,9 @@ static int stm32_rproc_probe(struct platform_device *pdev) > dev_pm_clear_wake_irq(dev); > device_init_wakeup(dev, false); > } > + if (trproc) if (rproc->tee_interface) I am done reviewing this set. > + tee_rproc_unregister(trproc); > + > return ret; > } > > @@ -935,6 +989,9 @@ static void stm32_rproc_remove(struct platform_device *pdev) > dev_pm_clear_wake_irq(dev); > device_init_wakeup(dev, false); > } > + if (rproc->tee_interface) > + tee_rproc_unregister(rproc->tee_interface); > + > } > > static int stm32_rproc_suspend(struct device *dev) > -- > 2.25.1 >