From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F744CE8D6E for ; Thu, 19 Sep 2024 10:19:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I1mckTS2FV38bbZ879rd+/BowKPTlDKekDspILq4S7U=; b=ymmOnGEV3lhChiEUTTgYIsMk8E 8aMf53X8BATHUYEk4nyNp5iCG3F/GW/9WjAbp1Vkd0FqsDpzl41tOj71IvlEkHaqQiiP0iR8NtZ6V JjnFB/mfJVGUrbnSHM7cDiXImHGnwkyA3m4CkJz6l7GJnJyI4Y/kW9VC9fsE5jBsTAJLvqLj1NERD gxomzON8x/p+9aFvwLKYlaoizeoyfbF9dIvTP5npa0Z9NditimD1X1Abj5WgvIuIFZ9o8/GA4ETrK tYoFxq0xwCuox5QY6+nCmHe0xhgf++OI3aODM9mtF2NpLRXd69xGcRMPmzmZevz4FwjgE25ZgIJde 8Cc+LHvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1srEFX-0000000A1h2-1m7L; Thu, 19 Sep 2024 10:18:59 +0000 Received: from out-170.mta0.migadu.com ([2001:41d0:1004:224b::aa]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1srEEQ-0000000A1YE-1hv6 for linux-arm-kernel@lists.infradead.org; Thu, 19 Sep 2024 10:17:52 +0000 Date: Thu, 19 Sep 2024 03:17:38 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1726741064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I1mckTS2FV38bbZ879rd+/BowKPTlDKekDspILq4S7U=; b=D6x6BKhtU1AsDKi/4KqvcONlUrTfddheLB6mjS/liWOZikXBBbl320OPz8mgGIKM4WllXD +wY9aYHdLlkmHh4egDXFCzDa+mmurZ3C2W/5Yn9b7oeoiOBTG25PlxVj4C73Kx3idnOFp+ Vxq68Xs1nMkSJWGZkP3uhgfHcFJ6DPg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Colton Lewis Cc: kvm@vger.kernel.org, Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Will Deacon , Russell King , Catalin Marinas , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v3 0/5] Correct perf sampling with Guest VMs Message-ID: References: <20240912205133.4171576-1-coltonlewis@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240912205133.4171576-1-coltonlewis@google.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240919_031750_673680_F2D7ED0E X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 12, 2024 at 08:51:28PM +0000, Colton Lewis wrote: > v3: > * Clarify final commit message further > * Remove an unused variable in perf_arch_misc_flags() > > v2: > https://lore.kernel.org/kvm/20240911222433.3415301-1-coltonlewis@google.com/ > > v1: > https://lore.kernel.org/kvm/20240904204133.1442132-1-coltonlewis@google.com/ > > This series cleans up perf recording around guest events and improves > the accuracy of the resulting perf reports. Please fix the intermediate build issue, and also test that each patch in the series compiles. With that corrected, for the series: Reviewed-by: Oliver Upton A nice follow-up on the arm64 side would be to further constrain kvm_arch_pmi_in_guest() to return true iff we exited the guest due to an IRQ. -- Thanks, Oliver