Re: (subset) [PATCH 0/4] spi: airoha: Fix errors reported by mtd_test kernel modules

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]

> On Thu, Sep 19, 2024 at 11:16:22AM +0200, Lorenzo Bianconi wrote:
> > > On Thu, Sep 19, 2024 at 10:59:20AM +0200, Lorenzo Bianconi wrote:
> 
> > > Your changelog doesn't actually describe what might be fixed there and
> > > it's not obvious from the change itself.
> 
> > sorry to be no clear on it. Patches 1/4, 2/4 and 3/4 are fixing outstanding
> > issues while patch 4/4 is an optimization and we can apply it later on, up to
> > you.
> 
> Yes, what I'm saying is that I can't tell what those issues might be for
> patch 3.  The changelog for the patch should describe what it's supposed
> to fix.

ack. The issue is the 'read cache' logic present in the vendor sdk codebase I
added in the upstream driver is buggy and it is introducing errors reported
by mtd_oobtest kernel test module. Since we do not get any read/write speed
improvement using the cache, in order to fix the mtd_oobtest test, I decided
to get rid of the 'read cache' since it is not useful. Now the driver is passing
all the tests available in mtd_test suite.
Do you want me to repost just this patch updating the commit log?

Regards,
Lorenzo

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]