From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D451CE8D78 for ; Thu, 19 Sep 2024 11:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bqm3Bhnv/ZWtJn1Pz8eHbnJbkJbx/qO2x+tNNePpxmo=; b=LxHe5g8amOH2N3BObFr2Eyi99O vrDS6LONqWbhKZN9WDI9mw+qQj9Gi0dAgzneJkHWtSewoQxVZhJSJW67+LrAPP5+htXAX2Uy16yeu wh5T27TuulQGDHGnqNPjjewVK7n/MCoMDuqRWIulCBqsQr1WXi/9a/WSCpDP0GUpWLAQNKbNnavAA PVwVabWQ0ZJha9J50jc30BpcWbKoft56ZH5t1zSgakBhc5s/PEeucL8VDMY+P7DCCF/vDJJUScqub ZSqq1QyAbLlQsDBQ5EbHl8/gI265i7dp0Ta/5EmXGc69knUgAi9vkj6PESNmND1XboqtRg51ebI0f EC84KiZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1srFBy-0000000A8bC-2cL5; Thu, 19 Sep 2024 11:19:22 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1srFAr-0000000A8UA-2U0Y for linux-arm-kernel@lists.infradead.org; Thu, 19 Sep 2024 11:18:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 252D45C062D; Thu, 19 Sep 2024 11:18:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 189F9C4CEC6; Thu, 19 Sep 2024 11:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726744691; bh=wh+1OaEabOJgjsBjLpcs+fVaPjWSLZAsZW1bfWkeSwk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hhRAE9isvxLGrvxvMzhHj8qcslajJshaWfpcCokvRfmMkcX1GTd6X1X+S/osh4cop a06d9uDxie2/wOVAEBLecF3d1W5b90/p5Wa6LoG5pCkqdielPCO3tnxdNkZypnG4iA cTlSgrRiEECyGMnMilAfpwdv3EWsx14qJ0bj+SZBJe/FsY9elQ6YxuIYw+VoiBaI4p nSpML2L+T5/pnQA6C9Rpm6RiCeF3ZJI/P654X0ZS4HncZxDJXL5YemjBWHgAATO0fI 3sOc9qMhffdyjR/tD8nDhvLhrd6pq1BE6gY+b5qan0x7Ru2n+7O0bFkBvkPOg/6jf+ SP6rynKNcrX/Q== Date: Thu, 19 Sep 2024 13:18:09 +0200 From: Lorenzo Bianconi To: Mark Brown Cc: Ray Liu , AngeloGioacchino Del Regno , Andy Shevchenko , Christian Marangi , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, upstream@airoha.com Subject: Re: (subset) [PATCH 0/4] spi: airoha: Fix errors reported by mtd_test kernel modules Message-ID: References: <20240913-airoha-spi-fixes-v1-0-de2e74ed4664@kernel.org> <172673459965.1807523.13398242599346549903.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ujfEkRUZ69plHeL0" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240919_041813_717810_6EED00A3 X-CRM114-Status: GOOD ( 18.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --ujfEkRUZ69plHeL0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Thu, Sep 19, 2024 at 11:16:22AM +0200, Lorenzo Bianconi wrote: > > > On Thu, Sep 19, 2024 at 10:59:20AM +0200, Lorenzo Bianconi wrote: >=20 > > > Your changelog doesn't actually describe what might be fixed there and > > > it's not obvious from the change itself. >=20 > > sorry to be no clear on it. Patches 1/4, 2/4 and 3/4 are fixing outstan= ding > > issues while patch 4/4 is an optimization and we can apply it later on,= up to > > you. >=20 > Yes, what I'm saying is that I can't tell what those issues might be for > patch 3. The changelog for the patch should describe what it's supposed > to fix. ack. The issue is the 'read cache' logic present in the vendor sdk codebase= I added in the upstream driver is buggy and it is introducing errors reported by mtd_oobtest kernel test module. Since we do not get any read/write speed improvement using the cache, in order to fix the mtd_oobtest test, I decided to get rid of the 'read cache' since it is not useful. Now the driver is pa= ssing all the tests available in mtd_test suite. Do you want me to repost just this patch updating the commit log? Regards, Lorenzo --ujfEkRUZ69plHeL0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZuwIcAAKCRA6cBh0uS2t rK8FAP0QMmZOoqyY6tgfjZ4aqtOQoumzI7pmH7l3Jg6F92kzJwD/cUJCuNxw/rj9 6L38kN0UThfAs6cROV351wXJcpn7/g8= =IwRv -----END PGP SIGNATURE----- --ujfEkRUZ69plHeL0--