From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CE10CE8D7D for ; Thu, 19 Sep 2024 12:38:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n8T+bdL0uoZ93DAK07FZlZlpIEzUQPmpUVsCs9Rf7wE=; b=hAsYiJJRbf1ExZubrdipt1+d0B kDJyAhcriYqY0P1suaJNIcz/EygXutpplqp7OyYsI5Bt1MOplT+rkfl9L1JPLG8a932/H6FJq3X/o Ph16xxPebu8V5VoaY1FwIwC30EQJN05Gd4jgIIxAJdUkHHhWDUoV2ZhF0LKMaeqDNWhT6fnYIer+C hVukcFQWlKiba77oem3WMNkziCrpTY9qarK2boeNu5u0Zlgt2g71RzXo9pzJhJp8J54v/H4QtYqFo /7rXfhSSS+INOKLjPjty/pv4ZwmwTxpwhNjDAStfKXF895L74jhy+e2+wI0kbyqM++lu0ij3hHDud 9L7eOM5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1srGPv-0000000AFvL-3WzC; Thu, 19 Sep 2024 12:37:51 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1srGOo-0000000AFlq-2Qgw for linux-arm-kernel@lists.infradead.org; Thu, 19 Sep 2024 12:36:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 573395C5847; Thu, 19 Sep 2024 12:36:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73944C4CEC6; Thu, 19 Sep 2024 12:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726749401; bh=drz/M8kFXL9ZPR3Lg1MLh8C8+oHJVn3wdZayUSYreD4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tburf6tUAfmnJ28OZOqX6X/obau6SLTt9f0JA0YH8Qfq/YnaLfR1lgt2PAAakUVlf YAeS84Wcs7kE81PA+8fnqG45qsZmQMqo5/tLNLVOM6+1gBqTGrKDcb/h4ZbRnwSXkP 5RVLY3zQC4atwqAzex1EbzBYH5mvy4aDODXk9yK9TSOr9UQJLH1ag3EjVDqk6CbXTl el7SKhNMVPKBAi3TbF8IgwZcxYaFUxPsIcd4Z3HKsm2a9kGJWbUAYgy6VJKDnsFbBH UiHd/nxZLuxT8GdNo/3ofNZVo7d6d2GeRENIitWTkPnCqTjPEyy0ZBv++HP/BDWTUj Ch01IIrxGV5Zg== Date: Thu, 19 Sep 2024 14:36:39 +0200 From: Lorenzo Bianconi To: Mark Brown Cc: Ray Liu , AngeloGioacchino Del Regno , Andy Shevchenko , Christian Marangi , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, upstream@airoha.com Subject: Re: (subset) [PATCH 0/4] spi: airoha: Fix errors reported by mtd_test kernel modules Message-ID: References: <20240913-airoha-spi-fixes-v1-0-de2e74ed4664@kernel.org> <172673459965.1807523.13398242599346549903.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bibigXL21qbwIJJQ" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240919_053642_683365_F1C1C864 X-CRM114-Status: GOOD ( 16.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --bibigXL21qbwIJJQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sep 19, Mark Brown wrote: > On Thu, Sep 19, 2024 at 01:18:09PM +0200, Lorenzo Bianconi wrote: >=20 > > ack. The issue is the 'read cache' logic present in the vendor sdk code= base I > > added in the upstream driver is buggy and it is introducing errors repo= rted > > by mtd_oobtest kernel test module. Since we do not get any read/write s= peed > > improvement using the cache, in order to fix the mtd_oobtest test, I de= cided > > to get rid of the 'read cache' since it is not useful. Now the driver i= s passing > > all the tests available in mtd_test suite. > > Do you want me to repost just this patch updating the commit log? >=20 > It'd be a bit easier to resend this and patch 4 but yes. Please mention > exactly what the errors that mtd_oobtest finds are and ideally why > removing the cache fixes them in the changelog. ack, I will do. Regards, Lorenzo --bibigXL21qbwIJJQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZuwa1wAKCRA6cBh0uS2t rMiAAQCcaDkqOok/UgF8VirU5vAoayYclJkI+dQIHkQkSVYymQEAzpzxT2Dqq+Ni sBbgJI49EQ0VllOkLJB6O90TXeLtzAo= =7RpA -----END PGP SIGNATURE----- --bibigXL21qbwIJJQ--