From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A41BCF31B0 for ; Wed, 2 Oct 2024 10:35:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Osj0VDJnFYzbJpHWU4w6qA8OcYDWp8NZiL/JCinYSyY=; b=MeCBpuV0XKAlr5U5xSvLXh7Ixz cIb1qOSH6NGMd2cafExLPeAvBCPH9eb8YdUkGK1D53rJ/G/kq86FRb1Rrv2kPAjQvrx26fGpfaWZK Uw/k5uf+l22wZQflcbzA/AYj89A4hxEl7I2r2x7ujjqgugUGjih1YDfMzj0aDSmGYpav2sZjd8dlq W3wQolhnf0SflVs7YdNrVLi42/9o4WgAltls6Qul47HMv0rm4sBlN9D4ZaVT+hw4qqAvEmusPqHmY lc80ymfYHUsiQgRoVYmTXvyOtbObq0A7rMWanSXv8mj4RvkUod44IricFp1IXXMiWoLwcfkE+XTM/ QceuGlsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svwhL-00000005Vno-0nFS; Wed, 02 Oct 2024 10:35:11 +0000 Received: from layka.disroot.org ([178.21.23.139]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svwdc-00000005Uti-37dR; Wed, 02 Oct 2024 10:31:22 +0000 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A9DBF23D7E; Wed, 2 Oct 2024 12:31:17 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id TK-AFE1673VL; Wed, 2 Oct 2024 12:31:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1727865077; bh=rOELVSnjZgJ2jLuwmK36lE3rBUWz5L66VNmRiHrxopM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=mgaU6W4Saco/58d5mR20FQEGu4JFYvXxbwh7CBQ0+ocwf0qf1Xx6lHX0Fvwgegt+U uDpqd3DW8qCB4ibs9WeVtiV/kv0di7IMYsP8Kic5XrbfAZq/IqvADZMiNgBtMbgyA+ cNsjgV3vSvpJUaGmAWVFYx0qMf5xbchdQVVTOgSW1HUxI09sQXrcOrIa3J+HZEVT/n MF1U6wXneVrB+4KrWf418YRTmDmZ1UYip+uIDyQUVDtDyMTjKVSzQPsk4q8QcE319A PriXAC11/uujFZh22CzfPIWwjhmaKmn+N1+2WVmFR9BoRwOjkw4Rj/1v6ahIca9SC6 zKhOwZwZnQgmg== Date: Wed, 2 Oct 2024 10:30:55 +0000 From: Yao Zi To: Heiko =?iso-8859-1?Q?St=FCbner?= , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Celeste Liu Subject: Re: [PATCH 5/8] clk: rockchip: Add clock type GATE_NO_SET_RATE Message-ID: References: <20241001042401.31903-2-ziyao@disroot.org> <20241001042401.31903-7-ziyao@disroot.org> <9365795.CDJkKcVGEf@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9365795.CDJkKcVGEf@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241002_033120_946766_5D35922A X-CRM114-Status: GOOD ( 14.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 02, 2024 at 10:08:36AM +0200, Heiko Stübner wrote: > Hi, > > Am Dienstag, 1. Oktober 2024, 06:23:59 CEST schrieb Yao Zi: > > This clock type is similar to GATE, but doesn't allow rate setting, > > which presents on RK3528 platform. > > this definitly needs more explanation in the commit message. > > I.e. regular individual gates always set the CLK_SET_RATE_PARENT flag > because of course the gates themselfs cannot influence the rate. > > > But in general, I'm also not convinced yet. Yes if some driver tries to > change the rate on those, it may affect the parent rate, but that is also > true for the other individual gates. > > So what makes aclk_emmc (as GATE_NO_SET_RATE) more special than > "hclk_emmc" (as regular GATE). [Same for the other clocks of course] . > > > So this either needs more explanation, or for the sake of simplicity > use regular GATE for now for those and we revisit when it becomes > necessary. I agree that more digging is needed for GATE_NO_SET_RATE. If no obvious reason for adding a clock type could be found, will convert these clocks into general GATEs and give it a try. Cheers, Yao Zi