From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A043CF319E for ; Wed, 2 Oct 2024 19:24:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vIgBwkCCu5/eQFjk2DAVFSGMG+OvY7nzKKDG8GFzEK4=; b=ksIoghrRlajoxqnItJlVAu+QHH h/o/ZUCARX+ADMtzqv5Ak+B1kPKroPRw1LL6CGJruLpSVt/cwrypiS5RCg6oiwfb0SfdiRxxxtHE5 H9TvxtvGffbVuUBAvDWjM5AwDaYxUHR2FGA2CvcPcy91EbS/SuZUElig333XLTni0YTcrgM1PE1n1 kAt0MskQUvm/VEP96JzbpChu4B7LHGwyu56xuSDICxaf3Cw8f3a7EBL51H6ze/hylJTyQ3BVlodH8 QMQU5smh+J2zFJH92Njw3F6Q9W2izA4U2Hcuu+/5F8YlhnLqatBjxbmGnnNDa5LbiErIWsmPGnNG4 nguIKBGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sw4xh-00000007IMf-2ISs; Wed, 02 Oct 2024 19:24:37 +0000 Received: from mail-mw2nam10on20611.outbound.protection.outlook.com ([2a01:111:f403:2412::611] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sw4wR-00000007IFw-2wF1 for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2024 19:23:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wdPshZEtUSUgKvxdRIUvO2nSRKEnB+ydqbkptcLd7rtwowUJhhSHLb6KTnbotML14Tad8fKT66TQfuZnn/UEROIjdxSUZRXSPengSzPILCQ5nxjRNGogiSNk9dI2+lbjAWimP6tD1v+zJW0dpSmWo/DThH2gS5lK2V43sT0oId9rYS8agpOnkCpDh7028aEef030MjERArKMgSb7q96yGdUpeu/0W4aKEEHDrCpBnmDC1GHrtwlp4OlwVqg3lgNXEPT+zivakg47WGfI60ko+Eewkm44hRqUFwBrDFV3GvfgDHCQyQPEb0sJbXVYPgKQPIrKsmhG0GuoOpdVrO3ZZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vIgBwkCCu5/eQFjk2DAVFSGMG+OvY7nzKKDG8GFzEK4=; b=L6duPfAM3C02y2EnJJq2R/70sSbxQFXtdAtgkX6wi6WfZoWtTLVVt0djPgiple6hWOt+v9fnJSdp3EZFJO/9IG2O6aOFleIiu+PSfYKG4aT5rfG07XdthLqqu60XRQGN6Q7LSPDIsxB9SD3kjX71ASa8btKnKHTu6aA1M28RZ5WKjQoVA3nX2TEIBRT4kVbHV8u2BETQYUVVNbG0Iq3imYWE7EU2GSuGfRH1tYlsZmUO8kW6g8GL+Da9iUTAQa0AzBzWcfh/7WfCTtATsRDjO66vmtsPr/DHLnodC8vG+M9uYGBtRfSmhgggScmUO9kyNF9FrnK43MuF6+n1JHluQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=os.amperecomputing.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vIgBwkCCu5/eQFjk2DAVFSGMG+OvY7nzKKDG8GFzEK4=; b=DRx5hpHgGG1parkiaXNPd1joKHva6EbtPxfgLpRErcF6t3Ob7SNuvMzDv4vqtjnDEFTrDbfl9VODQ7+CZFjhiZ6JPIa7ps/4smMg4QJEoH9yDhD/zpovFOJvGNXwvrnSFutJ7DHpuurtmdbfjy3v/PpSKWpD4icxqTnLWvmR9vFWD8PXaSeWSrKP7mXniLmF13YZgolIkpI1YUDbxEt2GgZoaG1d5W4MILP/WIWzDv5VYCWVk21Vqlay7q2KWtSWilBdHGEynmufzjgpt/guI2TBZuyC6BmAb3KDc/S+80Tm7F5AJiTB1yA1JKOmM/a62voLR6QtMFdmO/eJJ4cPqw== Received: from SJ0PR13CA0143.namprd13.prod.outlook.com (2603:10b6:a03:2c6::28) by DS0PR12MB9346.namprd12.prod.outlook.com (2603:10b6:8:1be::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.16; Wed, 2 Oct 2024 19:23:07 +0000 Received: from MWH0EPF000971E2.namprd02.prod.outlook.com (2603:10b6:a03:2c6:cafe::34) by SJ0PR13CA0143.outlook.office365.com (2603:10b6:a03:2c6::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.9 via Frontend Transport; Wed, 2 Oct 2024 19:23:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by MWH0EPF000971E2.mail.protection.outlook.com (10.167.243.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.11 via Frontend Transport; Wed, 2 Oct 2024 19:23:07 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 2 Oct 2024 12:22:50 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 2 Oct 2024 12:22:50 -0700 Received: from Asurada-Nvidia (10.127.8.13) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Wed, 2 Oct 2024 12:22:49 -0700 Date: Wed, 2 Oct 2024 12:22:48 -0700 From: Nicolin Chen To: Yang Shi CC: , , , , , Subject: Re: [v2 PATCH] iommu/arm-smmu-v3: Fix L1 stream table index calculation for 32-bit sid size Message-ID: References: <20241002175514.1165299-1-yang@os.amperecomputing.com> <1c9767e1-4d05-4650-bc14-65a18fc63cc2@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1c9767e1-4d05-4650-bc14-65a18fc63cc2@os.amperecomputing.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000971E2:EE_|DS0PR12MB9346:EE_ X-MS-Office365-Filtering-Correlation-Id: 051fb762-1a19-4d34-63bc-08dce317a519 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FfOfHlWmu48j7KQo3zf1CEdjylmAzR1dU+0xbeuofhCVcrK0LJ0asDaw+ZXI?= =?us-ascii?Q?7yXhex3T7qJ39vYs9QYpjVc/4h2PHGMtedAux4DU+9Py5u/GR37PV0C4dIko?= =?us-ascii?Q?rpuqPwCS94WPzeGfIwyBiugWJ4aXR4+4w2GpgOmbqm+jI19nSE/foOE4O2x6?= =?us-ascii?Q?uiVMDu7g/7+P4JKqmTVTso4PJIFiazCIJIqF3jR0xsoTlgCEC88QS6EZAkSC?= =?us-ascii?Q?9K6Xn68z2JomBPkZacdW96eYrkX2794kn+CJVBv9SfBiht5cnimh5iXLIdKh?= =?us-ascii?Q?aPP5jOCMRuzWuP3+GaBIMl2qU7Ot+0iQ6ibHypaGDcMOzijvr025FGNI6ItZ?= =?us-ascii?Q?EUqjPyrZcVoFCgul7fryGOF7ZAGgWAJiIeesG42FzCAbveAn9rJoUhZcPMRD?= =?us-ascii?Q?Hs31FesDlJ8MMBgwSO7vr5DTOWTrpMeBDECmPI7vHhyw8Van9o0KiXR3Yfs1?= =?us-ascii?Q?AX2cTkagaPcEPsX44HHLhZepsO2Pno26yrXdnIbs0uossS3A+d22r2QzGFCx?= =?us-ascii?Q?Eqg26co8SLqVGJ0eUEAumXeVm/H4fo9UzNExpS15vvF+iByAXYrddDNJODNs?= =?us-ascii?Q?Snc5p4dJX/Rqjj3LItHooQGwvpxQE8qn/Yq6BCwPzMM+RYNiI87IsktSYcUB?= =?us-ascii?Q?JhapkqBlPAeM4jbtlRAfnp7pkOWT0C+DKjhXtSLff/kc1tqZWWTSod4qeXm7?= =?us-ascii?Q?KbhPO/YBnXBpcH8mDpn8gsYdCKTNX4m2qaXL9XgsDAf9NoNcbEFaTRiwjZos?= =?us-ascii?Q?Q1rePBMLzSL0yPdiYur5faqmvysXQL2eo6GYochiTG45Yv6vcqp7LJTlUxit?= =?us-ascii?Q?q/Nl9X+iHLguv0dZ4TzwOQcj1T56m+YpL+iXYwhtZy/sV4jSr3JVsAbutHqu?= =?us-ascii?Q?kmENNoOQGgX1oVHhmz4LEoyRSudId4BgEM9vl2tEEPYKv0Iwp9crdvtbCCtN?= =?us-ascii?Q?uhxKKNIE6xFNJyqJTmcIGdorndPGTmCch7Ju2iObw9JORtvHEcG36KY3sNLt?= =?us-ascii?Q?aI456OC0nDu9oGmJsn+ocfvqZUTGS4+bYwLWF2ZDz9cnOf7/buyClL4tzk6F?= =?us-ascii?Q?JfY1/nLYkbRbMMYjuA2O/SqZzkUDjB2BahGTiu+frSC3zTsABvxxBwd6dSDj?= =?us-ascii?Q?c9b8j27rPG4U673sFzYIQV250GB63fBw8z9S24FJIjh+bQKCAKe4n5ohBEM9?= =?us-ascii?Q?lTR1VkH3CMWAAI41lKRSI6AbXpW+L5NH4r2RF6dRGWFcYG5XnI8Jc/fmTPIR?= =?us-ascii?Q?1r5eX4v3RFntM7B2uFmq82dtgvw4sjuj69GIv7cH7J+7Air0KPSMaOJYWmSZ?= =?us-ascii?Q?bQUVl8RoY+0NzcpAmiBdy2Z+0ji6XrIleVqUuqjVLED51ZNLdny7h8n5Cks+?= =?us-ascii?Q?7GKnoHk=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2024 19:23:07.2644 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 051fb762-1a19-4d34-63bc-08dce317a519 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000971E2.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9346 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241002_122319_791990_9D79DE5B X-CRM114-Status: GOOD ( 11.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 02, 2024 at 12:04:32PM -0700, Yang Shi wrote: > > On Wed, Oct 02, 2024 at 10:55:14AM -0700, Yang Shi wrote: > > > +static inline unsigned int arm_smmu_strtab_max_sid(struct arm_smmu_device *smmu) > > > +{ > > > + return (1ULL << smmu->sid_bits); > > > +} > > > + > > Hmm, why ULL gets truncated to unsigned int here? > > No particular reason, but it should be better to not truncate here. Will > fix it. Yea, and looks like we are going to do with: static inline u64 arm_smmu_strtab_num_sids(struct arm_smmu_device *smmu); Then let's be careful at those return-value holders too: ----------------------------------------------------------- static int arm_smmu_init_strtab_linear(struct arm_smmu_device *smmu) { u32 size; struct arm_smmu_strtab_cfg *cfg = &smmu->strtab_cfg; size = (1 << smmu->sid_bits) * sizeof(struct arm_smmu_ste); ^^^^ overflow? [...] cfg->linear.num_ents = 1 << smmu->sid_bits; ^^^^^^^^ This is u32 ----------------------------------------------------------- Thanks Nicolin