From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org
Cc: paulo.miguel.almeida.rodenas@gmail.com,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [next] ARM: Replace snprintf() with the safer scnprintf() variant
Date: Fri, 4 Oct 2024 15:59:30 +1300 [thread overview]
Message-ID: <Zv9aEoDo1k36Hg3H@mail.google.com> (raw)
There is a general misunderstanding amongst engineers that {v}snprintf()
returns the length of the data *actually* encoded into the destination
array. However, as per the C99 standard {v}snprintf() really returns
the length of the data that *would have been* written if there were
enough space for it. This misunderstanding has led to buffer-overruns
in the past. It's generally considered safer to use the {v}scnprintf()
variants in their place (or even sprintf() in simple cases).
Link: https://lwn.net/Articles/69419/
Link: https://github.com/KSPP/linux/issues/105
Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
---
arch/arm/kernel/process.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index e16ed102960c..9d768a93fb1c 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -186,8 +186,8 @@ void __show_regs(struct pt_regs *regs)
unsigned int transbase;
asm("mrc p15, 0, %0, c2, c0\n\t"
: "=r" (transbase));
- snprintf(buf, sizeof(buf), " Table: %08x DAC: %08x",
- transbase, domain);
+ scnprintf(buf, sizeof(buf), " Table: %08x DAC: %08x",
+ transbase, domain);
}
#endif
asm("mrc p15, 0, %0, c1, c0\n" : "=r" (ctrl));
--
2.46.0
next reply other threads:[~2024-10-04 3:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 2:59 Paulo Miguel Almeida [this message]
2024-10-04 9:09 ` [PATCH] [next] ARM: Replace snprintf() with the safer scnprintf() variant Russell King (Oracle)
2024-10-04 18:46 ` Paulo Miguel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv9aEoDo1k36Hg3H@mail.google.com \
--to=paulo.miguel.almeida.rodenas@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).