From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Théo Lebrun" <theo.lebrun@bootlin.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] pinctrl: nomadik: Use string_choices API instead of ternary operator
Date: Mon, 23 Sep 2024 13:44:02 +0300 [thread overview]
Message-ID: <ZvFGctwe1vu9lQmd@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdYSPGsQt_FQDurtwmyaLtB3=gaay-hLN2QdOj25e3sK8A@mail.gmail.com>
On Mon, Sep 23, 2024 at 11:11:12AM +0200, Linus Walleij wrote:
> On Thu, Sep 5, 2024 at 2:56 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Aug 26, 2024 at 12:57:23PM +0300, Andy Shevchenko wrote:
>
> > > Use modern string_choices API instead of manually determining the
> > > output using ternary operator.
> >
> > Linus, do you have any comment on this?
> >
> > I had sent two patches of similar changes (different drivers, thoug),
> > one got applied and this is not. Anything should I do about it?
>
> Sorry for late reply :(
>
> I thought it looks weird to replace just one string choice
> in the middle of everything and it will be confusing for readers?
> They will be "but what is this now, this looks weird".
Do you mean it's incomplete? So, i.o.w., if we have str_output_input()
it will go?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-23 10:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 9:57 [PATCH v1 1/1] pinctrl: nomadik: Use string_choices API instead of ternary operator Andy Shevchenko
2024-09-05 12:56 ` Andy Shevchenko
2024-09-23 9:11 ` Linus Walleij
2024-09-23 10:44 ` Andy Shevchenko [this message]
2024-10-01 14:28 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvFGctwe1vu9lQmd@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=theo.lebrun@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).