From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A56DACF9C69 for ; Mon, 23 Sep 2024 10:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zBVeQENRqMaLLk8KLwVwVxMNVAloqDO7jKBWs189lyw=; b=EH4b8fEjy42QzOMYSdE2Xn5lc1 3ZZFyTyV+nF87YJlOD1dxm8Q65I0+TMYJuyZW70xo1eiV3pD+70oA4dThZ4wRVtmu1jYUgAc7LBOT MH0EJwcT45iV9Tit16A8mCS88JpcxchkHo66Z55g/8U5M+ZfQV6ZwsqaAQbjs+9RGL9VNM7tYGsP8 oKRJqnpnzkK+SdPddpENNuNKoDhW9lQMDPVcoLyrJZ2cQPxbUxtPMz9+DPbktxddFgu30HKI/fzSG O3DNMnukAvdJ16PPtETAkCHBmWTJ/DNN2hrU/8QV35iW6bozL17EaJbI/IAyiic01EYssemzlXh/K 2HaOKB1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1ssgZp-0000000H05Q-2DK6; Mon, 23 Sep 2024 10:45:57 +0000 Received: from mgamail.intel.com ([198.175.65.16]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1ssgY4-0000000GzsX-1b0t for linux-arm-kernel@lists.infradead.org; Mon, 23 Sep 2024 10:44:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727088249; x=1758624249; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=oKcFWTGa4Wd1F63+4plK6XDY/MxtOsFMlyeMw92+6eY=; b=eZeG4gu/KMSP/4sX1rxutQb6HWk40wD63R7K3gb7wQ9rqiwOOiNSsqUu d63MdJXoZgaIKzGnsvJP8/gBKV6YPUF+M1uKdPo7OsAdAaZ278tybOzAz B67EIpadr8QYSSEaucX+Lp0rI0v4l2KHdh3msXJLrAaT/rHjgCfowGrgu iTIoXAyMRw83fDfZyVpvJlMQLstHHNsJEgldV12FCo83mN9BTWpELMc+C lVVlo8gn3mvlwgInGfSvm8L8+4jEMYCvs9O1+yH2C5tw/TZ4qeLmIgwSE ScnYaloDl8u3P12J6YWB63CeqsURhbdM1ZuVAnOG2WeezWoXie3kD8cRG A==; X-CSE-ConnectionGUID: 5RbDP07qRY+feqiboBaP/Q== X-CSE-MsgGUID: 6hl00KdfQQqwLwbkyElFBw== X-IronPort-AV: E=McAfee;i="6700,10204,11202"; a="26123758" X-IronPort-AV: E=Sophos;i="6.10,251,1719903600"; d="scan'208";a="26123758" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2024 03:44:07 -0700 X-CSE-ConnectionGUID: wBEHr1JxRz2EvFbS6PFTNg== X-CSE-MsgGUID: 5d6hTUnMTfe+LzCf8TrTlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,251,1719903600"; d="scan'208";a="75970264" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2024 03:44:05 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1ssgXz-0000000BxIp-0UHc; Mon, 23 Sep 2024 13:44:03 +0300 Date: Mon, 23 Sep 2024 13:44:02 +0300 From: Andy Shevchenko To: Linus Walleij Cc: =?iso-8859-1?Q?Th=E9o?= Lebrun , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] pinctrl: nomadik: Use string_choices API instead of ternary operator Message-ID: References: <20240826095723.1421065-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240923_034408_488417_DCC7C1C2 X-CRM114-Status: GOOD ( 17.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 23, 2024 at 11:11:12AM +0200, Linus Walleij wrote: > On Thu, Sep 5, 2024 at 2:56 PM Andy Shevchenko > wrote: > > On Mon, Aug 26, 2024 at 12:57:23PM +0300, Andy Shevchenko wrote: > > > > Use modern string_choices API instead of manually determining the > > > output using ternary operator. > > > > Linus, do you have any comment on this? > > > > I had sent two patches of similar changes (different drivers, thoug), > > one got applied and this is not. Anything should I do about it? > > Sorry for late reply :( > > I thought it looks weird to replace just one string choice > in the middle of everything and it will be confusing for readers? > They will be "but what is this now, this looks weird". Do you mean it's incomplete? So, i.o.w., if we have str_output_input() it will go? -- With Best Regards, Andy Shevchenko