Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"João Paulo Gonçalves" <joao.goncalves@toradex.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Francesco Dolcini" <francesco.dolcini@toradex.com>
Subject: Re: [PATCH v1 2/3] arm64: dts: freescale: imx8mp-verdin: add labels to som nodes
Date: Tue, 24 Sep 2024 11:02:50 -0400	[thread overview]
Message-ID: <ZvLUmqM5FWqKPxoi@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20240924114053.127737-3-francesco@dolcini.it>

On Tue, Sep 24, 2024 at 01:40:52PM +0200, Francesco Dolcini wrote:
> From: João Paulo Gonçalves <joao.goncalves@toradex.com>
>
> Add labels to ti-ads1015 and fec ethernet mdio node to make it easier to
> reference them from other nodes.
>
> Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> index a19ad5ee7f79..e9518b7c7aa8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -320,7 +320,7 @@ &fec {
>  	pinctrl-0 = <&pinctrl_fec>;
>  	pinctrl-1 = <&pinctrl_fec_sleep>;
>
> -	mdio {
> +	verdin_eth2_mdio: mdio {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>
> @@ -591,11 +591,12 @@ hwmon_temp_module: sensor@48 {
>  		vs-supply = <&reg_vdd_1v8>;
>  	};
>
> -	adc@49 {
> +	verdin_som_adc: adc@49 {
>  		compatible = "ti,ads1015";
>  		reg = <0x49>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> +		#io-channel-cells = <1>;

Why add this? it is not related with what descript in commit message

Frank

>
>  		/* Verdin I2C_1 (ADC_4 - ADC_3) */
>  		channel@0 {
> --
> 2.39.5
>


  reply	other threads:[~2024-09-24 15:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-24 11:40 [PATCH v1 0/3] arm64: dts: freescale: imx8mp-verdin: Add Ivy carrier Francesco Dolcini
2024-09-24 11:40 ` [PATCH v1 2/3] arm64: dts: freescale: imx8mp-verdin: add labels to som nodes Francesco Dolcini
2024-09-24 15:02   ` Frank Li [this message]
2024-09-24 17:02     ` João Paulo Gonçalves
2024-09-25 16:53       ` Frank Li
2024-09-24 11:40 ` [PATCH v1 3/3] arm64: dts: freescale: imx8mp-verdin: Add Ivy carrier board Francesco Dolcini
2024-09-24 15:09   ` Frank Li
2024-09-24 16:50     ` João Paulo Gonçalves
2024-09-24 16:56       ` Frank Li
2024-09-25  1:56 ` [PATCH v1 0/3] arm64: dts: freescale: imx8mp-verdin: Add Ivy carrier Rob Herring (Arm)
2024-10-17  9:29 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvLUmqM5FWqKPxoi@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=francesco@dolcini.it \
    --cc=imx@lists.linux.dev \
    --cc=joao.goncalves@toradex.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox