Re: [PATCH v1 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95 PCIe

Conor Dooley
2024-09-24T16:05:51Z

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

On Tue, Sep 24, 2024 at 11:23:06AM -0400, Frank Li wrote:
> On Tue, Sep 24, 2024 at 11:08:20AM +0100, Conor Dooley wrote:
> > On Tue, Sep 24, 2024 at 11:27:36AM +0800, Richard Zhu wrote:
> > > Add one ref clock for i.MX95 PCIe. Increase clocks' maxItems to 5 and
> > > keep the same restriction with other compatible string.
> > >
> > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> >
> > It'd be really good to mention why this clock is appearing now, when it
> > did not before. You're just explaining what you've done, which can be
> > seen in the diff, but not why you did it.
>
> Previous reference clock of i.MX95 is on when system boot to kernel. But
> boot firmware change the behavor, so it is off when boot. So it need be
> turn on when it use. Also it need be turn off/on when suspend and resume.
> Previous miss this feature.

Please put this in the commit message Richard.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]