From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E747CCF9E9 for ; Thu, 26 Sep 2024 09:29:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V62c9pJSD6VRh8eb8OwwXWRNEbKWokzWKBv9N6bohhM=; b=C2fZWxcy6Vo0M7DAa6//DRpLHu ndPAt8KeoN4zzw1dyTLNdjEiC6ac3UYE2/bmTIroOhcgrJ7jY+8bHaydcpajN24ZtvaUf71seyrUB aeKsKmUwd9l9Bn4CrJM9gLc+GSKcZcUpq2eYywKTQywAwOCNEyyETfxamrMR2+gL63/D0AFoeK0aY DUooNx9Ez6C+Aoyvm0u8Ku14GHCvfBJsIvoHIjX0mVdALLA8PFWEtEUX7ayXYuwfXFMc5d3csGQ8z IOhNT2PkE9NFkjubCB3pj5ZUOINQNLMzdlVN0JcLeyfbR5zpNz9BECHalr9TTTzqXzspdTfMH9dZL 1mKWNVAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stko9-00000007snQ-0lov; Thu, 26 Sep 2024 09:29:09 +0000 Received: from mgamail.intel.com ([198.175.65.11]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stkax-00000007pxu-1fqp; Thu, 26 Sep 2024 09:15:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727342132; x=1758878132; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=t52b6eEVFeh7vAeNYk36NpJtPvi1jrH1+vPlodx9txE=; b=IxZAT5NXkfqG5jSwC6ANnyP989X2b7hyax8X7LWvbXXQDXhjkFN9ZvXO bPoVG8hC+YMRNVcuvMbyvB0fxhvqfTHMNJ2yMTITXnMZ8ZQ3qB86PO15Z qaqTiW1+1ODVkngMKbbv4tpv4u+cRGJasvQV9SWgvu7ROwv4HhORdUjmt qxHak42Pm+gnWrsVAnJ6KuqGDs872mEwAxbBQDPLBeBn0S1C0ZMtBTykA Amgi3Hs+GXTBpgSa50oPOIPw/Dl02IVQIn1CGBU0yWrHpp4syzIJljJTg tvlpJdTfiLHZf6KA+3HPIR3cGhb0X9Xysws4Cp5qogVQfF0v8U9heL1Or Q==; X-CSE-ConnectionGUID: Rbz6tz9BTya8t9g9rcJUVw== X-CSE-MsgGUID: t8t4rZjnSJSK3FQyjx2WKg== X-IronPort-AV: E=McAfee;i="6700,10204,11206"; a="36988985" X-IronPort-AV: E=Sophos;i="6.10,260,1719903600"; d="scan'208";a="36988985" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2024 02:15:30 -0700 X-CSE-ConnectionGUID: 9OFVUKdLRm6pTw+dhT+qfA== X-CSE-MsgGUID: xXJSVCtHRMah9HuTwI3otQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,260,1719903600"; d="scan'208";a="76888054" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2024 02:15:27 -0700 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 5F63611F843; Thu, 26 Sep 2024 12:15:23 +0300 (EEST) Date: Thu, 26 Sep 2024 09:15:23 +0000 From: Sakari Ailus To: Jacopo Mondi Cc: Tomi Valkeinen , Mauro Carvalho Chehab , Raspberry Pi Kernel Maintenance , Broadcom internal kernel review list , Laurent Pinchart , Naushir Patuck , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kieran Bingham , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Florian Fainelli , Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH v5 0/4] media: raspberrypi: Support RPi5's CFE Message-ID: References: <20240910-rp1-cfe-v5-0-9ab4c4c8eace@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240926_021531_519456_D66B249D X-CRM114-Status: GOOD ( 29.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jacopo, On Thu, Sep 26, 2024 at 11:04:36AM +0200, Jacopo Mondi wrote: > Hi Tomi > > On Thu, Sep 26, 2024 at 10:13:29AM GMT, Tomi Valkeinen wrote: > > Hi, > > > > On 10/09/2024 11:07, Tomi Valkeinen wrote: > > > This series adds support to the CFE hardware block on RaspberryPi 5. The > > > CFE (Camera Front End) contains a CSI-2 receiver and Front End, a small > > > ISP. > > > > > > To run this, you need the basic RPi5 kernel support plus relevant dts > > > changes to enable the cfe and camera. My work branch with everything > > > needed to run CFE can be found from: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git rp1-cfe > > > > > > A few notes about the patches: > > > > > > - The original work was done by RaspberryPi, mostly by Naushir Patuck. > > > - The second video node only sets V4L2_CAP_META_CAPTURE instead of both > > > V4L2_CAP_META_CAPTURE and V4L2_CAP_META_CAPTURE like the other nodes. > > > This is a temporary workaround for userspace (libcamera), and > > > hopefully can be removed soon. > > > > > > I have tested this with: > > > - A single IMX219 sensor connected to the RPi5's CSI-2 port > > > - Arducam's UB960 FPD-Link board with four imx219 sensors connected > > > > > > Tomi > > > > > > Signed-off-by: Tomi Valkeinen > > > --- > > > Changes in v5: > > > - Add "depends on PM". The platforms that use CFE will always have PM in > > > practice, and it's not worth supporting both the PM and !PM cases as > > > it adds complexity to the driver. > > > - Link to v4: https://lore.kernel.org/r/20240904-rp1-cfe-v4-0-f1b5b3d69c81@ideasonboard.com > > > > Is this solution to the PM issue ok for everyone? It feels most sensible to > > me. Any other comments? > > There was consensus at the media summit that platform drivers are > allowed to depend on PM. I'd say you should have generally a good idea these devices aren't found in systems without runtime PM support and that mostly applies to platform drivers. > > I'll do the same for my latest PiSP BE series. Ack. -- Kind regards, Sakari Ailus