From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 442DFCF8843 for ; Fri, 4 Oct 2024 15:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TVLq22bs+1l9xY9JOZ8imSDy5KmOLVk2kQhCSbpcWNE=; b=Uv+hyNMQZGB1Tecec6JsCY4YPW KQXG/uTaat3x8hgoThQ3nW08zd0cAnsjXiMdqNCyAISbaZ6Xyc8LFYe30bcT8hKo/SgAs4r1i/xJc 884KoalQ8oD4CneUTt8Mo63Q0d9eAnpAeXsBAaUzSxyocwzhGeOpxytcxtJaKRY7PuVPH0C6ZIB6k Q8jetbLpSIJ/I9iM/1xZbWN4fZ171n9jEsTz+3e0JEtYnKlthFYVxKW89V4p705+Dqq1wvAqvNEXx tX5mKzVh29bh9XCRQ2MoVoMWwU8ZDlAyyiz0g4L1OqHqfeiJ+jQDO0bPGg8/lrrEv32GSit6BEySx smrX9rGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1swk3l-0000000CxTl-41Jy; Fri, 04 Oct 2024 15:17:38 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1swiVS-0000000CZXY-0c0M for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2024 13:38:07 +0000 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-71971d2099cso2000102b3a.2 for ; Fri, 04 Oct 2024 06:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728049085; x=1728653885; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TVLq22bs+1l9xY9JOZ8imSDy5KmOLVk2kQhCSbpcWNE=; b=WNoLp64ypfzFcN/xsRwn0Qi8nDB86jXJ9kUS6hOfcwOhN6q7bLP5QKjpe1lixScGyq hOV95s5MQvgJ6jIcUuqPXHLjFN9YO+qb7ypmkNy2U7kJwEXye+/dZr4V61JjF2f2bmPZ k1VblXqt3Q97nKSKOPENIo11PDv7qryGRxjtHLTWanwKHrhcn9nScnDeJRuXc/0dTFif c2tSJI2zxEn6TdSckDRiT6BjopM+zWjDZHVhKbO+S33h8vYlIcobxINlJng3DyOxron4 lTlhcBUbu/bp5yZKOo1sKZZ/Oh+ekD8Dq1d/BzoSriXidlxiKoAGd1Hjdk6BYD59Tgtz zjGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728049085; x=1728653885; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TVLq22bs+1l9xY9JOZ8imSDy5KmOLVk2kQhCSbpcWNE=; b=CyRL3wp+c+QJqJWWMf7AjtJFWqG4HTJ+zIv6P6tAAGO9rCypKE/j7nH8yty3eHM70W he088GotZkVWZV8ivxK4PnIKbYNcIR3IgID1M8yaNDd8MgNXF4I2qF3XMddL4Ee3wuyP /yt7FGt2l0Sj8Z79HL2iRc+ETJmuquw/s++mgrCpZW6qSMRKYBTG25Edy9EPjGDWmoMr fH8ciH4hdN/AcHTH1+A5mBQlE1kW5fYPPh1b6Xd5M99SK3eGdHtk9zSDkC7iIAfSIHsl g02jYlgwdgJN+82rgB8GWcd9hRZnJeKomSsBwNnSI7ZiBUucRbO9Qp9i+JJfLxDjE5ut vXGQ== X-Forwarded-Encrypted: i=1; AJvYcCUFwNk01Zri+ANj0atZT6IvalCheyhfTiJ/3zYDyWWn1xa5wNUAQ2qMI80BLAI/RGlPSenT4PWzFbtFN3qyWsYv@lists.infradead.org X-Gm-Message-State: AOJu0YwLksoSQ8WhINe1yd/uWNA60uOxhnTRSdy8g0PgcBJM+BS0X9nt 7hNPr/afauFXtwCaPGMKWhWx0juNFiBXbVLxGdeuXuVl8ANs/K0T X-Google-Smtp-Source: AGHT+IGhEdASi+MxAhYr/5O4xJ1vTIjCaytgyNSnCaXtwTaIfB45CRoPQcP/88bkABWIesSJDpwwIg== X-Received: by 2002:a05:6a21:9204:b0:1d3:b38:891 with SMTP id adf61e73a8af0-1d6dfa22f7cmr5043217637.6.1728049084632; Fri, 04 Oct 2024 06:38:04 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:1b2:add:2542:c298]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71dd9def6ddsm3181637b3a.154.2024.10.04.06.38.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 06:38:04 -0700 (PDT) Date: Fri, 4 Oct 2024 06:38:01 -0700 From: Dmitry Torokhov To: Arnd Bergmann , Mark Brown Cc: Krzysztof Kozlowski , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH 00/14] Remove support for platform data from samsung keypad Message-ID: References: <20240819045813.2154642-1-dmitry.torokhov@gmail.com> <803e3902-cec9-49ed-baff-d26e578a8ab7@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <803e3902-cec9-49ed-baff-d26e578a8ab7@app.fastmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241004_063806_209223_91932DD9 X-CRM114-Status: GOOD ( 25.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 19, 2024 at 11:40:56AM +0200, Arnd Bergmann wrote: > On Mon, Aug 19, 2024, at 06:57, Dmitry Torokhov wrote: > > > > This series attempts to rework samsumg=keypad driver to stop using > > platform data and instead rely on generic device properties only. > > > > The first 8 patches are general cleanup/facelift patches. > > > > The 9th patch introduces alternative binding that is more compact that > > the original one, which makes it more suitable for use in legacy (non > > DT) boards with static device properties. Note that the "new" binding is > > the standard binding for matrix keypads. > > > > Patch #10 implements the new binding in the driver, #11 converts the > > only user of platform data in the mainline tree to the static device > > properties, and #12 drops support for platform data from the driver. > > > > Patches #13 and #14 are "bonus" converting the rest of crag6410 to use > > software nodes/properties to describe GPIO keys, LEDs and other > > peripherals. Note that I believe they fix and issue with recent > > conversion to GPIO lookup tables - the names of gpiochip structures I > > think are "GP" ("GPK", "GPL", etc) and not "GPIO". > > I had a (brief) look at the patches, everything looks fine to > me, thanks for working on this! Let's see what Mark and > Krzysztof think. Mark, were you able to give this a spin? Or should I address the DT binding comments from Krzysztof and Connor and resent for merge? Thanks. -- Dmitry