From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41C1DCF6496 for ; Sat, 28 Sep 2024 20:47:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B1wN4Mv6KTR3klc618UZyJIvaPfyrd+I69sEqUZILgs=; b=uqyRlUB4DSmclDO8s+un6P/rft 66owXnTAytfeO/tcc7IsbhNyVr9aX3/3iebkqSgTSQOmqFIalpbQxkbdCCN6hibApv1STavoncvWz pKeQ8QNYATQyasosebNda8umZNCYSg078p2UsV74tUwebruQAct7XthemiJq9nq0Xv0ihix4x2Cvb qSGgvv8f6Rg5L9mqB6pv+hdxSxtiL1cLGurPwbXCPkvhTkby9E09cGnklNV2BuJ6UsQackaT55fBe emrPgvCTrlVxUkuqUx9WRomTqQ0HhxlWj3eC6Ayvu62ZWycYUfKcs4k1oVOnrhAluiuogGu2mNtrH cedDG3rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sueLO-0000000Dc1k-46lw; Sat, 28 Sep 2024 20:47:10 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sueKB-0000000Dbuj-2vlk for linux-arm-kernel@lists.infradead.org; Sat, 28 Sep 2024 20:45:57 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-20b6c311f62so1516485ad.0 for ; Sat, 28 Sep 2024 13:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tenstorrent.com; s=google; t=1727556355; x=1728161155; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B1wN4Mv6KTR3klc618UZyJIvaPfyrd+I69sEqUZILgs=; b=gmlYAJsCwFkcPlmhrESDgHE1eaZoUJtULwCEx7tzHG7WIVEB92ftcKJDlknSe6OEgP DAO2Ehn7q2xHHVIDiSg2KWITBAeXs37qugddiMqzyKzTFe6Yz1wuCyujZEAK63/K0KDg cBIUBN3bCJsJzbIXIz3RDNM4GFtxPKrzfzzqEpcOXEOUPJudxX9eP9jagE+wsiMA/wyL LE4+dug0uhzgIf91y1Xg9RDjMLZTUwZvHP0QyBkhDiwSj8CGbNxPeNUFUqpqrkNjmFkm huDQ1OSzMc0L3am9lg11LKDngDeIwX/dIw7n+4gkLeVp81uCkqc0uazLB43hEf1qX43i QF5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727556355; x=1728161155; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B1wN4Mv6KTR3klc618UZyJIvaPfyrd+I69sEqUZILgs=; b=qK6B3zvMlmIMmICjng9+/G0RM2Q2ezj5djLC6xDO5CAzNxSS15Bn++xg9RN1Srpbo1 22v903YTIlrbp6O4PJ7oLtXzPX+A/tRb0w5dSkzcIzg7ufeP+pB2H4UY9FVzMIhgPRqA nzcKPIcvhIRAzWQlhS3Usy74BXxERdnqsRxwtri4FMZLNnqr/lcfG/wvK3L0RXmTBhJe Q3syMb5izKWgdJDymcRgK9lCIcTVdN3g2vb7U7aPh1lsBy+cdEkPsJHKYEL1ExnjRFDp M/nNGoWyCt6byViUtFupOuXEHlmjm26Y0g8Ge6RSrLomatpS0G6wstWVy3z0Ahn3Os5R rMjQ== X-Forwarded-Encrypted: i=1; AJvYcCUfjiEfOhRrz2nCnpAirkRUOm4Ju53iZL67M/UdlRyswsHqZwl/Jby70hkGCnVpxwO7X1QF9pDFwJsJGxABllbx@lists.infradead.org X-Gm-Message-State: AOJu0YxsNZUrDm3wKwt6CekGOGGSkXwE3EHVimo1eHkFGPe7UD5QiFjP BnN+Q8mF71N420RECR08g+MHAbtwNZ41WNGyzwMX+hPL/EfPrbj3F3Dg3KkLLBE= X-Google-Smtp-Source: AGHT+IHYe5C2dCeMbXLolGkdYVgGv6vaXYzm7QHCg36ZJ1QQJYHSFNwHxNkSM+iWKcxoee+lJlo/DA== X-Received: by 2002:a17:902:c952:b0:20b:6a57:bf3a with SMTP id d9443c01a7336-20b6a57c137mr21788895ad.1.1727556354766; Sat, 28 Sep 2024 13:45:54 -0700 (PDT) Received: from x1 (71-34-69-82.ptld.qwest.net. [71.34.69.82]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20b37e2f382sm30487635ad.182.2024.09.28.13.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Sep 2024 13:45:54 -0700 (PDT) Date: Sat, 28 Sep 2024 13:45:52 -0700 From: Drew Fustini To: Emil Renner Berthing Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Jisheng Zhang , Maxime Coquelin , Drew Fustini , Guo Ren , Fu Wei , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 3/3] riscv: dts: thead: Add TH1520 ethernet nodes Message-ID: References: <20240926-th1520-dwmac-v2-0-f34f28ad1dc9@tenstorrent.com> <20240926-th1520-dwmac-v2-3-f34f28ad1dc9@tenstorrent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240928_134555_768890_40A0C1D3 X-CRM114-Status: GOOD ( 17.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 27, 2024 at 05:55:04AM -0700, Emil Renner Berthing wrote: > Drew Fustini wrote: > > From: Emil Renner Berthing > > > > Signed-off-by: Emil Renner Berthing > > [drew: change apb registers from syscon to second reg of gmac node] > > [drew: add phy reset delay properties for beaglev ahead] > > Signed-off-by: Drew Fustini > > --- > > arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts | 91 ++++++++++++++ > > .../boot/dts/thead/th1520-lichee-module-4a.dtsi | 135 +++++++++++++++++++++ > > arch/riscv/boot/dts/thead/th1520.dtsi | 50 ++++++++ > > 3 files changed, 276 insertions(+) > > ... > > > diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi b/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi > > index ca84bc2039ef..d9d2e1f4dc68 100644 > > --- a/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi > > +++ b/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi > > @@ -11,6 +11,11 @@ / { > > model = "Sipeed Lichee Module 4A"; > > compatible = "sipeed,lichee-module-4a", "thead,th1520"; > > > > + aliases { > > + ethernet0 = &gmac0; > > + ethernet1 = &gmac1; > > + }; > > + > > memory@0 { > > device_type = "memory"; > > reg = <0x0 0x00000000 0x2 0x00000000>; > > @@ -25,6 +30,16 @@ &osc_32k { > > clock-frequency = <32768>; > > }; > > > > +&dmac0 { > > + status = "okay"; > > +}; > > + > > +&aogpio { > > + gpio-line-names = "", "", "", > > + "GPIO00", > > + "GPIO04"; > > +}; > > + > > These GPIO line names does not belong in this patch. They should > already be included in your other patchset adding the names for the > other lines. > > /Emil Thanks, yeah, those sneaked in here. Drew