From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA43DCF6497 for ; Sun, 29 Sep 2024 17:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: MIME-Version:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=zJoVyOezk87flQP/T1rSos3kBIbqevdYSEXyE/WYDJI=; b=wH2 H+MR2i1aqJ/5OU9X9icRQ4jTznWI/crmmznah8DAoqDvfz3Td2wNPSED/x8lgi9dsnelmcLnE7amV JEKIFNxZ2SNcu6a1yDLyfH9liGaCTKHksB1NA+SBC45Y3Pc0L0vTOjJNkj+r9grA5vc+Kp/C2TSsN IkpiDfUXHPK8Ds9T9M60JW7UlG5e3SIKeMCw7tnEeYkYArF/Qsj/+GBwJP2rlYipmsKhtLUK8+gsL wKxzsdO2APQBLYAl80SefG9Oa0Lh3/y+QhCR826zahp36aVQRffXOV0AtOmkJt47CYj3OzpOa5LOl gRzDFfXbJ3o6hJOXkKy/XArtabMyu1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1suxNu-0000000F4pw-2tdr; Sun, 29 Sep 2024 17:07:02 +0000 Received: from mx.treblig.org ([2a00:1098:5b::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1suxM5-0000000F4Np-3LfL; Sun, 29 Sep 2024 17:05:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=Content-Type:MIME-Version:Message-ID:Subject:From:Date:From :Subject; bh=zJoVyOezk87flQP/T1rSos3kBIbqevdYSEXyE/WYDJI=; b=EBo2Yob6sbucRYfk BLsjh54oBHEjhrLQtNgvOvjz/amc+KQrHrEbUx5bskLdfZ3lBzdBa3S0F4OYQChomNI7uk3VZbUvm FVASiw9lpM207UxUx62KpMEjly+Dg6QO8xzv/7J+dYQEFtnwFNpVpvVMDyaLhiGC/sSCtSmmbBoH1 K/Zw/KUkJFPzLudaAxRJ/VgQOz8aEy/f9O64+dbvFqiOjofOFLW8y51tv25sqCVK1o9Y+SYx9oQmd 6YlzgPEyKr0o+n2SHI+qt9ThIzl9ab/JJuOzeR/+aO6/CDYVFJkCikQskWyI3XuhhB1/Lng5cXaim wIrmTZfabkYwhgrClw==; Received: from dg by mx.treblig.org with local (Exim 4.96) (envelope-from ) id 1suxLx-007pnh-38; Sun, 29 Sep 2024 17:05:01 +0000 Date: Sun, 29 Sep 2024 17:05:01 +0000 From: "Dr. David Alan Gilbert" To: boris.brezillon@collabora.com Subject: of atmel_pmecc_destroy_user Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/6.1.0-21-amd64 (x86_64) X-Uptime: 16:56:56 up 144 days, 4:10, 1 user, load average: 0.00, 0.00, 0.00 User-Agent: Mutt/2.2.12 (2023-09-09) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240929_100509_944478_712C5C9D X-CRM114-Status: UNSURE ( 6.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: richard@nod.at, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Boris and co, One of my scripts noticed that 'atmel_pmecc_destroy_user' isn't called anywhere; I was going to delete it, but hmm, I wonder if it's actually a missing call and leaking (in the unlikely case the device was ever removed). It was added by your: commit f88fc122cc34c2545dec9562eaab121494e401ef Author: Boris Brezillon Date: Thu Mar 16 09:02:40 2017 +0100 mtd: nand: Cleanup/rework the atmel_nand driver and I see the allocation in: user = kzalloc(size, GFP_KERNEL); in nand->pmecc = atmel_pmecc_create_user(nc->pmecc, &req); called in atmel_nand_pmecc_init from atmel_nand_ecc_init from atmel_hsmc_nand_ecc_init But I don't see any freeing. (I don't knowingly have hardware to test a fix, although I guess there's probably one somewhere....) Suggestions? Thanks, Dave -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/