From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 751A2CEB2C9 for ; Mon, 30 Sep 2024 21:14:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rbbBjFe/Vvb+TnCt2gAKgPyVS+uE+DEQouJGLomPqxk=; b=GyiuXsIzWBAEWLE2MkSUKLDyxG 8oEtezpm58G8nrUzUnmRLaKxZhUQD5YZd388+QPfhAO+q9I4vjqTf9pJYHJZwMgXwpWOXfs/73a7x n3/0htJK5u9nAoCLtjCc0waAl6sFpjhE76Q5ASwQg0cfuEPHqilf0x3B8P6XQkj4qyD2Yex+WO5ev NGolXMaND1ttwJoDBgNjlS1PX0r2o5f2K/So2z915L/binudpSDn6edLBEKHq+liEsw4EVC30SZ2R MtzLGWBpil00ewJeK0UoZZorCN9zwGC/UltaI5rTMTbHYJ4XYxys2//HROxZd+cokQu2rfHyzyTbc BWELXO/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svNjB-00000000rzf-2SKw; Mon, 30 Sep 2024 21:14:45 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svNcY-00000000rB1-1tA3 for linux-arm-kernel@lists.infradead.org; Mon, 30 Sep 2024 21:07:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 966EF5C4A51; Mon, 30 Sep 2024 21:07:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76B57C4CECD; Mon, 30 Sep 2024 21:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727730473; bh=zZeMuXBLeHDf5XqrUgWrWOJr0y1aMxOQuR7+3GzMwbE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c2EEOkYmncI75goVlm0hl/uPCM040t6HYey+pUFxslwIBl1CReOSY48R5mnqZJ7xr XQeJZakrvmibPCpi/jXkSh6xboYECIcVla2aA0gUhCoYXt60xJOf1urrTGnXCCd2f3 kJbZQaxA8H9L2zpUQBWo2l3v0KHhKH9yobQsFpnmmvXBXOo27eqo2F2JaO8eJMovq3 J8wjfYacU7cNtE+pv+SfFF4cIjydoUMY6p5pwHtzR6gqWNwP/aXK5AYDj06iuCHgrM PYyKUZXwqD019VcSll3yziLSb6Npq/kZo61sf9XtzcN4QfSIy4j1hXnIv4GArwww0p yl772TLlGczXA== Date: Mon, 30 Sep 2024 14:07:51 -0700 From: Namhyung Kim To: Xu Yang Cc: Frank.li@nxp.com, will@kernel.org, mark.rutland@arm.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, john.g.garry@oracle.com, james.clark@linaro.org, mike.leach@linaro.org, leo.yan@linux.dev, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics Message-ID: References: <20240924061251.3387850-1-xu.yang_2@nxp.com> <20240924061251.3387850-3-xu.yang_2@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240924061251.3387850-3-xu.yang_2@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240930_140754_640813_4600B4DF X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Tue, Sep 24, 2024 at 02:12:51PM +0800, Xu Yang wrote: > Add JSON metrics for i.MX91 DDR Performance Monitor. > > Signed-off-by: Xu Yang > --- > .../arch/arm64/freescale/imx91/sys/ddrc.json | 9 +++++++ > .../arm64/freescale/imx91/sys/metrics.json | 26 +++++++++++++++++++ > 2 files changed, 35 insertions(+) > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json How do you want to route this? As it's mixed with kernel changes, I would generally request to split but it's a change just to add new files so it should be ok to go with other tree. In that case, Acked-by: Namhyung Kim Thanks, Namhyung > > diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json > new file mode 100644 > index 000000000000..74ac12660a29 > --- /dev/null > +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json > @@ -0,0 +1,9 @@ > +[ > + { > + "BriefDescription": "ddr cycles event", > + "EventCode": "0x00", > + "EventName": "imx91_ddr.cycles", > + "Unit": "imx9_ddr", > + "Compat": "imx91" > + } > +] > diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json > new file mode 100644 > index 000000000000..f0c5911eb2d0 > --- /dev/null > +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json > @@ -0,0 +1,26 @@ > +[ > + { > + "BriefDescription": "bandwidth usage for lpddr4 evk board", > + "MetricName": "imx91_bandwidth_usage.lpddr4", > + "MetricExpr": "(((( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8 ) + (( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32 )) / duration_time) / (2400 * 1000000 * 2)", > + "ScaleUnit": "1e2%", > + "Unit": "imx9_ddr", > + "Compat": "imx91" > + }, > + { > + "BriefDescription": "bytes all masters read from ddr", > + "MetricName": "imx91_ddr_read.all", > + "MetricExpr": "( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8", > + "ScaleUnit": "9.765625e-4KB", > + "Unit": "imx9_ddr", > + "Compat": "imx91" > + }, > + { > + "BriefDescription": "bytes all masters write to ddr", > + "MetricName": "imx91_ddr_write.all", > + "MetricExpr": "( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32", > + "ScaleUnit": "9.765625e-4KB", > + "Unit": "imx9_ddr", > + "Compat": "imx91" > + } > +] > -- > 2.34.1 >