From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C923DCEACEE for ; Tue, 1 Oct 2024 18:29:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jLzB+fC7s4ZTjL+88fUsgA6ZfRx5D3g3PUBRp4cU2Do=; b=K3+9J8XHBBsDCYIAqYuYUaYoy3 vKg2NAtlaqwjV5yrEJSNvQeJWxuvVxo22skdnImGvDI/o/X+zaxCgcYEby86YhTB8w9V1++mJviYP J8QtwKOn/DEkvrSC1fJRrB8l58YV0gdi//QD3jhWyo+fmb1NFs5zFIcJPo2bmoj4qhbU4JyX5LE36 dcTklwLC+fN0JtWFaL1ogUsY5q/YYyJRlfykuTzXn/jRk4uA4PnHhaZ/AtKBI7pvy3xKnim2BBf+o 2uN2I0WA0vgckMoJe3goKY1Ndai3k5mx54lv3Tx4j4c42crQZQc2pPzKX6ugWFq33Fxr4BOIrnKGM UXX1pHJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svhd2-00000003m1V-1iNY; Tue, 01 Oct 2024 18:29:44 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svhbp-00000003lrV-145a for linux-arm-kernel@bombadil.infradead.org; Tue, 01 Oct 2024 18:28:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jLzB+fC7s4ZTjL+88fUsgA6ZfRx5D3g3PUBRp4cU2Do=; b=jOjOLQwL8WvlN+OtszmGkrzl+B 05TU5sQ5XqvAvMp0vqipW0Q+hjkF9Q3geU2ZTC7O5pvY5rEpDGsFQoYTUf69lVBFDDqBUnFkilOVn pAXx0MtlCEGCDX5iMzpSehNqpdkaPxOFdZpKK34yBOfTeDg8kkct8akWEEFNkfCHCQOh2xZMxN625 qyvXzUZN0jayV++L2vkpbsYlaTuvjgsnyvAn7bD9nRKPh9ViLJJ9dal8+h2HHYyb375HjCq0I4bYE tfD0ZDrMmVK4VMTIGi8w06Tf53Jl/4KdbYLQaKxkVQKd2M+oeAvskPb+BfuyPrjOFLBDTSZybkYNn sii6Jp2A==; Received: from mail-mw2nam12on2060e.outbound.protection.outlook.com ([2a01:111:f403:200a::60e] helo=NAM12-MW2-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svhbl-00000003ICh-4Btv for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 18:28:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Idpt7ACqwSgKLmIAuX7lbULr6VeKF4BDuuIpbrgnf8sahcziYP8p+mk4Afv8tqGZh7Xzm84Nx5SQhYPUrtmRufVP7E7VYtiGAzxKLlwnz0/WUrHL4K4Uo0bjIw/pjIyYK5WZM6b9y0O3Jorl0xBg4kkDw0ogBLDX3y8AFWOg+8cEn8APXWCnocXJ/jk2Ig4mzuh5m2Ys1/frq4aRY+/y1qgUKqeEEaOZ691S+VhRR2uASAI+KUhLPZSo8Vm8MgvXviWJNafDh0iJbD0FBlho+wEO8ZyL8G1SV2GbNNp78wpK+giroNpUA/rXYWALDXZBHZ26+fCBZQvAZbtY+IGD8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jLzB+fC7s4ZTjL+88fUsgA6ZfRx5D3g3PUBRp4cU2Do=; b=VNs9/kEchgTfZtgb8oBFmY2Ahh0XTYFe+rD4+HsreTH9FAb5jD48YLRlNfHE3VO7/lHSgUtSiPoMOS/e8AqA8p0Y4r9gYFcz+mnLTCKENaO+6Cifz9ZgesihI/D4l1zcqEVfwbGA5T1zoNJ7xZEeaMP53mRHR40RS7/Av42mfWeZFKZ+SuGtHfwQh8UJDf+ONud+8we16BO0ScuhHrbQq0QbJ2IM3hDdXMQG7MgQyjB8fPRlfg/w32xQpVllwVvS6MlI6pHGLGz5EHX3S7YlhvxnDCdGPIg73cMiJdUsrLOzRsVIDHm26rkkxq36IEEq4vyOvKxztBuYo/hqtGiQUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=os.amperecomputing.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jLzB+fC7s4ZTjL+88fUsgA6ZfRx5D3g3PUBRp4cU2Do=; b=E/90Z2sNYP+ajUoSRYiAkCyEzPH3CT9G+39HH0mYlCmuzqa2WyKLmMTeSeQ0FylqHouHce31s82vufxUAamYaa/DjlSBdB5BX/TgF8c55I0OwadCubYigDwSGl4IlnyWojmY02wm1ZgS7dsB6ouIOO5eQ5zONvXpXWZcV7y9PlmnGqySBzeI/6UEHjImUyUnbYJ1AY6YCkbJnDEeMJHsQjd1SnyykKIMj+Xp3lLdcKA967SXKyBnD9LBzNEj3EeWCYDZAelX9CrMcDwBHCpOdXnHYn3con2uZI1cpEDD4BdzXxFPwG8zQrsF3Yyou7kwbZpC9FonSEWd+25J0vwzmg== Received: from BLAPR03CA0113.namprd03.prod.outlook.com (2603:10b6:208:32a::28) by SN7PR12MB7788.namprd12.prod.outlook.com (2603:10b6:806:345::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.27; Tue, 1 Oct 2024 18:28:16 +0000 Received: from MN1PEPF0000ECD7.namprd02.prod.outlook.com (2603:10b6:208:32a:cafe::60) by BLAPR03CA0113.outlook.office365.com (2603:10b6:208:32a::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.27 via Frontend Transport; Tue, 1 Oct 2024 18:28:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by MN1PEPF0000ECD7.mail.protection.outlook.com (10.167.242.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.11 via Frontend Transport; Tue, 1 Oct 2024 18:28:15 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 1 Oct 2024 11:27:56 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 1 Oct 2024 11:27:56 -0700 Received: from Asurada-Nvidia (10.127.8.13) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Tue, 1 Oct 2024 11:27:55 -0700 Date: Tue, 1 Oct 2024 11:27:54 -0700 From: Nicolin Chen To: Yang Shi CC: , , , , Subject: Re: [PATCH] iommu/arm-smmu-v3: Fix L1 stream table index calculation for AmpereOne Message-ID: References: <20241001180346.1485194-1-yang@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241001180346.1485194-1-yang@os.amperecomputing.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000ECD7:EE_|SN7PR12MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a943f9a-e793-47e8-40a3-08dce246d0ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?etfEy7QTtdNx9RjbYGsCG8mX0SJqdTmEhu58I2RqcZJj1PmVr1/2Q87bV1lS?= =?us-ascii?Q?xenOyqknSJqY5mSfu8bOpsadJ5woPNCiKSSDA11BVfVjppy+UfSvAhMkS1BU?= =?us-ascii?Q?suIdWr2fI9lPa1nouYSX+5VQx6b4YA0GXPgDcN3sQue00wMigXfCCmvuq0Oa?= =?us-ascii?Q?/sNGQmOxyzheXJj+J/RIuXj6eRT2K8DiClfk2x4TFZn75O6Xd9mjgw4vM7QF?= =?us-ascii?Q?lQsOvv3H7/+vyb4voQbmvPo/KzhTTxV1ITWtBsPH0qTLlAxACgpiQO2NtBLO?= =?us-ascii?Q?CRJ+uPXIrf0kAk1Mw5li9+Tgis6sc5SHe9oRE55ksiPBtR9oMUt9pqB60FJl?= =?us-ascii?Q?DevXjLeWVsaXu/4okdyeFh0hNZXVPcfg9escnIMwpE0G0D3l2+X+LKIK6qSI?= =?us-ascii?Q?VMYBLoCOUbruxuGy3l0dFYKr9S6nrpq5a9r0wXM5J7WfnJuRiI6+HjFCjpBh?= =?us-ascii?Q?EuUE2abXZwQ8Nz+qZjMoAaTd/PkvhKarhy81M6H0+SpI6cQGM4ormwghfOuh?= =?us-ascii?Q?F5n36OqxBdVFlQaOp6Mi9Z3uHE1+Ia6ei9lCPpl6S4e+qZAK4BLiIAP6DURM?= =?us-ascii?Q?P590QLI1QCVErZi4Het4iId80xHULoY50P9GEDNsX8bt6eU/tsRdOjho8Kkl?= =?us-ascii?Q?Nny6ePtvyGCdEIC43xCIZT/8bte7wdlyfNjB3h38XYNHAHwQ/rbXLMcz70mA?= =?us-ascii?Q?2Lu0DXDRjmV2qh9HdbsdmOx1MzhJys0QO/9+LOch9Lg9/OBkqzsma8vwHgDE?= =?us-ascii?Q?isxsNQlhZMNnI6e0FEiIXp4fcb+qlmvBhT8vAeTJ24DVK3PE6N6RA/UGIClj?= =?us-ascii?Q?km/PzKFRNF2Fz4WOfZtpObkA9E7+KRP9mTAOKbTf+tHp80XIgAksZh1uCnWg?= =?us-ascii?Q?KPkPgCmkCM7FJ4hOVfL59atGMZ9HXLCal9mfT1uky97QGbxuwl1dGTQRMP5d?= =?us-ascii?Q?IYzCywHRqlPEHHrAPBtmYL7jFRhW7Av1lHRxk2Zd8DHfYn4jUv2XR4wl1Lj7?= =?us-ascii?Q?cQezZpEZj4h7HcBdDjX9kN/mqk23G9ZF3daTP+UHTiOwVZFpveBUaeMFvSgf?= =?us-ascii?Q?/xQ1bwrmi9ys+OQgi4UVRj+JElV6iAm3/TtVu3Q4k7jZ7PnPe2FiwyY4aH38?= =?us-ascii?Q?F8Wo5Aq7zb+YySMBRoyt08bjsr3IxeZDxzq8WYjhJ1lLiXLk49L5MEzV46ne?= =?us-ascii?Q?8tvi0+vVzGSzMO24+PF9WPFZ3se4UkhpcaOdA2KkmTi4qypWKc3KM8eZnelV?= =?us-ascii?Q?lj/2KTPY2BP57/B6clLoyssnpnseRo19uBkcc3OAD4+1oEuGxFrknfPooaOw?= =?us-ascii?Q?VE+hX5Z26WSGaOMxv6xRlAMhUNFgXbvZTcgHb8wwPa35nOgcnlDTlZQ+3+KJ?= =?us-ascii?Q?yMc/ds/x362ewEgyQ2coKBScmgboHksb5Rny8q9W2RGNYxY8CJLt1+YWTwLa?= =?us-ascii?Q?vEB0BcbnKWfSfBE6bkIqRsOh+DSJKl5T?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2024 18:28:15.6240 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a943f9a-e793-47e8-40a3-08dce246d0ca X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000ECD7.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7788 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_192826_128689_D820D784 X-CRM114-Status: UNSURE ( 9.16 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 01, 2024 at 11:03:46AM -0700, Yang Shi wrote: > Using 64 bit immediate when doing shift can solve the problem. The > disssembly after the fix looks like: [...] > unsigned int last_sid_idx = > - arm_smmu_strtab_l1_idx((1 << smmu->sid_bits) - 1); > + arm_smmu_strtab_l1_idx((1UL << smmu->sid_bits) - 1); Could a 32-bit build be a corner case where UL is no longer a "64 bit" stated in the commit message? Also, there are other places doing "1 << smmu->sid_bits", e.g. arm_smmu_init_strtab_linear(). Then, can ssid_bits/s1cdmax be a concern similarly? Thanks Nicolin