From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8E18CF3185 for ; Tue, 1 Oct 2024 22:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FKpbw9Uxxm1/Gc6q+N6cP4psHIAMvgo0/79kAYtDZEo=; b=U2Pj8knwf3eqxSSAEjaTFMWk7t aUSEaXqzSHbPksZjIViLLurw8X3Bscuhc25xHISaaT2ehezkNIsif4ASlY6k7WBzksiG8vhKalmPt TB2PzExl41f541F9JN87/liRvrnVixf1sYXVjTVqZcBMV0r6L8JFOLGBSCrF6cXVp5yOHGmZFyF9R jA9iCe3HQiyzOUiJsH8NKzdxjM0zruTxMqTZ0ckQEJInN0LmumClrzwggPIrzIQSeSKF64sE5lhnb RIT2Oo9QEn6ofoS8PvSfHxw8wd3WgO7dgbo4mddY+LfYHQeaasIbW2bPm7HrM6+ndBUttWdtth+bZ 3qGHJ/PA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svkxE-00000004Aqa-0ilY; Tue, 01 Oct 2024 22:02:48 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svkw0-00000004Alf-3Eud for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 22:01:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=FKpbw9Uxxm1/Gc6q+N6cP4psHIAMvgo0/79kAYtDZEo=; b=zGfzcXIeFaQbqg1H88SF9RtM5B JHDgjGCz1hTEnC3lHayUYI8/Gs2ymaiucTdosDvKGhAONKSyykv1Jqvuc9ngJ0C0eHJp+GouRsVvw fZtc7tURnQ7AWy2OVFteGBUwHCQymjY1/9v3eXn13KXxXdPEOD7X5QxpGlTRIXW9ORCURawGBUNJl pZX5VgTJiNxmSHHXzR5jKHuPSzS9Wle3CaGghill9/rIiDs+qPQt4SFQLl7cpKbKo2aA5a5lo7j03 hA9jWXSQM7d5Tk/Ml7DgG7CI4+M7r9hZdobzBpZKVHrr4440liC5TuGNeAmP5KVQfScfCcmv43QiT Y8HW2JVg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56570) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1svkvj-0006Ub-2L; Tue, 01 Oct 2024 23:01:15 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1svkvd-0005HK-0b; Tue, 01 Oct 2024 23:01:09 +0100 Date: Tue, 1 Oct 2024 23:01:09 +0100 From: "Russell King (Oracle)" To: Serge Semin Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Jiawen Wu , Jose Abreu , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Mengyuan Lou , netdev@vger.kernel.org, Paolo Abeni , Vladimir Oltean Subject: Re: [PATCH net-next 01/10] net: pcs: xpcs: move PCS reset to .pcs_pre_config() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_150132_835360_EF4B1506 X-CRM114-Status: GOOD ( 24.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 01, 2024 at 11:34:42PM +0300, Serge Semin wrote: > Hi Russell > > On Tue, Oct 01, 2024 at 05:04:10PM GMT, Russell King (Oracle) wrote: > > Move the PCS reset to .pcs_pre_config() rather than at creation time, > > which means we call the reset function with the interface that we're > > actually going to be using to talk to the downstream device. > > > > Reviewed-by: Vladimir Oltean > > Tested-by: Vladimir Oltean # sja1105 > > Signed-off-by: Russell King (Oracle) > > Continuing the RFC discussion. As I mentioned here: > https://lore.kernel.org/netdev/mykeabksgikgk6otbub2i3ksfettbozuhqy3gt5vyezmemvttg@cpjn5bcfiwei/ > The PCS-reset procedure actually can be converted to being independent > from the PHY-interface. Thus you won't need to move the PCS resetting > to the pre_config() method, and get rid from the pointer to > dw_xpcs_compat utilization each time the reset is required. > > So why not to merge in my patch to your series as a pre-requisite > change and then this patch can be converted to just dropping the > xpcs_find_compat() method call from the xpcs_init_iface() function? > Alternatively the dropping can be just incorporated into my patch. I'm wondering why we seem to be having a communication issue here. I'm not sure which part of "keeping the functional changes to a minimum for a cleanup series" you're not understanding. This is one of the basics for kernel development... and given that you're effectively maintaining stmmac, it's something you _should_ know. So no, I'm going to outright refuse to merge your patch in to this series, because as I see it, it would be wrong to do so. This is a _cleanup_ series, not a functional change series, and what you're proposing _changes_ the _way_ reset happens in this driver beyond the minimum that is required for this cleanup. It's introducing a completely _new_ way of writing to the devices registers to do the reset that's different. The more differences there are, the more chances there are of regressions. So, again, no.. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!