From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF8AAD18129 for ; Mon, 14 Oct 2024 15:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kHOaJCpdkLCyfcB3zM2Q+vmw18075Y0ssxpIFUW1WaM=; b=GLfeLJRiAEAT6wwe9IqqB7e2+x qCnskce04rCrJSc59fhAOe67rOQwx11lXG3xjBa7WDpe9/ZpnGhOCp2E9L4QEKgqVwz55yTBsavY/ TddfCXMi4NbMy/vrB0DE6EeVbPKE2RQMemdXbL8Yix/zObJLzRzXym1jvEwGDYniA4MFyZHrKxgFN fwfrj7bQmYokwzOojD6qKo/+/MoGOlK8pV4QFOAFvOH7EeztmWW8PqaiM7yLBN0nQxn4ejyuWRtxq BMe0wWRhGsdcdaeech5cTYHWc09jKY0sZSXdk5N3lJ/mobSwnI0RAbDGrzu3HfDt95fclwJbZAUj/ oE15qTHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0N6y-00000005gf4-0VXi; Mon, 14 Oct 2024 15:35:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0MGc-00000005Vxy-0A8Z for linux-arm-kernel@lists.infradead.org; Mon, 14 Oct 2024 14:41:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 05FF31007; Mon, 14 Oct 2024 07:42:19 -0700 (PDT) Received: from bogus (e133711.arm.com [10.1.196.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BFB763F51B; Mon, 14 Oct 2024 07:41:48 -0700 (PDT) Date: Mon, 14 Oct 2024 15:41:46 +0100 From: Sudeep Holla To: Gavin Shan Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, shan.gavin@gmail.com Subject: Re: [PATCH] firmware: arm_ffa: Fix warning caused by export_uuid() Message-ID: References: <20241014004724.991353-1-gshan@redhat.com> <2ea2b741-3abd-4fe1-b622-b6a4a3c2a92b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2ea2b741-3abd-4fe1-b622-b6a4a3c2a92b@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241014_074150_207028_1C855017 X-CRM114-Status: GOOD ( 24.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 14, 2024 at 08:25:54PM +1000, Gavin Shan wrote: > On 10/14/24 8:08 PM, Sudeep Holla wrote: > > On Mon, Oct 14, 2024 at 10:47:24AM +1000, Gavin Shan wrote: > > > Run into build warning caused by export_uuid() where the UUID's > > > length exceeds that of ffa_value_t::a2, as the following warning > > > messages indicate. > > > > > > In function ‘fortify_memcpy_chk’, > > > inlined from ‘export_uuid’ at ./include/linux/uuid.h:88:2, > > > inlined from ‘ffa_msg_send_direct_req2’ at drivers/firmware/arm_ffa/driver.c:488:2: > > > ./include/linux/fortify-string.h:571:25: error: call to ‘__write_overflow_field’ \ > > > declared with attribute warning: detected write beyond size of field (1st parameter); \ > > > maybe use struct_group()? [-Werror=attribute-warning] > > > 571 | __write_overflow_field(p_size_field, size); > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > Fix it by not passing a plain buffer to memcpy() to avoid the overflow > > > and underflow warning, similar to what have been done to copy over the > > > struct ffa_send_direct_data2. > > > > > > > Are you observing this just on the upstream or -next as well? There is a > > fix in the -next which I haven't sent to soc team yet, will do so soon. > > > > I just tried the upstream when the patch was posted. I just have a try with -next > and similar error exists. > > [root@nvidia-grace-hopper-01 linux-next]# git remote -v > origin git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git (fetch) > origin git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git (push) > [root@nvidia-grace-hopper-01 linux-next]# make W=1 drivers/firmware/arm_ffa/driver.o > : > In function ‘fortify_memcpy_chk’, > inlined from ‘ffa_msg_send_direct_req2’ at drivers/firmware/arm_ffa/driver.c:504:3: > ./include/linux/fortify-string.h:580:25: error: call to ‘__read_overflow2_field’ declared with attribute warning: \ > detected read beyond size of field (2nd parameter); maybe use struct_group()? [-Werror=attribute-warning] > 580 | __read_overflow2_field(q_size_field, size); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > > Part of the changes included this patch is still needed by -next. Could you please > squeeze the changes to that one to be pulled? Sure I can do that. Can you share the build command(specifically if any extra warning are enabled) and the toolchain used ? I am unable to reproduce it with clang 20.0.0, not sure if it my toolchain or build command/flags that differs here. -- Regards, Sudeep