linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Xinqi Zhang <quic_xinqzhan@quicinc.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	Cristian Marussi <cristian.marussi@arm.com>,
	linux-arm-msm@vger.kernel.org, arm-scmi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: fix slab-use-after-free in scmi_bus_notifier
Date: Tue, 15 Oct 2024 13:49:29 +0100	[thread overview]
Message-ID: <Zw5k2clQgGPQfRau@pluto> (raw)
In-Reply-To: <20241015-fix-arm-scmi-slab-use-after-free-v1-1-b006eba9c8df@quicinc.com>

On Tue, Oct 15, 2024 at 06:48:25PM +0800, Xinqi Zhang wrote:
> Move release of scmi_dev->name into scmi_device_release to
> avoid slab-use-after-free.
> 

Hi,

Thanks for reporting this.

Can you add a bit more of conetxt in the commit message on when this
happens ? From the stacktrace seems related to an early chan_setup failure
and the subsequent complete shutdown of the SCMI stack.

And also a Fixes tag would be useful.

Thanks,
Cristian


      reply	other threads:[~2024-10-15 12:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 10:48 [PATCH] firmware: arm_scmi: fix slab-use-after-free in scmi_bus_notifier Xinqi Zhang
2024-10-15 12:49 ` Cristian Marussi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zw5k2clQgGPQfRau@pluto \
    --to=cristian.marussi@arm.com \
    --cc=arm-scmi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_xinqzhan@quicinc.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).