From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DE94D21699 for ; Tue, 15 Oct 2024 12:55:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3HEDbAnSsvXLhu547Akb9arepBe3AlCGxUARhUzrY4U=; b=ASEFsHIR6Xay+hB340CA1CeGW8 cONCtVh+OvN3TZgdmdUUzPJwqN2ATXv1/5v1QqP/GDYGCNcn1Upa392WhrX9PUsBXh7NHgz2RKKSh Nexl0dWpgsZ0DNm3H0K3HJRTUzb1tI9khVOZgJd+zHctvY9hhOVTC4UrpzdTHTR6E5/drY88C1aQT D+XqofkgKrXRQWTJYKEhZADSotWN6IA/3iUBdJ8Q/UdF/SMnqloyLUXs8NoVNIZJ/S/8cl46Qzd0k Y6WkJQV/3kJCzDTb27mIkAtlPO3lE4cFng714s0PyEkoRKKaLnK+GE6OVzKeUOlJfo/TCdiZmYvfl RLgaGsag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0h51-00000008Frk-3ThH; Tue, 15 Oct 2024 12:55:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0gzZ-00000008F23-1TI9 for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2024 12:49:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 77F5EDA7; Tue, 15 Oct 2024 05:50:03 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 75C843F51B; Tue, 15 Oct 2024 05:49:32 -0700 (PDT) Date: Tue, 15 Oct 2024 13:49:29 +0100 From: Cristian Marussi To: Xinqi Zhang Cc: Sudeep Holla , Cristian Marussi , linux-arm-msm@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scmi: fix slab-use-after-free in scmi_bus_notifier Message-ID: References: <20241015-fix-arm-scmi-slab-use-after-free-v1-1-b006eba9c8df@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241015-fix-arm-scmi-slab-use-after-free-v1-1-b006eba9c8df@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241015_054937_451439_C56EE73D X-CRM114-Status: UNSURE ( 9.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 15, 2024 at 06:48:25PM +0800, Xinqi Zhang wrote: > Move release of scmi_dev->name into scmi_device_release to > avoid slab-use-after-free. > Hi, Thanks for reporting this. Can you add a bit more of conetxt in the commit message on when this happens ? From the stacktrace seems related to an early chan_setup failure and the subsequent complete shutdown of the SCMI stack. And also a Fixes tag would be useful. Thanks, Cristian