From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CAF6D206A0 for ; Wed, 16 Oct 2024 07:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+XnIY4ZVXC+5LY+pa8gVUeF82l8myqDrbd98ErqrQtM=; b=Bf1CQi9hsrnX3kBzum2971Avqs rlD0+1dgV37kUMS10NoLfLZw4vOUqX3D8w8O5KWwL4W3roSGPyVA8ERUbRM3+Cad78yZxrb7BDxgU g2IED9ai0zymcwQl6KB+6GAotTR1nW3kDcPvFm6XBTxG3ISbszWrAh/eXbG8QkPw9EuxbbS8OQqPk wt3BZxle+oNzDCo6xomkBVUTszqdlswf2mhYNs8i9WQpS0YkgWiN081o8IuF+aMDq6kJlXDLlEzMQ 9aT0Kba4mSUgPBVfqhDc1Eg3q1tkq0cbNxRI4wEyvO/YjcNd5W4MzVnynE0kjWYVEylDh+hjZjke4 pGYiQSVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0yEK-0000000Anpb-0BDd; Wed, 16 Oct 2024 07:14:00 +0000 Received: from mail-m16.yeah.net ([220.197.32.16]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0yBR-0000000AnWU-2D7w for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2024 07:11:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=+XnIY4ZVXC+5LY+pa8gVUeF82l8myqDrbd98ErqrQtM=; b=hlJZF52vsQEaY7+MC+/bqE80M9vXmf5KJxSreanh7UFu1IRNcMdQxesCbgwdPm 6N5V8HaHby5JM/fevQIZtusvvdZ2JaTdKqQpOFT0fm4qwmTdyEegB7OmbyLS2ec+ vnBPQgTaeRXKxhxPy9TFcCs/v4EDoAwP4gBRAgGuvbHsA= Received: from dragon (unknown []) by gzsmtp1 (Coremail) with SMTP id Mc8vCgBHCuLpZg9nFLEYAA--.368S3; Wed, 16 Oct 2024 15:10:35 +0800 (CST) Date: Wed, 16 Oct 2024 15:10:33 +0800 From: Shawn Guo To: Tim Harvey Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Li Yang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] arm64: dts: imx8m*-venice-gw75xx: add Accelerometer device Message-ID: References: <20240909215009.779368-1-tharvey@gateworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240909215009.779368-1-tharvey@gateworks.com> X-CM-TRANSID: Mc8vCgBHCuLpZg9nFLEYAA--.368S3 X-Coremail-Antispam: 1Uf129KBjvJXoWxXF45JF15WF4kAFy3uw15urg_yoW5Xw47pF 1xCan0gF1fWF42va4aqF18G3s8Ca95GFZ09wnFkFy0yr43uF90qayFkFn3ur4qqFWrZw45 ZF48ZryxWr1aqw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jmBT5UUUUU= X-Originating-IP: [117.62.23.175] X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiEhZ6ZWcPYsUORAAAse X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241016_001101_910548_C5874534 X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 09, 2024 at 02:50:09PM -0700, Tim Harvey wrote: > The GW75xx has a LIS2DE12TR 3-axis accelerometer on the I2C bus with an > interrupt pin. Add it to the device-tree. > > Signed-off-by: Tim Harvey > ---- > v2: > - make sure compatible is on top and vendor specific props are at the end per: > https://docs.kernel.org/devicetree/bindings/dts-coding-style.html > - fix typo in commit message > --- > .../boot/dts/freescale/imx8mm-venice-gw75xx.dtsi | 16 ++++++++++++++++ > .../boot/dts/freescale/imx8mp-venice-gw75xx.dtsi | 16 ++++++++++++++++ > 2 files changed, 32 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw75xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw75xx.dtsi > index 5eb92005195c..d17e1f375be4 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw75xx.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw75xx.dtsi > @@ -116,6 +116,16 @@ &i2c2 { > pinctrl-0 = <&pinctrl_i2c2>; > status = "okay"; > > + accelerometer@19 { > + compatible = "st,lis2de12"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_accel>; > + reg = <0x19>; Could you have 'reg' after 'compatible'? Shawn > + interrupt-parent = <&gpio5>; > + interrupts = <8 IRQ_TYPE_LEVEL_LOW>; > + st,drdy-int-pin = <1>; > + }; > + > eeprom@52 { > compatible = "atmel,24c32"; > reg = <0x52>; > @@ -198,6 +208,12 @@ MX8MM_IOMUXC_SPDIF_RX_GPIO5_IO4 0x40000040 /* GPIOC */ > >; > }; > > + pinctrl_accel: accelgrp { > + fsl,pins = < > + MX8MM_IOMUXC_ECSPI1_MISO_GPIO5_IO8 0x159 > + >; > + }; > + > pinctrl_gpio_leds: gpioledgrp { > fsl,pins = < > MX8MM_IOMUXC_SAI1_RXFS_GPIO4_IO0 0x6 /* LEDG */ > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw75xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw75xx.dtsi > index 0d40cb0f05f6..c9934cf98942 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw75xx.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw75xx.dtsi > @@ -104,6 +104,16 @@ &i2c2 { > pinctrl-0 = <&pinctrl_i2c2>; > status = "okay"; > > + accelerometer@19 { > + compatible = "st,lis2de12"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_accel>; > + reg = <0x19>; > + interrupt-parent = <&gpio5>; > + interrupts = <8 IRQ_TYPE_LEVEL_LOW>; > + st,drdy-int-pin = <1>; > + }; > + > eeprom@52 { > compatible = "atmel,24c32"; > reg = <0x52>; > @@ -204,6 +214,12 @@ MX8MP_IOMUXC_SAI3_RXFS__GPIO4_IO28 0x40000106 /* PCI_WDIS# */ > >; > }; > > + pinctrl_accel: accelgrp { > + fsl,pins = < > + MX8MP_IOMUXC_ECSPI1_MISO__GPIO5_IO08 0x159 > + >; > + }; > + > pinctrl_gpio_leds: gpioledgrp { > fsl,pins = < > MX8MP_IOMUXC_SAI2_RXC__GPIO4_IO22 0x6 /* LEDG */ > -- > 2.25.1 >