Re: [PATCH 1/3] phy: Add UFS phy hibernate modes

Vinod Koul
2024-10-07T06:34:08Z

Hi Peter,

On 02-10-24, 21:15, Peter Griffin wrote:
> Some UFS phys need to write hibernation specific values
> when entering and exiting hibernate state.
>
> Add two new UFS phy modes to the phy framework so that this
> is possible. One such platform that requires this is Pixel 6
> which uses the gs101 SoC.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> include/linux/phy/phy.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
> index 03cd5bae92d3..1874e55e2bb9 100644
> --- a/include/linux/phy/phy.h
> +++ b/include/linux/phy/phy.h
> @@ -42,7 +42,9 @@ enum phy_mode {
> PHY_MODE_MIPI_DPHY,
> PHY_MODE_SATA,
> PHY_MODE_LVDS,
> - PHY_MODE_DP
> + PHY_MODE_DP,
> + PHY_MODE_UFS_HIBERN8_ENTER,
> + PHY_MODE_UFS_HIBERN8_EXIT,

I am not sure I like this. why should this be the model? Phy drivers
should listen to pm events and handle this in pm_suspend/resume calls,
why do we need this special mode here...
Also, this is not a "mode" for phy

--
~Vinod