From: Sudeep Holla <sudeep.holla@arm.com>
To: Justin Chen <justin.chen@broadcom.com>
Cc: arm-scmi@vger.kernel.org, cristian.marussi@arm.com,
linux-arm-kernel@lists.infradead.org, peng.fan@nxp.com,
Sudeep Holla <sudeep.holla@arm.com>,
bcm-kernel-feedback-list@broadcom.com,
florian.fainelli@broadcom.com
Subject: Re: [PATCH] firmware: arm_scmi: Queue in scmi layer for mailbox implementation
Date: Mon, 7 Oct 2024 14:04:10 +0100 [thread overview]
Message-ID: <ZwPcSmRpTGrCdt6I@bogus> (raw)
In-Reply-To: <20241004221257.2888603-1-justin.chen@broadcom.com>
On Fri, Oct 04, 2024 at 03:12:57PM -0700, Justin Chen wrote:
> The mailbox layer has its own queue. However this confuses the per
> message timeouts since the clock starts ticking the moment the messages
> get queued up. So all messages in the queue have there timeout clocks
> ticking instead of only the message inflight. To fix this, lets move the
> queue back into the SCMI layer.
>
I think this has come up in the past. We have avoided adding addition
locking here as the mailbox layer takes care of it. Has anything changed
recently ?
--
Regards,
Sudeep
next prev parent reply other threads:[~2024-10-07 13:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 22:12 [PATCH] firmware: arm_scmi: Queue in scmi layer for mailbox implementation Justin Chen
2024-10-07 12:34 ` Cristian Marussi
2024-10-07 13:04 ` Sudeep Holla [this message]
2024-10-07 13:10 ` Cristian Marussi
2024-10-07 17:58 ` Justin Chen
2024-10-08 2:43 ` Peng Fan
2024-10-08 5:02 ` Justin Chen
2024-10-08 12:10 ` Cristian Marussi
2024-10-08 13:23 ` Sudeep Holla
2024-10-08 13:34 ` Sudeep Holla
2024-10-08 13:37 ` Cristian Marussi
2024-10-08 19:23 ` Justin Chen
2024-10-08 19:40 ` Justin Chen
2024-10-09 8:32 ` Cristian Marussi
2024-10-09 19:20 ` Justin Chen
2024-10-08 13:17 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwPcSmRpTGrCdt6I@bogus \
--to=sudeep.holla@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cristian.marussi@arm.com \
--cc=florian.fainelli@broadcom.com \
--cc=justin.chen@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).