From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6363ACFB43F for ; Mon, 7 Oct 2024 13:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PdwqZr+4mfdUzMmI4YcFeyhbauOc4sAG0T865/oQKEU=; b=egy7A7flvP5NNy9Rc2cSMW1/18 EuFcrnRuSPb6ABXmAqKE13WLKzvlr4dvRHI3hYbJNUWeg8BPFtcvXIUhPV1vT4w1AGNdQEB8PAsqL o1ScPbR3SryBXs7ktORwzYeM1El581W9hSgSwDZyCYZpo3P8UdOGj+yNulJv3xN0JR6noyEnpKrb/ uzcOpBumiJQlFjj1SnWHFjv+GNKL0I6BG9zkRXLwnOAYbyxz4hNRQ2IO+OFAIwOK3/ygGPIlyDoop wH6k9Arcvd9u+VF18+AAgGi/6bFfhh0FmJzfghDT2zToP473/GJUs2XLB3tjZWkw+yZdODlbSCFMx 4ngTIi5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxnkJ-00000002VXQ-3kIp; Mon, 07 Oct 2024 13:25:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxnPO-00000002RHe-0UkC for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2024 13:04:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C8472DA7; Mon, 7 Oct 2024 06:04:44 -0700 (PDT) Received: from bogus (unknown [10.1.196.36]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C513B3F640; Mon, 7 Oct 2024 06:04:13 -0700 (PDT) Date: Mon, 7 Oct 2024 14:04:10 +0100 From: Sudeep Holla To: Justin Chen Cc: arm-scmi@vger.kernel.org, cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org, peng.fan@nxp.com, Sudeep Holla , bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com Subject: Re: [PATCH] firmware: arm_scmi: Queue in scmi layer for mailbox implementation Message-ID: References: <20241004221257.2888603-1-justin.chen@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241004221257.2888603-1-justin.chen@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_060418_259418_B09AEC81 X-CRM114-Status: UNSURE ( 9.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 04, 2024 at 03:12:57PM -0700, Justin Chen wrote: > The mailbox layer has its own queue. However this confuses the per > message timeouts since the clock starts ticking the moment the messages > get queued up. So all messages in the queue have there timeout clocks > ticking instead of only the message inflight. To fix this, lets move the > queue back into the SCMI layer. > I think this has come up in the past. We have avoided adding addition locking here as the mailbox layer takes care of it. Has anything changed recently ? -- Regards, Sudeep