From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2617CFB43F for ; Mon, 7 Oct 2024 13:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ObfpsJxhlhUPGfb20+r5FkrK8XmgkHEAeNMGnFYXuHQ=; b=AEUl8aHHZF9K9AaPYExjHK7IKf 1AJRglIjNV4x01Xys7/gxIFCOvQ3iKVu47KN8BR5SEDMBp/PKwoagpctKj+/gep4WKniDP5zdYKQL UE5H1Kv+ZfofXT++Xr2MtsBttSXikgmX1xOoYmKzQWc21lmPgNujVHt2NUa/t2WWur+ORb1WRncdF SgLsNONMJaTC88dl0ckfjxnWI5+ibn8sErbneUF3Ece4OtnCffxzovBPDzYX+vZn5WbOSHRohg+X+ W30QHRmJWV1ht8aHOJ+ke/1v64hwkkr19+oDUN8x7yroRh43b/30Gn0ZyunBULGC58VYtDBiMHbbm +YI0Gz9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxnmp-00000002VxO-2Efa; Mon, 07 Oct 2024 13:28:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxnYc-00000002SkP-45jr for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2024 13:13:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E12D2DA7; Mon, 7 Oct 2024 06:14:19 -0700 (PDT) Received: from bogus (unknown [10.1.196.36]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1622D3F640; Mon, 7 Oct 2024 06:13:47 -0700 (PDT) Date: Mon, 7 Oct 2024 14:13:45 +0100 From: Sudeep Holla To: Florian Fainelli Cc: linux-arm-kernel@lists.infread.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Cristian Marussi , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list), arm-scmi@vger.kernel.org (open list:SYSTEM CONTROL & POWER/MANAGEMENT INTERFACE), linux-arm-kernel@lists.infradead.org (moderated list:SYSTEM CONTROL & POWER/MANAGEMENT INTERFACE), justin.chen@broadcom.com, opendmb@gmail.com, kapil.hali@broadcom.com, bcm-kernel-feedback-list@broadcom.com, Sudeep Holla , Arnd Bergmann Subject: Re: [PATCH] firmware: arm_scmi: Give SMC transport precedence over mailbox Message-ID: References: <20241006043317.3867421-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241006043317.3867421-1-florian.fainelli@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_061351_078449_4CE88814 X-CRM114-Status: GOOD ( 16.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 05, 2024 at 09:33:17PM -0700, Florian Fainelli wrote: > Broadcom STB platforms have for historical reasons included both > "arm,scmi-smc" and "arm,scmi" in their SCMI Device Tree node compatible > string. > I assume in the same order. > After the commit cited in the Fixes tag and with a kernel > configuration that enables both the SCMI and the Mailbox transports, we ^^^^^ s/SCMI/SMC ? > would probe the mailbox transport, but fail to complete since we would > not have a mailbox driver available. > I always assumed the node compatible match happens from the more specific compatible(on the left) to the more generic ones(on the right) from the compatible property list. Looks like that was a wrong assumption then ? > By keeping the SMC transport objects linked first, we can let the > platform driver, match the compatible string and probe successfully with > no adverse effects on platforms using the mailbox transport. > I don't have strong objection to the patch itself, happy to get it merged. Just curious if my understanding of the issue is correct. I think Cristian has more detailed query, so just responding to that will suffice. > Fixes: b53515fa177c ("firmware: arm_scmi: Make MBOX transport a standalone driver") > Signed-off-by: Florian Fainelli > Change-Id: I8e348e3e0deabdc5c1d596929d7f9134793f346e Spurious from internal gerrit repo ? -- Regards, Sudeep