From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E879ACEF172 for ; Tue, 8 Oct 2024 13:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2s8dV9YOqtVti5t7YCAWcy0ZoMDL0K8qWHAHfPmPQ6I=; b=BUq30YxguCvUhMJsbmL7khr67s zvESmvhLiP2zHlOAZbrlJ1VL5NurO/EeJGlIX8Vin0UfcxFXyLy/Bb/k3pvJPxB/4Ispfj5pvIqUb j5c7MFcBWTRXxJxlKpaxBIdsXszIcjL5mrbTGSqO0itmnO6Fath6cvX8S62UWfD7unj++7m8uk80a 7M6zIFIP9b6ZgIrKhyeWZ4Pru6P55cBBGEW9HZR2c/7suWaTZ3OZ4HEvVskBlK6TXiLlA9lFqgf+T WXgssMUeofdoXb2KnBSiAgq+ll5pm/4RU8RkprX9lpRgDkE73C9SeRLOGPv7cP9k4twc6TYTC9yG0 oNAEuWrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syA0c-00000005wBh-2MyM; Tue, 08 Oct 2024 13:12:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy9zJ-00000005vy9-0SSl for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2024 13:10:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D983FDA7; Tue, 8 Oct 2024 06:11:21 -0700 (PDT) Received: from bogus (e133711.arm.com [10.1.196.77]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0A8DE3F640; Tue, 8 Oct 2024 06:10:49 -0700 (PDT) Date: Tue, 8 Oct 2024 14:10:47 +0100 From: Sudeep Holla To: Cristian Marussi Cc: Florian Fainelli , linux-arm-kernel@lists.infread.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sudeep Holla , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "open list:SYSTEM CONTROL & POWER/MANAGEMENT INTERFACE" , "moderated list:SYSTEM CONTROL & POWER/MANAGEMENT INTERFACE" , justin.chen@broadcom.com, opendmb@gmail.com, kapil.hali@broadcom.com, bcm-kernel-feedback-list@broadcom.com, Arnd Bergmann Subject: Re: [PATCH] firmware: arm_scmi: Give SMC transport precedence over mailbox Message-ID: References: <20241006043317.3867421-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_061053_210327_AD104616 X-CRM114-Status: GOOD ( 16.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 08, 2024 at 01:26:53PM +0100, Cristian Marussi wrote: > On Mon, Oct 07, 2024 at 10:07:46AM -0700, Florian Fainelli wrote: [...] > > There is no recovery without the patch, we are not giving up the arm_scmi > > platform device because there is no mechanism to return -ENODEV and allow > > any of the subsequent transport drivers enabled to attempt to take over the > > platform device and probe it again. > > > > Ok...so it is a workaround hack indeed....but it seems NOT to have bad > side effects and there is definitely no cleaner way to make it bind > properly...beside fixing your DTs for the future... As I mentioned earlier, I am not against the change as it doesn't have any other side-effects and just accidentally fixes the issue you have. But it does sound like a hacky solution to your problem. What if some other legit reason(theoretically) it needs to be reversed again in the future. So I am still interested to see if we can fix it without this. -- Regards, Sudeep