From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9700CEFC34 for ; Tue, 8 Oct 2024 17:10:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P1HdVjxpJO4uOS1TfmcHm9rAv7nPb4cL1hLjnfWxb8I=; b=Sti1rLhBv6uiMMRseHvbO2FDFb aP7Xvw6DXElXAPXZZULh2OBeNek77b/Lup2Sw1vqOpoGgeylt5GR8BmuqbG1fFcfoqDxeGsyJiAYQ RLdU5NUu4itqas+sOaDY70UiXpJl3LYd3Fpvehtch/1HbLd6IqPX2mcmRd1fSEmAJEafexVCFzQx4 G0uioFSJ9MTwpbJx1ABpC0HgaQrnv3XrSCPlV8QM11yPu6ru9GZ4opWTWysBX7dn0f9t+h/uf7Osc tTPFSiS476aQB6MGEcJX+tndAf6YrdabXX0oR+HjSoDB53YC9SnMqAVKHVvbVkidZY7I5MI7I00zh FzIbesjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syDjE-00000006bjI-0i92; Tue, 08 Oct 2024 17:10:32 +0000 Received: from mgamail.intel.com ([192.198.163.18]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syDhs-00000006bVg-0BrF for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2024 17:09:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728407348; x=1759943348; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1at/Cmreu+1nGtOh763pSQQTzVt2a3e35+RaESMYeLo=; b=gI56L4O23ZivKVpZLC6lurVv6bip3RQ1v1X2Yfl1wmWT3iLpgFIWSoiT aUr4VBxA4soC50PLELLqvT6Y09BvAXllckZxrw7gUVLWVO7foVQxGHKUR EyTLgwwJm6/cNm2ZyjkXPFmPLt1Wong0WITYUuds8UMzQj36G6yG2+HyP Ti6yEtIk55IvDDJT5A3fXZe6VnMYCDDWrAeN4sQXivBm2PlG3UGVS2JGA hQSWJbbMRKWU3qmSx1Xtg+DYLeZ7imtbq3TzAim0n2QxsAWCxXDQwTya8 1vGR/c8sHlQE+r1/zLleWnbHguy7HWI2T6T4tePXW39PvVs+/ga6ka5E3 w==; X-CSE-ConnectionGUID: BAdXRlr7SD2On/vUbOgbLA== X-CSE-MsgGUID: BVyPrSGhTxmzOaL7+YHucg== X-IronPort-AV: E=McAfee;i="6700,10204,11219"; a="27083404" X-IronPort-AV: E=Sophos;i="6.11,187,1725346800"; d="scan'208";a="27083404" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2024 10:08:55 -0700 X-CSE-ConnectionGUID: zTnGbDG/Tc2uyNQJMY6POA== X-CSE-MsgGUID: KnBTbYCxSHWZ406V5oOVfw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,187,1725346800"; d="scan'208";a="79886196" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa003.fm.intel.com with ESMTP; 08 Oct 2024 10:08:52 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 885A220F; Tue, 08 Oct 2024 20:08:51 +0300 (EEST) Date: Tue, 8 Oct 2024 20:08:51 +0300 From: Andy Shevchenko To: Frank Li Cc: Vinod Koul , Paul Cercueil , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Subject: Re: [PATCH v1 1/4] dmaengine: Replace dma_request_slave_channel() by dma_request_chan() Message-ID: References: <20241007150852.2183722-1-andriy.shevchenko@linux.intel.com> <20241007150852.2183722-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_100908_115480_4453737A X-CRM114-Status: GOOD ( 14.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 07, 2024 at 11:52:21AM -0400, Frank Li wrote: > On Mon, Oct 07, 2024 at 06:06:45PM +0300, Andy Shevchenko wrote: ... > > * Please note in any other slave case, you have to setup chan->private > > * with 'struct imx_dma_data' in your own filter function if you want to > > - * request dma channel by dma_request_channel() rather than > > - * dma_request_slave_channel(). Othwise, 'MEMCPY in case?' will appear > > - * to warn you to correct your filter function. > > + * request DMA channel by dma_request_channel(), otherwise, 'MEMCPY in > > + * case?' will appear to warn you to correct your filter function. > > It just change comments, why combined with dmaengine.h change. Because this comment is related to what is done below. ... > > struct dma_chan *chan; > > > > - chan = dma_request_slave_channel(dev, name); > > - if (chan) > > + chan = dma_request_chan(dev, name); Here is no more dma_request_slave_channel() calls as in the mentioned comment. > > + if (!IS_ERR(chan)) > > return chan; -- With Best Regards, Andy Shevchenko