From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30A9BCEFC36 for ; Tue, 8 Oct 2024 17:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+fS91WXXYG9YWhwI9goxlBJc8bQWmWnnBD7cMpmbJ90=; b=A1Tj/VxeBj/Y6E26fdShDmXhdn hPuY5DYcfk8eXqCJ66EVQjMmyDHb6wWA/wiTCxkpwT75t4ObsNtdyv/oDD4cpXJ+mhsR2XPcEWoP+ Yq4DtK/1hnY7c7WphZ0kJoa4tC6u2IuxSH80lffzj34hde0DcxgwXc/wydj3kNjleqtHVFg8dPW9W bx25bZVY4sfegiDJD9aO9IBJWhjIzuv8P5HzkPKoD6wICuagdvvkWyY0lsUjsgVCkVPB4GVmBpv0t HyQcosIEv2WMY3+jt328drYfCjzexl4l7Yfrs0mzQqq+jaEUeK6+i4nFMXzu0S4bYwtPip1IlrsUe Y5AX3TXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syDrS-00000006cwk-2Puf; Tue, 08 Oct 2024 17:19:02 +0000 Received: from mgamail.intel.com ([192.198.163.7]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syDq6-00000006cj4-1EeD for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2024 17:17:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728407858; x=1759943858; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Fy+Wq9ZxfFcFigNOpkbzmgAg/wR1mFMZq7h7mkjs+gM=; b=cv4/rBQLJDxfvh1m6OUrFqTvz+eeBPF7VFF67lBXKl4TSeAaqIS8Zonl e2qsmb2MLOf4f7slIvFnM4+KBPYIVzeM4vPco1t9/VqdbxvRg2WlKxmyB EubYXWhZFXXXTqLExBHZhb+hJIYFdxLRqtVFxBjcZq5ftQsTM+IfpmIwA ZaR3QJp+DjCrFAcA8+QxiY4V7j6qlXgDM6Apkza+qEhmCnkMoIybxRGBk rbrbMXWQBTAjRIBV09odJieQ9mFK4fd4+aFG/PM1xauhfE8ZQ1LVwVZiX 2gYEtQcSRMriibzy/Pv8/tWOtHRKGA7OdlXh3IUqn2l/r5sQpR8BdaWfN g==; X-CSE-ConnectionGUID: oZgjWMX3QmmDHKI5Dg964g== X-CSE-MsgGUID: boPRWjW6Qnm/G7ryh2WPYA== X-IronPort-AV: E=McAfee;i="6700,10204,11219"; a="53035761" X-IronPort-AV: E=Sophos;i="6.11,187,1725346800"; d="scan'208";a="53035761" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2024 10:17:37 -0700 X-CSE-ConnectionGUID: MKR+Nn0RRaGCDY7iiRW3GA== X-CSE-MsgGUID: 4zxQgl0fTUaE1kVU6CM4Pg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,187,1725346800"; d="scan'208";a="75782957" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa010.jf.intel.com with ESMTP; 08 Oct 2024 10:16:59 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id AEEA620F; Tue, 08 Oct 2024 20:16:57 +0300 (EEST) Date: Tue, 8 Oct 2024 20:16:57 +0300 From: Andy Shevchenko To: Frank Li Cc: Vinod Koul , Paul Cercueil , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Subject: Re: [PATCH v1 4/4] dmaengine: Unify checks in dma_request_chan() Message-ID: References: <20241007150852.2183722-1-andriy.shevchenko@linux.intel.com> <20241007150852.2183722-5-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_101738_546158_652E4B37 X-CRM114-Status: GOOD ( 10.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 07, 2024 at 12:05:56PM -0400, Frank Li wrote: > On Mon, Oct 07, 2024 at 06:06:48PM +0300, Andy Shevchenko wrote: > > Use firmware node and unify checks accordingly in dma_request_chan(). > > As a side effect we get rid of the node dereferencing in struct device. > > suggest: > > Use dev_fwnode() to simple check logic for device tree and ACPI in > dma_request_chan(). Sure, thanks! -- With Best Regards, Andy Shevchenko